[HOLD for payment 2023-10-09] [$500] mWeb Safari - When go from Get Assistance Page to Settings Workspace 'Save' button glitches

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. On https://staging.new.expensify.com, Go to specific workspace
2. Go to Settings and Click '?' icon
3. On Get assistance page, click back to go to Workspace Settings page again

Expected Result:

Save button should not change its position and no glitches

Actual Result:

Save button glitches and jumps from the position

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.73-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

RPReplay_Final1695008049.MP4

Expensify/Expensify Issue URL:
Issue reported by: @studentofcoding
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1695017796209329

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~013e33d6085e621ef7
• Upwork Job ID: 1705229752570806272
• Last Price Increase: 2023-09-22
• Automatic offers:
• jjcoffee | Reviewer | 26873219
• studentofcoding | Contributor | 26873221
• studentofcoding | Reporter | 26873222

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~013e33d6085e621ef7

[melvin-bot]

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to @mallenexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jjcoffee (External)

[kavimuru]

Proposal

Please re-state the problem that we are trying to solve in this issue

When go from Get Assistance Page to Settings Workspace ‘Save’ button are going up and down

What is the root cause of that problem?

We still haven’t managed/get-assistance/* URL structure into our apple-app-site-association file, therefore the Smart App Banner on Workspace Settings Page are make the ‘Save’ Button going up and down

What changes do you think we should make in order to solve the problem?

Add /get-assistance/* into apple-app-site-association like below:
{
"applinks": {
"details": [
{
"appIDs": ["368M544MTT.com.chat.expensify.chat"],
"components": [
//...
{
"/": "/get-assistance/*",
"comment": "Get Assistance Pages"
}
]
}
]
},
"webcredentials": {
"apps": ["368M544MTT.com.chat.expensify.chat"]
}
}

What alternative solutions did you explore? (Optional)

None

Result

[studentofcoding]

Proposal

Reformated the Above Proposal that sended by myself here

Please re-state the problem that we are trying to solve in this issue

When go from Get Assistance Page to Settings Workspace ‘Save’ button glitches

What is the root cause of that problem?

We still haven’t managed /get-assistance/* URL structure into our apple-app-site-association file, therefore the Smart App Banner on Workspace Settings Page makes the ‘Save’ Button glitches as the initial layout change suddenly on /workspace/* when Smart App Banner showing from /get-assistance/* page. This is only happening on iOS, as Chrome didn't have Native Smart App Banner integration

What changes do you think we should make in order to solve the problem?

Add /get-assistance/* into apple-app-site-association like below, so we can have smooth transition from these pages

{
    "applinks": {
        "details": [
            {
                "appIDs": ["368M544MTT.com.chat.expensify.chat"],
                "components": [
                    //...
                    {
                        "/": "/get-assistance/*",
                        "comment": "Get Assistance Pages"
                    }
                ]
            }
        ]
    },
    "webcredentials": {
        "apps": ["368M544MTT.com.chat.expensify.chat"]
    }
}

What alternative solutions did you explore? (Optional)

None

@mallenexpensify @jjcoffee @lschurr

[lschurr]

@jjcoffee - could you review these proposals?

[jjcoffee]

@studentofcoding's proposal LGTM! The RCA seems correct (although I'd be curious to know why the button jiggles in the first place, I assume this may just be a limitation of the way the smart app banner is inserted though) and the solution is fine (we just missed a case - I also see a similar issue was fixed the same way a few weeks ago).

🎀👀🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @tgolen, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[studentofcoding]

@studentofcoding's proposal LGTM! The RCA seems correct (although I'd be curious to know why the button jiggles in the first place, I assume this may just be a limitation of the way the smart app banner is inserted though) and the solution is fine (we just missed a case - I also see a similar issue was fixed the same way a few weeks ago).

🎀👀🎀 C+ reviewed

Thanks @jjcoffee!, I've added the details on why the button jiggles, and yes the solution are similar to recent fix

[melvin-bot]

📣 @jjcoffee 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @studentofcoding 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

📣 @studentofcoding 🎉 An offer has been automatically sent to your Upwork account for the Reporter role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[studentofcoding]

The PR is opened @jjcoffee @tgolen!

For some context on testing, the Smart App Banner is only shown after the updated well-known/apple-app-site-association is deployed to the Staging/Production like we have here on staging or here on production

[melvin-bot]

🎯 ⚡️ Woah @jjcoffee / @studentofcoding, great job pushing this forwards! ⚡️

The pull request got merged within 3 working days of assignment, so this job is eligible for a 50% #urgency bonus 🎉

• when @studentofcoding got assigned: 2023-09-25 22:55:19 Z
• when the PR got merged: 2023-09-27 01:16:30 UTC

On to the next one 🚀

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.75-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [Can only be tested after deployed to Staging/Production] Add /get-assistance/* url to show Smart App Banner #28222

If no regressions arise, payment will be issued on 2023-10-09. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @studentofcoding requires payment offer (Contributor)
• @jjcoffee requires payment offer (Reviewer)
• @studentofcoding requires payment offer (Contributor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@jjcoffee] The PR that introduced the bug has been identified. Link to the PR:
• [@jjcoffee] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@jjcoffee] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@jjcoffee] Determine if we should create a regression test for this bug.
• [@jjcoffee] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@lschurr] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[studentofcoding]

It's working on both Staging and Production

trim.6ABDD553-FB19-4862-8ED9-2EB3BDF7BDFA.MOV

Note: don't forget to update the New Dot App and remove cache on safari

[studentofcoding]

Please kindly proceed the payment @lschurr @jjcoffee, thanks!

[jjcoffee]

• The PR that introduced the bug has been identified. Link to the PR: N/A the URL has always been missing from the apple-app-site-association file
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A - not really an easy one to catch
• Determine if we should create a regression test for this bug. No - pretty minor glitch that happens on a single screen on a single platform
• If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. N/A

[lschurr]

Payment summary:

• Bug reporter: @studentofcoding $50
• Contributor: @studentofcoding $750
• Contributor+: @jjcoffee $750

[lschurr]

All payments made in Upwork. Closing!

[studentofcoding]

All payments made in Upwork. Closing!

Thanks @lschurr!