Web - Login - 'Couldn't retrieve account details' error shows up for new account

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Go to https://26772.pr-testing.expensify.com/.
2. Enter a new email with no ND account.
   3, Click Continue.

Expected Result:

User enters magic code page with no error message.

Actual Result:

The error message 'Couldn't retrieve account details, please try to sign in again‘ shows up in magic code page.

This issue is also reproducible on staging build.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: v1.3.72-9 PR:26772

Reproducible in staging?: Y

Reproducible in production?: N

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6210239_bandicam_2023-09-22_18-04-09-386.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause-Internal Team

Slack conversation: @

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @chiragsalian (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[izarutskaya]

Issue found when testing this PR# #26772

[kbecciv]

@aman-atg QA team reported first

[rojiphil]

@chiragsalian
I think, BE needs a fix here.
Here are my observations:
When a new email address is used for login (i.e. which was not previously used in BE), the BeginSignIn API returns with 0 as jsonCode. But, when an existing email address is used for login, the API returns with 200 as jsonCode. This is why this problem occurs. Not sure what significance it has for BE to send 0 as jsonCode for new login.
I think, BE needs to send 200 as jsonCode even for a new login.

[chiragsalian]

Interesting theory, but somehow i dont think we changed the backend code for this flow in a while and yet it works fine on production but not on staging. Have you verified if the backend returns something different for production vs staging. I've yet to confirm it. I'm working on building this on my dev environment at the moment.

[chiragsalian]

staging, lol wtf - invalid socket ID,

[chiragsalian]

Same payload between staging and production but the response is different. One has an error message and the other does not. Weird. Okay this does not look like an App deploy blocker but I'll investigate further before i clear it.

[chiragsalian]

Yup, the issue is definitely only related to backend. When i use production code it works just fine. I think i found the offending backend PR but I'll test it a bit more before i confirm.

[chiragsalian]

I've got a fix up. Testing it a bit and then ill put it for review. If it gets reviewed/merged soon I'll move it to staging immediately.

[chiragsalian]

This is done. I CP-d a fix for this. I tested on staging and it looks good to me.
Can you retest @izarutskaya and if the issue is resolved can you close out this issue.

[chiragsalian]

I think this is a non issue anymore. Closing. Feel free to reopen if anyone disagrees.

[izarutskaya]

Hi @chiragsalian, sorry for waiting. Works fine now. Thanks

Recording.1656.mp4