-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$500] [Awaiting Payment]2FA login - Error message shows incorrect 2FA code when incorrect recovery code is used #28044
Comments
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
|
Triggered auto assignment to @chiragsalian ( |
@alitoshmatov @abdulrahuman5196 @MonilBhavsar Seems like a regression from your PR? I dont think this is that important though to be a blocker, its not blocking user from logging in and also its rare to use recovery code and the one you have already used. Demoting to a bug and we should fix this probably as a regression from the PR |
Triggered auto assignment to @puneetlath ( |
Bug0 Triage Checklist (Main S/O)
|
@mountiny This error message is sent from the backend for used recovery code, also the same api is used to verify 2fa code and recovery code. Noticed it in original PR but forgot to mention it. |
Thats ok, we can make this internal if we can debug this, but this probably should have been raised during the PR review |
Triggered auto assignment to @joaniew ( |
@joaniew In olddot, error message looks like ![]() And in newDot, I propose to use the following - ![]() ![]() Could you please confirm. Thank you! cc @srikarparsi |
@MonilBhavsar I'm a bit confused what you're proposing.. just want to double check - you're showing a version with the authenticator and one version with the recovery code? Where it says For recovery code: I think that specification is nicer |
PR is deployed to prod. @puneetlath assigning you the issue as you were assigned as a part of Bugzero team. |
@MonilBhavsar commented for reporting bonus |
Unable to auto-create job on Upwork. The BZ team member should create it manually for this issue. cc @thienlnam |
Current assignee @abdulrahuman5196 is eligible for the External assigner, not assigning anyone new. |
Upwork seems to be having issues. Will try again later. |
Job added to Upwork: https://www.upwork.com/jobs/~011dfd59ea4353f356 |
Current assignee @abdulrahuman5196 is eligible for the External assigner, not assigning anyone new. |
@ayazhussain79 sent you an offer. |
@puneetlath offer accepted, Thank you |
All paid! |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Issue found when executing PR #23390
Action Performed:
Precondition:
5.Click Sign in.
Expected Result:
The error message mentions incorrect recovery code.
Actual Result:
The error message mentions two-factor authentication code instead of recovery code.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Version Number: 1.3.73.0
Reproducible in staging?: y
Reproducible in production?: new feature
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Bug6210906_20230922_222809.mp4
Expensify/Expensify Issue URL:
Issue reported by: @ayazhussain79
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1695308760173509
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: