[HOLD for payment 2023-10-12] [$500] Chat - Expand button does not show if composer only contains new line

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

Action Performed:

1. Open any chat
2. Add >= 3 new lines on the composer

Expected Result:

The expand button is shown above + button

Actual Result:

The expand button is not visible until you type a character other than newline/space

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.73.0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-09-22.at.18.36.10.mov

Recording.4738.mp4

Expensify/Expensify Issue URL:
Issue reported by: @bernhardoj
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1695387935862449

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01d0f3b8c804481cd5
• Upwork Job ID: 1705987383652581376
• Last Price Increase: 2023-09-24
• Automatic offers:
• abdulrahuman5196 | Reviewer | 26935777
• bernhardoj | Contributor | 26935778
• bernhardoj | Reporter | 26935779

[melvin-bot]

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01d0f3b8c804481cd5

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to @sakluger (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (External)

[kbecciv]

Proposal by: @bernhardoj
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1695387935862449

Proposal

Please re-state the problem that we are trying to solve in this issue.

The expand button is not visible if we only have new lines on the composer without any characters.

What is the root cause of that problem?

In #27015, we are hiding the expand button if the composer is empty (only contains space).

App/src/pages/home/report/ReportActionCompose/ReportActionCompose.js

Line 346 in 7bebfd3

isFullComposerAvailable={isFullComposerAvailable && !isCommentEmpty}

It is to fix an issue where the expand button is not immediately hidden after sending a comment and it is their alternative solution, and then based on this comment, they decided to use the main solution instead.
Then, this comment suggested adding it back but I didn't see any improvement as said in the comment and instead created a regression.

What changes do you think we should make in order to solve the problem?

Remove !isCommentEmpty

App/src/pages/home/report/ReportActionCompose/ReportActionCompose.js

Line 346 in 7bebfd3

isFullComposerAvailable={isFullComposerAvailable && !isCommentEmpty}

[sofi-a]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The expand button does not show if there are only new lines in the composer.

What is the root cause of that problem?

Comments containing only white spaces are considered to be empty.

App/src/pages/home/report/ReportActionCompose/ComposerWithSuggestions.js

Line 185 in 5099522

setIsCommentEmpty(!!newComment.match(/^(\s)*$/));

What changes do you think we should make in order to solve the problem?

Check if the comment is actually empty instead of checking if it only contains whitespaces.

            setIsCommentEmpty(_.isEmpty(newComment));

What alternative solutions did you explore? (Optional)

Remove !isCommentEmpty here.

[jopaleti]

Hello, can I still apply to solve this bug?

[melvin-bot]

📣 @jopaleti! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[abdulrahuman5196]

Reviewing now

[abdulrahuman5196]

Proposal by @bernhardoj #28093 (comment) looks good and works well.

🎀 👀 🎀
C+ Reviewed

[melvin-bot]

Triggered auto assignment to @marcaaron, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[abdulrahuman5196]

@bernhardoj Could you post a proposal from your GH account for reference?

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The expand button is not visible if we only have new lines on the composer without any characters.

What is the root cause of that problem?

In #27015, we are hiding the expand button if the composer is empty (only contains space).

App/src/pages/home/report/ReportActionCompose/ReportActionCompose.js

Line 346 in 7bebfd3

isFullComposerAvailable={isFullComposerAvailable && !isCommentEmpty}

It is to fix an issue where the expand button is not immediately hidden after sending a comment and it is their alternative solution, and then based on this comment, they decided to use the main solution instead.
Then, this comment suggested adding it back but I didn't see any improvement as said in the comment and instead created a regression.

What changes do you think we should make in order to solve the problem?

Remove !isCommentEmpty

App/src/pages/home/report/ReportActionCompose/ReportActionCompose.js

Line 346 in 7bebfd3

isFullComposerAvailable={isFullComposerAvailable && !isCommentEmpty}

[marcaaron]

I'm confused. But assume this will not cause any regression? Why was it added in the first place?

[melvin-bot]

📣 @abdulrahuman5196 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @bernhardoj 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

📣 @bernhardoj 🎉 An offer has been automatically sent to your Upwork account for the Reporter role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[bernhardoj]

PR is up, but there is an issue on main.

cc: @abdulrahuman5196

[abdulrahuman5196]

I'm confused. But assume this will not cause any regression? Why was it added in the first place?

It was added for an extra check I assume. During initial testing there wasn't any regression observed.

Tagging original author as well on this @HezekielT #28093 (comment)

[HezekielT]

@abdulrahuman5196 Yes, it was added for an extra check.

We noticed a little improvement in the transition( on native devices) after adding that check, that is the reason. Please check #27015(comment) . Sorry, we missed this case while testing.

[abdulrahuman5196]

@abdulrahuman5196 Yes, it was added for an extra check.

We noticed a little improvement in the transition( on native devices) after adding that check, that is the reason. Please check #27015(comment) . Sorry, we missed this case while testing.

Thank you confirming. I checked now and the new PR is not causing any mentioned regression on transition.

[melvin-bot]

🎯 ⚡️ Woah @abdulrahuman5196 / @bernhardoj, great job pushing this forwards! ⚡️

The pull request got merged within 3 working days of assignment, so this job is eligible for a 50% #urgency bonus 🎉

• when @bernhardoj got assigned: 2023-09-29 04:47:51 Z
• when the PR got merged: 2023-10-03 00:09:33 UTC

On to the next one 🚀

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.77-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix expand button won't show if composer contains only new lines/spaces #28512

If no regressions arise, payment will be issued on 2023-10-12. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @abdulrahuman5196 requires payment offer (Reviewer)
• @bernhardoj requires payment offer (Contributor)
• @bernhardoj requires payment offer (Contributor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@abdulrahuman5196] The PR that introduced the bug has been identified. Link to the PR:
• [@abdulrahuman5196] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@abdulrahuman5196] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@abdulrahuman5196] Determine if we should create a regression test for this bug.
• [@abdulrahuman5196] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@abekkala] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: N/A

[abekkala]

PAYMENTS FOR OCT 12

• @bernhardoj (Reporter) [$50]
• @bernhardoj (Contributor) [$500 + $250 bonus, if no regression]
• @abdulrahuman5196 (Reviewer) [$500 + $250 bonus, if no regression] - please complete the checklist above before payments are processed

[abdulrahuman5196]

The PR that introduced the bug has been identified. Link to the PR:

#27015

The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

https://github.com/Expensify/App/pull/27015/files#r1352818508

Determine if we should create a regression test for this bug.
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

No. Regression tests is not beneficial for this minor case.

[abekkala]

@abdulrahuman5196 [$750] payment made and contract ended - thank you! 🎉

[abekkala]

@bernhardoj [$800] payment made and contract ended - thank you! 🎉