Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hold for payment 10-06-2023] Payment issue for E/App PR#28050 #28104

Closed
melvin-bot bot opened this issue Sep 25, 2023 · 14 comments
Closed

[Hold for payment 10-06-2023] Payment issue for E/App PR#28050 #28104

melvin-bot bot opened this issue Sep 25, 2023 · 14 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Internal Requires API changes or must be handled by Expensify staff Task Weekly KSv2

Comments

@melvin-bot
Copy link

melvin-bot bot commented Sep 25, 2023

Issue created to compensate the Contributor+ member for their work on #28050
E/E issue linked to the PR - no internal issue.
Contributor+ member who reviewed the PR - @allroundexperts.

Wait 7 days after the PR is deployed to production before issuing payment in case there are regressions.

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~015e417ce8f9d866f1
  • Upwork Job ID: 1706122611619536896
  • Last Price Increase: 2023-09-25
@melvin-bot melvin-bot bot added Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Task Weekly KSv2 labels Sep 25, 2023
@melvin-bot melvin-bot bot added the Internal Requires API changes or must be handled by Expensify staff label Sep 25, 2023
@melvin-bot
Copy link
Author

melvin-bot bot commented Sep 25, 2023

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link
Author

melvin-bot bot commented Sep 25, 2023

Job added to Upwork: https://www.upwork.com/jobs/~015e417ce8f9d866f1

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Sep 25, 2023
@melvin-bot
Copy link
Author

melvin-bot bot commented Sep 25, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@melvin-bot
Copy link
Author

melvin-bot bot commented Sep 25, 2023

Current assignee @allroundexperts is eligible for the Internal assigner, not assigning anyone new.

@lschurr
Copy link
Contributor

lschurr commented Sep 25, 2023

@allroundexperts - are you paid in Upwork or Newdot?

@allroundexperts
Copy link
Contributor

Newdot!

@lschurr
Copy link
Contributor

lschurr commented Sep 27, 2023

Just waiting for this to be merged so that we can start the 7 day waiting period and pay.

@lschurr
Copy link
Contributor

lschurr commented Sep 28, 2023

It looks like this PR resulted in several regressions - is that correct @allroundexperts?

@allroundexperts
Copy link
Contributor

Yep. That's correct @lschurr!

@lschurr
Copy link
Contributor

lschurr commented Sep 29, 2023

Got it, thanks! So this was just deployed to prod a few hours ago, so payment will be issued on October 6th.

@lschurr lschurr changed the title Payment issue for E/App PR#28050 [Hold for payment 10-06-2023] Payment issue for E/App PR#28050 Sep 29, 2023
@lschurr lschurr added Weekly KSv2 and removed Daily KSv2 labels Sep 29, 2023
@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels Oct 1, 2023
@lschurr
Copy link
Contributor

lschurr commented Oct 3, 2023

Not overdue.

@melvin-bot melvin-bot bot removed the Overdue label Oct 3, 2023
@lschurr lschurr added Weekly KSv2 and removed Daily KSv2 labels Oct 3, 2023
@lschurr
Copy link
Contributor

lschurr commented Oct 6, 2023

Payment summary:

Contributor+: @allroundexperts $250 (The PR caused a regression so it's 50%)

Please request payment in Newdot!

@JmillsExpensify
Copy link

$250 payment approved for @allroundexperts based on summary.

@lschurr
Copy link
Contributor

lschurr commented Oct 10, 2023

This is done :)

@lschurr lschurr closed this as completed Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Internal Requires API changes or must be handled by Expensify staff Task Weekly KSv2
Projects
None yet
Development

No branches or pull requests

3 participants