[HOLD for payment 2023-10-09] [HOLD for payment 2023-10-05] Members - Clicking on 'Invite' button navigates back to Workspace page

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Create a workspace
2. Click on 'Members'
3. Click on 'Invite' button

Expected Result:

User should navigate to the 'Invite members' page

Actual Result:

User is navigated back to workspace page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.74.0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-09-25.at.10.35.34.AM.mov

Recording.4748.mp4

Expensify/Expensify Issue URL:
Issue reported by: @Natnael-Guchima
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1695627542846449

View all open jobs on GitHub

[gadhiyamanan]

Please re-state the problem that we are trying to solve in this issue.

Wrong navigation on click of 'Invite' button

What is the root cause of that problem?

We are navigating to workspace initial page instead of invite page

What changes do you think we should make in order to solve the problem?

Change route from WORKSPACE_INITIAL to WORKSPACE_INVITE to below code



App/src/pages/workspace/WorkspaceMembersPage.js

Lines 137 to 140 in f068ef1

	const inviteUser = () => {
	setSearchValue('');
	Navigation.navigate(ROUTES.WORKSPACE_INITIAL.getRoute(props.route.params.policyID));
	};

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @cristipaval (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[Pujan92]

Seems a regression from this PR where by mistake WORKSPACE_INITIAL used instead of WORKSPACE_INVITE
https://github.com/Expensify/App/pull/28050/files#diff-bbfbd221fc2e98be145adb346139ceb43a56501e1feef799db83b51ae672421eL139
cc: @tgolen

[tgolen]

Thanks! I've opened a PR to fix this.

[cristipaval]

just opened one as well @tgolen , hahah

[chiragsalian]

I just tested on staging and it looks like this is resolved. Removing deployblocker label.

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.74-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Use correct route for workspace invite form #28197

If no regressions arise, payment will be issued on 2023-10-05. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter — payment made to @Natnael-Guchima ($50) in Upwork
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @Natnael-Guchima requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.75-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Use correct route for workspace invite form #28197

If no regressions arise, payment will be issued on 2023-10-09. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @Natnael-Guchima requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[tgolen]

@CortneyOfstad I believe this is waiting on @thesahindia getting paid for a C+ review on the PR. Could you please facilitate that?

[melvin-bot]

Unable to auto-create job on Upwork. The BZ team member should create it manually for this issue. cc @thienlnam

[melvin-bot]

Current assignee @thesahindia is eligible for the External assigner, not assigning anyone new.

[Natnael-Guchima]

I am also not paid for reporting bonus

[CortneyOfstad]

So to confirm —

@Natnael-Guchima is paid $50 for reporting bonus
@thesahindia is paid $500 as the C+ contributor — or does this qualify for a bonus @tgolen?

Thanks and once I have this confirmed, I'll manually create the job in Upwork and send out the proposal contracts 👍

[thesahindia]

@CortneyOfstad I believe this is waiting on @thesahindia getting paid for a C+ review on the PR. Could you please facilitate that?

I was assigned as the C+ but I didn't do any work. The checklist was filled by @cristipaval.

[thesahindia]

@thesahindia is paid $500 as the C+ contributor — or does this qualify for a bonus @tgolen?

@CortneyOfstad, I wasn't paid and I am not eligible for any payment here.

[CortneyOfstad]

Okay, so to confirm @tgolen — does only @Natnael-Guchima get paid for the reporting bonus?

[tgolen]

That looks correct, yes.

[CortneyOfstad]

@Natnael-Guchima Sent you a proposal in Upwork. Let me know once you accept and we can get this paid — thanks!

[Natnael-Guchima]

Accepted the offer. Thanks @CortneyOfstad

[CortneyOfstad]

Payment completed! Thanks all — closing!