[HOLD for payment 2023-10-09] [HOLD for payment 2023-10-05] Workspace - App crashes when clicking Update to USD on bank account page

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

Precondition: User has a workspace where the default currency is not USD

1. Go to staging.new.expensify.com
2. Go to Settings > Workspaces > any workspace
3. Go to Bank account
4. Click Update to USD

Expected Result:

App does not crash

Actual Result:

App crashes

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.74-1

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6213649_20230925_212128.mp4

logs.txt

Expensify/Expensify Issue URL:

Issue reported by: @bernhardoj / Applause - Internal Team

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1695629187533879

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Auto-assign attempt failed, all eligible assignees are OOO.

[namhihi237]

Proposal

Please re-state the problem that we are trying to solve in this issue.

App crashes when clicking Update to USD on the bank account page

What is the root cause of that problem?

This issue was introduced by #28050, Since we cleaned up the route.

We don't have a function getWorkspaceInitialRoute in ROUTE. So it leads to crashing the app.

App/src/pages/ReimbursementAccount/BankAccountStep.js

Line 73 in 38030f8

const bankAccountRoute = `${CONFIG.EXPENSIFY.NEW_EXPENSIFY_URL}${ROUTES.getBankAccountRoute('new', props.policyID, ROUTES.getWorkspaceInitialRoute(props.policyID))}`;

What changes do you think we should make in order to solve the problem?

We should use WORKSPACE_INITIAL instead

ROUTE.WORKSPACE_INITIAL.getRoute(props.policyID)

What alternative solutions did you explore? (Optional)

N/A

[melvin-bot]

Auto-assign attempt failed, all eligible assignees are OOO.

[melvin-bot]

Triggered auto assignment to @MariaHCD (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[Pluto0104]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Workspace - App crashes when clicking Update to USD on bank account page.

What is the root cause of that problem?

#28050 caused the regression.
This PR removes ROUTES.getWorkspaceInitialRoute and ROUTES.getBankAccountRoute function in ROUTES.ts file for organizing routes.

App/src/ROUTES.ts

Line 140 in 38030f8

WORKSPACE_INITIAL: { route: 'workspace/:policyID', getRoute: (policyID: string) => `workspace/${policyID}`},

What changes do you think we should make in order to solve the problem?

According the improvement, we need to change this as follows.

const bankAccountRoute = `${CONFIG.EXPENSIFY.NEW_EXPENSIFY_URL}${ROUTES.BANK_ACCOUNT_WITH_STEP_TO_OPEN.getRoute('new', props.policyID, ROUTES.WORKSPACE_INITIAL.getRoute(props.policyID))}`;

What alternative solutions did you explore? (Optional)

[bernhardoj]

I reported this crash in https://expensify.slack.com/archives/C049HHMV9SM/p1695629187533879 along with a proposal.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Opening the bank account page crashes the app.

What is the root cause of that problem?

In BankAccountStep, we are constructing the bank account URL like below

App/src/pages/ReimbursementAccount/BankAccountStep.js

Line 73 in f068ef1

const bankAccountRoute = `${CONFIG.EXPENSIFY.NEW_EXPENSIFY_URL}${ROUTES.getBankAccountRoute('new', props.policyID, ROUTES.getWorkspaceInitialRoute(props.policyID))}`;

However, in #28050, we are refactoring the ROUTES file, and the ROUTES functions (getBankAccountRoute & getWorkspaceInitialRoute) above do not exist anymore, so the app crashed.

What changes do you think we should make in order to solve the problem?

Replace the ROUTES usage with the new one.
Before:

-${CONFIG.EXPENSIFY.NEW_EXPENSIFY_URL}${ROUTES.getBankAccountRoute('new', props.policyID, ROUTES.getWorkspaceInitialRoute(props.policyID))}
+${CONFIG.EXPENSIFY.NEW_EXPENSIFY_URL}${ROUTES.BANK_ACCOUNT_WITH_STEP_TO_OPEN.getRoute('new', props.policyID, ROUTES.WORKSPACE_INITIAL.getRoute(props.policyID))}

[chiragsalian]

seems like the issue is addressed and QA confirmed it here. Removing deploy blocker label.

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.74-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Use correct route for workspace invite form #28197

If no regressions arise, payment will be issued on 2023-10-05. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @bernhardoj requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@tgolen] The PR that introduced the bug has been identified. Link to the PR:
• [@tgolen] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@tgolen] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@tgolen] Determine if we should create a regression test for this bug.
• [@tgolen] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.75-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Use correct route for workspace invite form #28197

If no regressions arise, payment will be issued on 2023-10-09. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @bernhardoj requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@tgolen] The PR that introduced the bug has been identified. Link to the PR:
• [@tgolen] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@tgolen] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@tgolen] Determine if we should create a regression test for this bug.
• [@tgolen] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[tgolen]

This was an internal issue caused by some large merge conflicts, so just checking those things off. There isn't really a need to do them.