[HOLD for payment 2023-10-24] [$500] iOS - Receipt replace popup camera click button is overlapping with home bar

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Create a request by scanning a receipt.
2. Go to created receipt.
3. Open the receipt details report.
4. Click on receipt image.
5. Click 3 dots menu icon and click replace.

Expected Result:

Camera click button should not overlap with native home bar.

Actual Result:

home button interfering with UI.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.73.0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-09-22.at.3.15.26.PM.1.mov

0-02-01-b4aea41189a95de407693e5e77fe91cc891f9f8064dd68ab2b3005a79f1cd93a_9057d4f9cd9846c.mp4

Expensify/Expensify Issue URL:
Issue reported by: @parasharrajat
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1695376096559109

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0191bee1b0a882677e
• Upwork Job ID: 1706314684003328000
• Last Price Increase: 2023-10-09
• Automatic offers:
• ahmedGaber93 | Contributor | 27178584

[ahmedGaber93]

Proposal

Please re-state the problem that we are trying to solve in this issue.

iOS: Receipt replace popup camera click button is overlapping with home bar

What is the root cause of that problem?

We don't include safe area padding bottom to this screen

App/src/pages/EditRequestReceiptPage.js

Lines 31 to 32 in 5aa7f6d

	<ScreenWrapper
	includeSafeAreaPaddingBottom={false}

What changes do you think we should make in order to solve the problem?

We need to include safe area padding bottom by one of:

1. surround DragAndDropProvider content with <View style={[styles.flex1, safeAreaPaddingBottomStyle]}> like money request page do here to ensure DragAndDropProvider work fine in full screen height

<ScreenWrapper
    includeSafeAreaPaddingBottom={false}
>
    {({safeAreaPaddingBottomStyle}) => (
        <>
            <HeaderWithBackButton/>
            <DragAndDropProvider>
                <View style={[styles.flex1, safeAreaPaddingBottomStyle]}>
                    <ReceiptSelector/>
                </View>
            </DragAndDropProvider>
        </>
    )}
</ScreenWrapper>

2. Alternative simply remove prop includeSafeAreaPaddingBottom={false}

What alternative solutions did you explore? (Optional)

remove prop includeSafeAreaPaddingBottom={false}

[esh-g]

Proposal

Please re-state the issue

There is no bottom safe area padding on the EditRequestReceiptPage.

What is the root cause of this issue?

We are setting the includeSafeAreaBottom={false} in the ScreenWrapper in EditRequestReceiptPage.js

App/src/pages/EditRequestReceiptPage.js

Lines 31 to 34 in 4ea4a55

	<ScreenWrapper
	includeSafeAreaPaddingBottom={false}
	shouldEnableMaxHeight
	testID={EditRequestReceiptPage.displayName}

Moreover, there is an inconsistency between the MoneyRequestSelectorPage and EditRequestReceiptPage.js where the DragAndDropProvider covers the entire page including the header in the former, while the header is excluded from the lattter page.

Screen.Recording.2023-09-24.at.11.54.44.AM-1.mov

Here in MoneyRequestSelectorPage we have included the HeaderWithBackButton in the DragAndDropProvider while also using the safeAreaPaddingBottomStyle prop provided by the ScreenWrapper.

App/src/pages/iou/MoneyRequestSelectorPage.js

Lines 86 to 91 in 4ea4a55

	>
	{({safeAreaPaddingBottomStyle}) => (
	<FullPageNotFoundView shouldShow={!IOUUtils.isValidMoneyRequestType(iouType)}>
	<DragAndDropProvider
	isDisabled={props.selectedTab !== CONST.TAB.SCAN}
	setIsDraggingOver={setIsDraggingOver}

What changes do you think should be made to fix this problem?

First we should remove the includeSafeAreaBottom={false} in EditRequsetReceiptPage.js because we want the bottom padding to be present.
Then, we should move the HeaderWithBackButton inside the DragAndDropProvider to provide consistency with the MoneyRequestSelectorPage

App/src/pages/EditRequestReceiptPage.js

Lines 36 to 41 in 4ea4a55

	<HeaderWithBackButton
	title={translate('common.receipt')}
	onBackButtonPress={Navigation.goBack}
	/>
	<DragAndDropProvider>
	<ReceiptSelector

I don't think we need to use the safeAreaPaddingBottomStyle in EditRequestReceiptPage.js because there is no FullPageNotFoundView like in `MoneyRequestSelectorPage.

What other alternative options did you explore? (Optional)

We can also change the MoneyRequestSelectorPage to mirror the behaviour of EditRequestReceiptPage by excluding the header from the DragAndDropProvider but that depends on what we prefer. Since, the EditRequestReceiptPage is newer, I am assuming it was overlooked.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0191bee1b0a882677e

[melvin-bot]

Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to @anmurali (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

[ahmedGaber93]

drag and drop not cover the header will fix here #28014

[laurenreidexpensify]

@mananjadhav do you agree? ^^

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[mananjadhav]

Agreed @laurenreidexpensify. I think we can close this one out.

[ahmedGaber93]

@laurenreidexpensify @mananjadhav
Why we will close this issue? I think it should fix.

[ahmedGaber93]

drag and drop not cover the header will fix here #28014

I am replying here to esh-g's proposal, not saying this issue will fix in other.

Sorry for not being clear.

[ahmedGaber93]

@laurenreidexpensify
It would be great if you answered me here #28145 (comment)
Thanks!

[parasharrajat]

@laurenreidexpensify @mananjadhav It seems that both issues are different and even if a single PR solved both, this is still a separate issue. Thus it should be eligible for reporting in either case. Do you agree?

[ahmedGaber93]

@laurenreidexpensify
This issue need to reopen again because it is different issue, and
#28014 is already merged, but it is not including any fix for this issue.

[melvin-bot]

@mananjadhav @laurenreidexpensify this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

📣 @parasharrajat Please request via NewDot manual requests for the Reporter role ($50)

[ahmedGaber93]

@mananjadhav PR #29617 is ready for review.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.85-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• add bottom safe area padding on the EditRequestReceiptPage. #29617

If no regressions arise, payment will be issued on 2023-10-24. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @mananjadhav does not require payment (Eligible for Manual Requests)
• @ahmedGaber93 requires payment offer (Contributor)
• @parasharrajat does not require payment (Eligible for Manual Requests)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mananjadhav] The PR that introduced the bug has been identified. Link to the PR:
• [@mananjadhav] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@mananjadhav] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@mananjadhav] Determine if we should create a regression test for this bug.
• [@mananjadhav] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@laurenreidexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[laurenreidexpensify]

Payment Summary:

• C+ @mananjadhav does not require payment in Upwork ($500 + $250) (Eligible for Manual Requests)
• Code Fix - @ahmedGaber93 payment in upwork ($500 + $250)
• Bug report - @parasharrajat does not require payment in Upwork ($50) (Eligible for Manual Requests)

[ahmedGaber93]

@laurenreidexpensify this issue is eligible for speed bonus, it merged within 1 day and 1 hour.
Assigned 2023-10-13T11:45:04Z
merged 2023-10-16T12:12:52Z
14th and 15th is a weekend.

[mananjadhav]

Agreed @laurenreidexpensify. This is eligible for the urgency bonus.

[JmillsExpensify]

$750 payment approved for @mananjadhav based on BZ summary.

[laurenreidexpensify]

@mananjadhav please complete checklist so we can close, thanks

[mananjadhav]

We added EditRequestReceiptPage in this commit in this PR.

I've added a comment here. I don't think we need a regression test for this one.

[parasharrajat]

Payment requested as per #28145 (comment)

[JmillsExpensify]

$50 approved for @parasharrajat