[HOLD for payment 2023-10-09] [$500] Profile - Save button is disabled in Display name page in offline mode #28148

lanitochka17 · 2023-09-25T14:32:17Z

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

Issue found when executing PR #27025

Action Performed:

Launch New Expensify app
Go offline
Go to Settings > Profile > Display name
Make some changes

Expected Result:

User is able to save the changes in offline mode

Actual Result:

Save button is disabled and user cannot make changes during offline

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: 1.3.74-1

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6213691_Screen_Recording_20230925_211750_New_Expensify.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0134557e3ac359277d
Upwork Job ID: 1706560446209835008
Last Price Increase: 2023-09-26
Automatic offers:

akinwale | Contributor | 26896617

melvin-bot · 2023-09-25T14:32:22Z

Triggered auto assignment to @tjferriss (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot · 2023-09-25T14:32:30Z

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

OSBotify · 2023-09-25T14:34:52Z

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

melvin-bot · 2023-09-25T14:34:54Z

Auto-assign attempt failed, all eligible assignees are OOO.

akinwale · 2023-09-25T14:47:16Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

The Save button is disabled in Display name page in offline mode

What is the root cause of that problem?

In the FormProvider component, the enabledWhenOffline prop (which is used to determine whether or not a form can be submitted when offline) is not being forwarded to the FormWrapper component.

App/src/components/Form/FormProvider.js

Lines 237 to 244 in 21b3e64

    
           <FormWrapper 
        
               {...rest} 
        
               onSubmit={submit} 
        
               inputRefs={inputRefs} 
        
               errors={errors} 
        
           > 
        
               {children} 
        
           </FormWrapper>

What changes do you think we should make in order to solve the problem?

Forward the enabledWhenOffline prop to the FormWrapper component.

<FormWrapper
    {...rest}
+   enabledWhenOffline={enabledWhenOffline}
    onSubmit={submit}
    inputRefs={inputRefs}
    errors={errors}
>

What alternative solutions did you explore? (Optional)

None.

melvin-bot · 2023-09-26T06:44:53Z

Job added to Upwork: https://www.upwork.com/jobs/~0134557e3ac359277d

melvin-bot · 2023-09-26T06:44:59Z

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

parasharrajat · 2023-09-26T06:46:29Z

Reviewin
g....

tjferriss · 2023-09-26T06:46:41Z

I'm able to reproduce this one, though I'm not sure if this qualifies as a deploy blocker.

parasharrajat · 2023-09-26T06:55:29Z

Looks like it @akinwale's proposal looks good.

🎀 👀 🎀 C+ reviewed

@akinwale Are you able to create the PR in the next few hours?

melvin-bot · 2023-09-26T06:55:36Z

Triggered auto assignment to @marcochavezf, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

parasharrajat · 2023-09-26T06:57:40Z

My bad, I forgot to tag the original PR author for the regression. @thesahindia @kowczarz looks like a regression from #27025

akinwale · 2023-09-26T07:36:47Z

Looks like it @akinwale's proposal looks good.

🎀 👀 🎀 C+ reviewed

@akinwale Are you able to create the PR in the next few hours?

@parasharrajat Yes, I'm currently available. Do I wait to be assigned or should I just create the PR?

parasharrajat · 2023-09-26T07:40:31Z

Actually, there are a couple of bugs with the main PR that caused this regression so I think we should wait for the author to reply.

melvin-bot · 2023-09-26T10:34:28Z

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

melvin-bot · 2023-09-28T18:36:23Z

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot · 2023-09-28T18:36:26Z

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.74-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

fix: save button is disabled in display name page in offline mode #28295

If no regressions arise, payment will be issued on 2023-10-05. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@akinwale requires payment offer (Contributor)
@parasharrajat does not require payment (Eligible for Manual Requests)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

melvin-bot · 2023-09-28T18:36:28Z

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@parasharrajat] The PR that introduced the bug has been identified. Link to the PR:
[@parasharrajat] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@parasharrajat] Determine if we should create a regression test for this bug.
[@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@tjferriss] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

tjferriss · 2023-09-29T07:36:07Z

Payment Summary:

External issue reporter NA Applause
Contributor that fixed the issue @akinwale $750
Contributor+ that helped on the issue and/or PR @parasharrajat $750

melvin-bot · 2023-10-02T17:18:24Z

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.75-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

fix: save button is disabled in display name page in offline mode #28295

If no regressions arise, payment will be issued on 2023-10-09. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@akinwale requires payment offer (Contributor)
@parasharrajat does not require payment (Eligible for Manual Requests)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

melvin-bot · 2023-10-02T17:18:25Z

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@parasharrajat] The PR that introduced the bug has been identified. Link to the PR:
[@parasharrajat] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@parasharrajat] Determine if we should create a regression test for this bug.
[@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@tjferriss] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

tjferriss · 2023-10-05T21:13:18Z

@parasharrajat can you get started on the checklist?

tjferriss · 2023-10-06T20:13:34Z

To clarify, payment is expected on 2023-10-09 as long as we don't see any regressions.

akinwale · 2023-10-06T23:43:58Z

To clarify, payment is expected on 2023-10-09 as long as we don't see any regressions.

This was originally deployed to production on 2023-09-28, so the payment date of 2023-10-05 is the correct one. Looks like it got mixed up in the deployment process a second time so the bot got confused.

parasharrajat · 2023-10-07T08:06:31Z

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@parasharrajat] The PR that introduced the bug has been identified. Link to the PR: Refactor form component #27025
[@parasharrajat] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/27025/files#r1349483938
[@parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: It was a simple mistake so no discussion is needed.
[@parasharrajat] Determine if we should create a regression test for this bug. No, It is already covered.
[@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
We already have regression steps for this.

tjferriss · 2023-10-09T22:10:10Z

@akinwale has been paid via Upworks. We're waiting on @parasharrajat to be paid, then we can close the issue.

akinwale · 2023-10-09T23:11:04Z

@akinwale has been paid via Upworks. We're waiting on @parasharrajat to be paid, then we can close the issue.

Received. Thanks!

parasharrajat · 2023-10-12T16:53:52Z

Payment requested as per #28148 (comment)

JmillsExpensify · 2023-10-12T22:18:40Z

$750 payment approved for @parasharrajat based on BZ summary.

lanitochka17 added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Sep 25, 2023

melvin-bot bot assigned tjferriss Sep 25, 2023

github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Sep 25, 2023

OSBotify mentioned this issue Sep 25, 2023

Deploy Checklist: New Expensify 2023-09-25 #28119

Closed

tjferriss added the External Added to denote the issue can be worked on by a contributor label Sep 26, 2023

melvin-bot bot changed the title ~~Profile - Save button is disabled in Display name page in offline mode~~ [$500] Profile - Save button is disabled in Display name page in offline mode Sep 26, 2023

melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Sep 26, 2023

melvin-bot bot assigned parasharrajat Sep 26, 2023

melvin-bot bot assigned marcochavezf Sep 26, 2023

melvin-bot bot mentioned this issue Sep 26, 2023

[HOLD for payment 2024-01-18] [HOLD for payment 2023-10-23] Refactor Form to a custom hook #25397

Closed

Pluto0104 mentioned this issue Sep 26, 2023

[HOLD for payment 2023-10-10] [$500] Profile - User is able to save display name with semicolon despite the error #28147

Closed

6 tasks

chiragsalian removed the DeployBlockerCash This issue or pull request should block deployment label Sep 28, 2023

melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Sep 28, 2023

melvin-bot bot changed the title ~~[$500] Profile - Save button is disabled in Display name page in offline mode~~ [HOLD for payment 2023-10-05] [$500] Profile - Save button is disabled in Display name page in offline mode Sep 28, 2023

melvin-bot bot removed the Reviewing Has a PR in review label Sep 28, 2023

melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Oct 2, 2023

melvin-bot bot changed the title ~~[HOLD for payment 2023-10-05] [$500] Profile - Save button is disabled in Display name page in offline mode~~ [HOLD for payment 2023-10-09] [HOLD for payment 2023-10-05] [$500] Profile - Save button is disabled in Display name page in offline mode Oct 2, 2023

melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Oct 5, 2023

tjferriss changed the title ~~[HOLD for payment 2023-10-09] [HOLD for payment 2023-10-05] [$500] Profile - Save button is disabled in Display name page in offline mode~~ [HOLD for payment 2023-10-09] [$500] Profile - Save button is disabled in Display name page in offline mode Oct 6, 2023

parasharrajat mentioned this issue Oct 7, 2023

Refactor form component #27025

Merged

59 tasks

melvin-bot bot added the Overdue label Oct 9, 2023

melvin-bot bot removed the Overdue label Oct 9, 2023

tjferriss closed this as completed Oct 11, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[HOLD for payment 2023-10-09] [$500] Profile - Save button is disabled in Display name page in offline mode #28148

[HOLD for payment 2023-10-09] [$500] Profile - Save button is disabled in Display name page in offline mode #28148

lanitochka17 commented Sep 25, 2023 •

edited by melvin-bot bot

Loading

melvin-bot bot commented Sep 25, 2023

melvin-bot bot commented Sep 25, 2023 •

edited by tjferriss

Loading

OSBotify commented Sep 25, 2023

melvin-bot bot commented Sep 25, 2023

akinwale commented Sep 25, 2023 •

edited

Loading

melvin-bot bot commented Sep 26, 2023

melvin-bot bot commented Sep 26, 2023

parasharrajat commented Sep 26, 2023 •

edited

Loading

tjferriss commented Sep 26, 2023

parasharrajat commented Sep 26, 2023

melvin-bot bot commented Sep 26, 2023

parasharrajat commented Sep 26, 2023

akinwale commented Sep 26, 2023

parasharrajat commented Sep 26, 2023

melvin-bot bot commented Sep 26, 2023

melvin-bot bot commented Sep 28, 2023

melvin-bot bot commented Sep 28, 2023 •

edited by tjferriss

Loading

melvin-bot bot commented Sep 28, 2023

tjferriss commented Sep 29, 2023

melvin-bot bot commented Oct 2, 2023

melvin-bot bot commented Oct 2, 2023

tjferriss commented Oct 5, 2023

tjferriss commented Oct 6, 2023

akinwale commented Oct 6, 2023

parasharrajat commented Oct 7, 2023 •

edited

Loading

tjferriss commented Oct 9, 2023

akinwale commented Oct 9, 2023

parasharrajat commented Oct 12, 2023

JmillsExpensify commented Oct 12, 2023

[HOLD for payment 2023-10-09] [$500] Profile - Save button is disabled in Display name page in offline mode #28148

[HOLD for payment 2023-10-09] [$500] Profile - Save button is disabled in Display name page in offline mode #28148

Comments

lanitochka17 commented Sep 25, 2023 • edited by melvin-bot bot Loading

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

melvin-bot bot commented Sep 25, 2023

melvin-bot bot commented Sep 25, 2023 • edited by tjferriss Loading

Bug0 Triage Checklist (Main S/O)

OSBotify commented Sep 25, 2023

melvin-bot bot commented Sep 25, 2023

akinwale commented Sep 25, 2023 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

melvin-bot bot commented Sep 26, 2023

melvin-bot bot commented Sep 26, 2023

parasharrajat commented Sep 26, 2023 • edited Loading

tjferriss commented Sep 26, 2023

parasharrajat commented Sep 26, 2023

melvin-bot bot commented Sep 26, 2023

parasharrajat commented Sep 26, 2023

akinwale commented Sep 26, 2023

parasharrajat commented Sep 26, 2023

melvin-bot bot commented Sep 26, 2023

melvin-bot bot commented Sep 28, 2023

melvin-bot bot commented Sep 28, 2023 • edited by tjferriss Loading

melvin-bot bot commented Sep 28, 2023

tjferriss commented Sep 29, 2023

melvin-bot bot commented Oct 2, 2023

melvin-bot bot commented Oct 2, 2023

tjferriss commented Oct 5, 2023

tjferriss commented Oct 6, 2023

akinwale commented Oct 6, 2023

parasharrajat commented Oct 7, 2023 • edited Loading

tjferriss commented Oct 9, 2023

akinwale commented Oct 9, 2023

parasharrajat commented Oct 12, 2023

JmillsExpensify commented Oct 12, 2023

lanitochka17 commented Sep 25, 2023 •

edited by melvin-bot bot

Loading

melvin-bot bot commented Sep 25, 2023 •

edited by tjferriss

Loading

akinwale commented Sep 25, 2023 •

edited

Loading

parasharrajat commented Sep 26, 2023 •

edited

Loading

melvin-bot bot commented Sep 28, 2023 •

edited by tjferriss

Loading

parasharrajat commented Oct 7, 2023 •

edited

Loading