[HOLD for payment 2023-10-30] Optimize React Context usages in New Expensify

[muttmuure]

Coming from: https://expensify.slack.com/archives/C05LX9D6E07/p1695377829998599

Problem:

Poorly implemented React Context will lead to unnecessary re-renders of Context.Consumers.

Solution:

Making sure that each time React Context is used, the value passed to Context.Provider will be properly memoized. Apart from fixing problem in existing files it would be nice to share the knowledge to developers (and reviewers) to pay attention to this problem.

Go through this list and optimize these context usages:

1. src/components/ScrollViewWithContext.js
2. src/components/AnimatedStep/AnimatedStepProvider.js
3. src/components/Attachments/AttachmentCarousel/Pager/index.js
4. src/components/DragAndDrop/Provider/index.js
5. src/components/PopoverProvider/index.js + index.native.js
6. src/components/withWindowDimensions/index.js + .native.js
7. src/pages/home/ReportScreen.js
8. src/pages/home/report/ReportActionItem.js
9. src/pages/settings/Security/TwoFactorAuth/TwoFactorAuthSteps.js

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.88-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Optimized context usages and set up eslint rule for optimization #28549

If no regressions arise, payment will be issued on 2023-10-30. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @burczu does not require payment (Contractor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

@burczu, @mountiny Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[mountiny]

all done here