[$500] iOS - Request money - Selected currency issue not consistently when navigating to iOS App from mWeb Safari Banner on iOS

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

PRECONDITION: Account A has currency setting is USD - $ (for example)

1. Log in to Account A on iOS App and mWeb iOS SAFARI
2. On mWeb SAFARI:
   • Create a Request Money and select a different currency, such as EUR - €.
   • Click the Open button located on the top banner of mWeb.
   • Observe that the user is redirected to the iOS app, and the currency is correctly set to EUR - € (which is CORRECT)
3. Back to mWeb SAFARI:
   • Click NEXT to proceed to the Select contact page (IMPORTANT step).
   • Click the Open button located on the top banner of mWeb.
   • Observe that the user is redirected to the iOS app, BUT the currency remains set as USD - $ (which is INCONSISTENT)

Expected Result:

The selected currency should be consistent across screens.

Actual Result:

The selected currency is inconsistent

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: iOS 16.4.1 Build v1.3.73-1/mWeb - Safari Build v1.3.74-0

Reproducible in staging?: Y

Reproducible in production?: Y

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

mWeb-iOS-Currency_Inconsistency.MP4

RPReplay_Final1695672759.MP4

Expensify/Expensify Issue URL:

Issue reported by: @tranvantoan-qn

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1695492131083339

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~016bfd24773e88ecee
• Upwork Job ID: 1706403856477437952
• Last Price Increase: 2023-10-02

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~016bfd24773e88ecee

[melvin-bot]

Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to @isabelastisser (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @cubuspl42 (External)

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The selected currency is not persisted when opening iOS app via deeplink while on Money request participants page in Safari

What is the root cause of that problem?

When we deeplink while on NewRequestAmountPage, we have the currency embedded in the page params, so iOS app will pick up those params and display the currencies properly.

But when deeplinking while on MoneyRequestParticipantsPage, we don't have those params in the path.

What changes do you think we should make in order to solve the problem?

We need to add selected currency to the path params of the MoneyRequestParticipantsPage, and use currency when navigating back to the NewRequestAmountPage due to lack of amount.

Currently when deeplinking to the MoneyRequestParticipantsPage in the app, we'll be navigated back to the NewRequestAmountPage because the amount is not available, if we want to fix this, we can add amount to the path params as well, and add logic to the MoneyRequestParticipantsPage to handle the currency and amount from the page params.

So as long as we navigate to the MoneyRequestParticipantsPage with the currency and amount in the path, we can open the same page in the iOS app, create a seamless experience for the user.

What alternative solutions did you explore? (Optional)

NA

[kevinksullivan]

I'll take this one off your hands @isabelastisser , since it seems we were double assigned.

[melvin-bot]

@cubuspl42, @kevinksullivan Eep! 4 days overdue now. Issues have feelings too...

[cubuspl42]

The way the expected behavior is sketched here doesn't convince me, but if we went with what @dukenv0307 suggests in their proposal (i.e. adding both the amount and the currency to the params), it would make sense.

I started a thread on Slack.

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸