[HOLD for payment 2023-10-09] [$500] Dev: Request Money - The app crashes when clicking on the currency option

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Open a chat
2. Go to the "Request money"
3. Click on the currency option

Expected Result:

The app should not crash

Actual Result:

The app crashes when clicking on the currency option.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native -requested
• Android / Chrome -requested
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: Dev
Reproducible in staging?:
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-09-27.at.12.19.03.PM.mov

Screen.Recording.2023-09-27.at.12.15.09.PM.mov

Screen.Recording.2023-09-27.at.12.13.02.PM.mov

screen-recording-2023-09-27-at-113442-am_X1UAbmMm.mp4

Expensify/Expensify Issue URL:
Issue reported by: ayazhussain79
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1695796696023189

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~011cb9c04584439771
• Upwork Job ID: 1707041619621773312
• Last Price Increase: 2023-09-27
• Automatic offers:
• situchan | Contributor | 27157044

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~011cb9c04584439771

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

[hungvu193]

It seems regression from this:
#27850

This line introduced the bugs, the currency option don't have the icons, we should have safety check there
cc @bernhardoj

[bernhardoj]

@hungvu193 yes, you're right. Thanks for the help. I have created a PR to fix it.

[mananjadhav]

I don't see any BZ member added. @bernhardoj Can you assign the original C+ here for the review? or another C+? Because I am afk right now.

[bernhardoj]

I can't assign people, so tagging @narefyev91 for visibility. I have tagged him on the PR too.

[hungvu193]

That's pretty weird that Melvin added the weekly label, I think that's why there's no BZ assignment 😂

[melvin-bot]

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[mananjadhav]

@sonialiap No payouts here as this was a regression. Also unassigning myself.

[situchan]

Please assign me here as I reviewed PR

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [] The PR that introduced the bug has been identified. Link to the PR:
• [] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [] Determine if we should create a regression test for this bug.
• [] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@sonialiap] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

📣 @situchan 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[sonialiap]

Due to this having been a regression, not making payments

#28317 (comment)

[situchan]

@sonialiap I was not involved in original issue/PR which caused this regression, so I am eligible.

[situchan]

@sonialiap I was not involved in original issue/PR which caused this regression, so I am eligible.

bump ^

[situchan]

@sonialiap I was not involved in original issue/PR which caused this regression, so I am eligible.

@sonialiap bump ^

[sonialiap]

Offer sent withdrawn in favor of Offer link. Payment made for $500

[situchan]

I already got offer here

[sonialiap]

Payment sent ✔️

[ayazhussain79]

@sonialiap could you please check am i eligible for reporting bonus?

[sonialiap]

Checking!

[sonialiap]

@ayazhussain79 Ah yes of course! Thank you for bringing it up 👍 Offer sent

Reporting $50 - paid ✔️

[ayazhussain79]

@sonialiap offer accepted, Thank you

[sonialiap]

Paid ✔️