[HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] [$500] Request money - Description briefly displayed in preview after adding a receipt from a manual request #28380

izarutskaya · 2023-09-28T09:53:50Z

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

Action Performed:

Open a chat.
Navigate to the "" option.
Enter the desired amount and click "Next"
Click on the three dots menu and select "Add receipt" and select a file
Enter a description and save it.
Now send the request.

Expected Result:

The description should either be removed from the preview or not displayed at all

Actual Result:

The description is briefly displayed in the preview when adding a receipt from a manual request

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: v1.3.74-2

Reproducible in staging?: Y

Reproducible in production?: Y

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

screen-recording-2023-09-25-at-110935-pm_hGxh7ohP.mp4

20230927_202141.mp4

Screen.Recording.2023-09-26.at.12.09.28.AM.mov

Screen.Recording.2023-09-26.at.12.05.01.AM.mov

20230926000212.mp4

Expensify/Expensify Issue URL:

Issue reported by: @ayazhussain79

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1695666475040319

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01a6766bd5a43af155
Upwork Job ID: 1707332794345508864
Last Price Increase: 2023-10-13
Automatic offers:

situchan | Contributor | 27104418
s-alves10 | Contributor | 27104428

Issue Owner

Current Issue Owner: @peterdbarkerUK

Issue Owner

Current Issue Owner: @peterdbarkerUK

melvin-bot · 2023-09-28T09:53:55Z

Triggered auto assignment to @peterdbarkerUK (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot · 2023-09-28T09:53:55Z

Job added to Upwork: https://www.upwork.com/jobs/~01a6766bd5a43af155

melvin-bot · 2023-09-28T09:53:57Z

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

melvin-bot · 2023-09-28T09:54:00Z

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ntdiary (External)

ikevin127 · 2023-09-28T12:03:40Z

Proposal

Please re-state the problem that we are trying to solve in this issue

The description is briefly displayed in the preview when adding a receipt from a manual request.

What is the root cause of that problem?

The problem comes from the ReportPreview.js component:

{!isScanning && (numberOfRequests > 1 || hasReceipts) && (
    <View style={styles.flexRow}>
        <View style={[styles.flex1, styles.flexRow, styles.alignItemsCenter]}>
            <Text style={[styles.textLabelSupporting, styles.mb1, styles.lh20]}>
                {previewSubtitle || moneyRequestComment} // <- HERE
            </Text>
        </View>
    </View>
)}

This code block is supposed to render the previewSubtitle label which can be the merchant if only one receipt requests exists or the number of requests count if more than one receipt requests exist.

The problem is the OR operator between these two variables previewSubtitle || moneyRequestComment, initially previewSubtitle is empty while the above-mentioned calculation is determined hence why the description shows up because moneyRequestComment is being shown while previewSubtitle is being determined.

This changes as soon as previewSubtitle is not empty anymore and is replaced by either the merchant if only one receipt requests exists or the number of requests count if more than one receipt requests exist.

What changes do you think we should make in order to solve the problem?

I would create another component below the existing one where we will always render the request description like so:

{!isScanning && (numberOfRequests > 1 || hasReceipts) && (
    <View style={styles.flexRow}>
        <View style={[styles.flex1, styles.flexRow, styles.alignItemsCenter]}>
            <Text style={[styles.textLabelSupporting, styles.mb1, styles.lh20]}>
                {previewSubtitle}
            </Text>
        </View>
    </View>
)}
+{moneyRequestComment && (
+   <View style={styles.flexRow}>
+       <View style={[styles.flex1, styles.flexRow, styles.alignItemsCenter]}>
+           <Text style={[styles.textLabelSupporting, styles.mb1, styles.lh20]}>
+               {moneyRequestComment}
+           </Text>
+       </View>
+   </View>
)}

What alternative solutions did you explore? (Optional)

N/A

Videos

web.mp4

s-alves10 · 2023-09-28T15:41:58Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

When adding a receipt from a manual request, description is displayed for a brief moment

What is the root cause of that problem?

App/src/components/ReportActionItem/ReportPreview.js

Lines 216 to 222 in bfda42d

    
           {!isScanning && (numberOfRequests > 1 || hasReceipts) && ( 
        
               <View style={styles.flexRow}> 
        
                   <View style={[styles.flex1, styles.flexRow, styles.alignItemsCenter]}> 
        
                       <Text style={[styles.textLabelSupporting, styles.mb1, styles.lh20]}>{previewSubtitle || moneyRequestComment}</Text> 
        
                   </View> 
        
               </View> 
        
           )}

As you can see above, we show previewSubtitle or moneyRequestComment(description).

Looking at the previewSubtitle, we show merchant info if the IOU report has only one request and it has receipt, or we show the number of money requests.

App/src/components/ReportActionItem/ReportPreview.js

Lines 126 to 131 in bfda42d

    
           const previewSubtitle = hasOnlyOneReceiptRequest 
        
               ? TransactionUtils.getMerchant(transactionsWithReceipts[0]) 
        
               : props.translate('iou.requestCount', { 
        
                     count: numberOfRequests, 
        
                     scanningReceipts: numberOfScanningReceipts, 
        
                 });

The problem is in the value of merchant. When we add a receipt, we set merchant to empty

App/src/pages/iou/ReceiptSelector/index.js

Line 120 in bfda42d

IOU.setMoneyRequestReceipt(filePath, file.name);

And when we create optimistic transaction, we also set merchant to empty

App/src/libs/TransactionUtils.js

Line 70 in bfda42d

    
           const defaultMerchant = _.isEmpty(receipt) ? CONST.TRANSACTION.DEFAULT_MERCHANT : '';

But when the API returns, it has merchant value: Request.

This inconsistency causes the description displayed for a brief moment

What changes do you think we should make in order to solve the problem?

We need to make consistent the optimistic data and API returns.

Solution 1
We can set default merchant when building optimistic transaction here because we need to make the optimistic data consistent with API returns

App/src/libs/TransactionUtils.js

Line 70 in bfda42d

    
           const defaultMerchant = _.isEmpty(receipt) ? CONST.TRANSACTION.DEFAULT_MERCHANT : '';

    const defaultMerchant = CONST.TRANSACTION.DEFAULT_MERCHANT;

Solution 2
The backend should return empty merchant when receipt request with empty merchant is sent

Result

28380.mp4

What alternative solutions did you explore? (Optional)

melvin-bot · 2023-10-03T11:23:15Z

@ntdiary, @peterdbarkerUK Eep! 4 days overdue now. Issues have feelings too...

ntdiary · 2023-10-03T17:22:35Z

Oh no, I missed this issue. I will ask on Slack if anyone has bandwidth to review this issue. 😔

situchan · 2023-10-04T03:54:18Z

Taking this over based on @ntdiary's request

melvin-bot · 2023-10-05T16:00:10Z

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

peterdbarkerUK · 2023-10-06T13:57:51Z

sorry, I missed this due to travel at the weekend. BZ team review complete.

peterdbarkerUK · 2023-10-09T12:01:50Z

@situchan - thanks for taking this on, what do you think of the current proposals?

situchan · 2023-10-09T13:19:17Z

@s-alves10's proposal looks good to me.
I think we should go with Solution 1 which fixes optimistic data as sending Merchant value in backend seems intentional.
Assigned engineer will confirm this in backend logic.
🎀 👀 🎀 C+ reviewed

melvin-bot · 2023-10-09T13:19:23Z

Triggered auto assignment to @bondydaa, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

situchan · 2023-10-09T13:20:39Z

@peterdbarkerUK can you please assign me to this issue?

melvin-bot · 2023-10-16T21:48:11Z

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.84-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

fix: default merchant for money request with receipt #29118

If no regressions arise, payment will be issued on 2023-10-23. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@situchan requires payment offer (Contributor)
@s-alves10 requires payment offer (Contributor)
@ayazhussain79 requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

melvin-bot · 2023-10-16T21:48:13Z

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@situchan] The PR that introduced the bug has been identified. Link to the PR:
[@situchan] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@situchan] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@situchan] Determine if we should create a regression test for this bug.
[@situchan] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@peterdbarkerUK] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

peterdbarkerUK · 2023-10-24T15:10:56Z

Summarizing payouts for this issue:

Issue reporter: @ayazhussain79 $50 (offer sent)

Contributor: @s-alves10 $750 (inc urgency bonus)

Contributor+: @situchan $750 (inc urgency bonus) - please complete the BZ checklist and notify me here so that I can complete the payout.

Upwork Job

melvin-bot · 2023-10-30T12:52:17Z

@bondydaa, @peterdbarkerUK, @situchan, @s-alves10 Huh... This is 4 days overdue. Who can take care of this?

peterdbarkerUK · 2023-10-30T14:26:16Z

@situchan could you complete the checklist?

peterdbarkerUK · 2023-10-31T15:12:14Z

(Just a note for myself that ohter contribs have been paid, and contract closed)

situchan · 2023-10-31T15:46:30Z

The PR that introduced the bug has been identified. Link to the PR: Default to empty merchant for receipt requests #25924
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/25924/files#r1377800775
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
Determine if we should create a regression test for this bug.
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

Go to FAB > Request money > select Manual
Input any amount and click Next
Click on the three dots menu and select "Add receipt" and select a file
Enter a description and save
Tap "Request"
Verify that description is not shown and "Request" is shown in preview

situchan · 2023-10-31T15:48:23Z

@peterdbarkerUK sorry for late. Can you also help with payment on #27710 please?

ayazhussain79 · 2023-10-31T18:04:57Z

@peterdbarkerUK can you please check you have ended contract on upwork without paying

peterdbarkerUK · 2023-11-02T14:47:44Z

Ah shoot, my mistake @ayazhussain79 - I'd had to add you to the job and didn't correctly pay it out when closing. I'm sorry.

I've sent you a new contract offer, bump me here once you've accepted it!

ayazhussain79 · 2023-11-02T15:20:11Z

@peterdbarkerUK Np, Offer accepted and thank you

peterdbarkerUK · 2023-11-02T15:25:57Z

Paid, thanks Ayaz!

peterdbarkerUK · 2023-11-02T15:34:29Z

@situchan I've updated the original issue, thanks for raising it and I'm sorry for the error.

situchan · 2023-11-02T15:36:10Z

@situchan I've updated the original issue, thanks for raising it and I'm sorry for the error.

No problem. Thanks

Also payment for this one (#28380) is pending

peterdbarkerUK · 2023-11-02T15:55:32Z

Haha one at a time! I'm working through these but being interrupted by an ongoing interview ;-)

peterdbarkerUK · 2023-11-02T16:05:49Z

Paid! Leaving open so I can sort out the regression testing tomorrow.

peterdbarkerUK · 2023-11-06T12:01:05Z

QA Update proposal is up, thanks everyone for the fine work!

izarutskaya added External Added to denote the issue can be worked on by a contributor Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Sep 28, 2023

melvin-bot bot assigned peterdbarkerUK Sep 28, 2023

melvin-bot bot changed the title ~~Request money - Description briefly displayed in preview after adding a receipt from a manual request~~ [$500] Request money - Description briefly displayed in preview after adding a receipt from a manual request Sep 28, 2023

melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Sep 28, 2023

melvin-bot bot assigned ntdiary Sep 28, 2023

melvin-bot bot added the Overdue label Oct 2, 2023

melvin-bot bot removed the Overdue label Oct 3, 2023

melvin-bot bot added the Overdue label Oct 6, 2023

melvin-bot bot added Overdue and removed Overdue labels Oct 6, 2023

melvin-bot bot removed the Overdue label Oct 9, 2023

melvin-bot bot assigned bondydaa Oct 9, 2023

bondydaa assigned situchan Oct 9, 2023

melvin-bot bot added the Weekly KSv2 label Oct 16, 2023

melvin-bot bot added Daily KSv2 and removed Weekly KSv2 Daily KSv2 labels Oct 23, 2023

melvin-bot bot added the Overdue label Oct 26, 2023

melvin-bot bot removed the Overdue label Oct 31, 2023

situchan mentioned this issue Oct 31, 2023

Default to empty merchant for receipt requests #25924

Merged

58 tasks

melvin-bot bot added the Overdue label Nov 6, 2023

peterdbarkerUK closed this as completed Nov 6, 2023

melvin-bot bot removed the Overdue label Nov 6, 2023

bernhardoj mentioned this issue Dec 6, 2023

[Hold #31411] [$500] Scan - None not displayed in merchant while offline & after adding amount & going online #32552

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] [$500] Request money - Description briefly displayed in preview after adding a receipt from a manual request #28380

[HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] [$500] Request money - Description briefly displayed in preview after adding a receipt from a manual request #28380

izarutskaya commented Sep 28, 2023 •

edited by peterdbarkerUK

Loading

melvin-bot bot commented Sep 28, 2023

melvin-bot bot commented Sep 28, 2023

melvin-bot bot commented Sep 28, 2023 •

edited by peterdbarkerUK

Loading

melvin-bot bot commented Sep 28, 2023

ikevin127 commented Sep 28, 2023 •

edited

Loading

s-alves10 commented Sep 28, 2023

melvin-bot bot commented Oct 3, 2023

ntdiary commented Oct 3, 2023

situchan commented Oct 4, 2023

melvin-bot bot commented Oct 5, 2023

peterdbarkerUK commented Oct 6, 2023

peterdbarkerUK commented Oct 9, 2023 •

edited

Loading

situchan commented Oct 9, 2023

melvin-bot bot commented Oct 9, 2023

situchan commented Oct 9, 2023

melvin-bot bot commented Oct 16, 2023 •

edited by peterdbarkerUK

Loading

melvin-bot bot commented Oct 16, 2023 •

edited by peterdbarkerUK

Loading

peterdbarkerUK commented Oct 24, 2023

melvin-bot bot commented Oct 30, 2023

peterdbarkerUK commented Oct 30, 2023

peterdbarkerUK commented Oct 31, 2023

situchan commented Oct 31, 2023

situchan commented Oct 31, 2023

ayazhussain79 commented Oct 31, 2023

peterdbarkerUK commented Nov 2, 2023 •

edited

Loading

ayazhussain79 commented Nov 2, 2023

peterdbarkerUK commented Nov 2, 2023

peterdbarkerUK commented Nov 2, 2023

situchan commented Nov 2, 2023

peterdbarkerUK commented Nov 2, 2023

peterdbarkerUK commented Nov 2, 2023

peterdbarkerUK commented Nov 6, 2023

[HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] [$500] Request money - Description briefly displayed in preview after adding a receipt from a manual request #28380

[HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] [$500] Request money - Description briefly displayed in preview after adding a receipt from a manual request #28380

Comments

izarutskaya commented Sep 28, 2023 • edited by peterdbarkerUK Loading

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

melvin-bot bot commented Sep 28, 2023

melvin-bot bot commented Sep 28, 2023

melvin-bot bot commented Sep 28, 2023 • edited by peterdbarkerUK Loading

Bug0 Triage Checklist (Main S/O)

melvin-bot bot commented Sep 28, 2023

ikevin127 commented Sep 28, 2023 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Videos

s-alves10 commented Sep 28, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

melvin-bot bot commented Oct 3, 2023

ntdiary commented Oct 3, 2023

situchan commented Oct 4, 2023

melvin-bot bot commented Oct 5, 2023

peterdbarkerUK commented Oct 6, 2023

peterdbarkerUK commented Oct 9, 2023 • edited Loading

situchan commented Oct 9, 2023

melvin-bot bot commented Oct 9, 2023

situchan commented Oct 9, 2023

melvin-bot bot commented Oct 16, 2023 • edited by peterdbarkerUK Loading

melvin-bot bot commented Oct 16, 2023 • edited by peterdbarkerUK Loading

peterdbarkerUK commented Oct 24, 2023

melvin-bot bot commented Oct 30, 2023

peterdbarkerUK commented Oct 30, 2023

peterdbarkerUK commented Oct 31, 2023

situchan commented Oct 31, 2023

Regression Test Proposal

situchan commented Oct 31, 2023

ayazhussain79 commented Oct 31, 2023

peterdbarkerUK commented Nov 2, 2023 • edited Loading

ayazhussain79 commented Nov 2, 2023

peterdbarkerUK commented Nov 2, 2023

peterdbarkerUK commented Nov 2, 2023

situchan commented Nov 2, 2023

peterdbarkerUK commented Nov 2, 2023

peterdbarkerUK commented Nov 2, 2023

peterdbarkerUK commented Nov 6, 2023

izarutskaya commented Sep 28, 2023 •

edited by peterdbarkerUK

Loading

melvin-bot bot commented Sep 28, 2023 •

edited by peterdbarkerUK

Loading

ikevin127 commented Sep 28, 2023 •

edited

Loading

peterdbarkerUK commented Oct 9, 2023 •

edited

Loading

melvin-bot bot commented Oct 16, 2023 •

edited by peterdbarkerUK

Loading

melvin-bot bot commented Oct 16, 2023 •

edited by peterdbarkerUK

Loading

peterdbarkerUK commented Nov 2, 2023 •

edited

Loading