#23546 - Wrong Image opens on HT Report in Safari #28441

mikesmnx · 2023-09-29T07:12:34Z

Details

Wrong Image opens on HT Report in Safari

Fixed Issues

$ #23546
PROPOSAL: #23546 (comment)

Tests

Join #announce channel.
Scroll up and open shared images by users.
After scrolling a little up again open some other image.
Correct image is displayed.

Verify that no errors appear in the JS console

Offline tests

Open #announce channel.
Scroll up and open shared images by users.
After scrolling a little up again open some other image.
Correct image is displayed.
Turn off network connection.
Repeat steps 3-4.

QA Steps

Join #announce channel (or any other channel with existing shared images).
Scroll up and open shared images by users.
After scrolling a little up again open some other image.
Correct image is displayed.

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
  - Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

chrome.mp4

Mobile Web - Chrome

android-chrome.mp4

Mobile Web - Safari

ios-safari.MP4

Desktop

macos-desk.mp4

iOS

ios-app-emu.mp4

Android

android-native.mp4

github-actions · 2023-09-29T07:12:48Z

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

melvin-bot · 2023-09-29T07:13:09Z

@nkuoch Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

nkuoch · 2023-09-29T07:43:13Z

src/components/Attachments/AttachmentCarousel/index.js

@@ -189,7 +190,7 @@ function AttachmentCarousel({report, reportActions, source, onNavigate, setDownl
                            bounces={false}
                            // Scroll only one image at a time no matter how fast the user swipes
                            disableIntervalMomentum
-                            pagingEnabled
+                            pagingEnabled={false}


can't you just remove it?

@nkuoch done

mikesmnx · 2023-09-29T08:04:03Z

I have read the CLA Document and I hereby sign the CLA

parasharrajat · 2023-09-29T11:20:51Z

Please add space between the issue links required for automation and checks.

parasharrajat · 2023-09-29T11:22:05Z

You suggested a couple of props to be changed on the proposal #23546 (comment) but I only see a few on the changes. Can you please explain the reason behind this?

mikesmnx · 2023-09-29T11:32:24Z

@parasharrajat During testing across all platforms, I discovered that certain properties, such as "bounces" or "maxToRenderPerBatch," slightly altered the current UX. So, I made only the necessary adjustments to maintain the app's existing state.

nkuoch · 2023-09-30T15:56:19Z

mikesmnx · 2023-09-30T18:51:59Z

recheck

mikesmnx · 2023-10-01T12:15:32Z

@nkuoch Sorry, Nathalie, I'm a bit confused. I've already signed the CLA and received confirmation of it. I tried to add a "recheck" comment here. I also verified that this step exists in the workflow (https://github.com/Expensify/App/actions/runs/6348672890/workflow?pr=28441), but it seems the check hasn't been retriggered.

nkuoch · 2023-10-03T07:06:10Z

All good now. @parasharrajat do you mind doing the reviewer checklist?

parasharrajat · 2023-10-05T14:05:32Z

Checking it now...

parasharrajat · 2023-10-09T13:19:39Z

Screenshots

🔲 iOS / native

🔲 iOS / Safari

🔲 MacOS / Desktop

Screen.Recording.2023-10-09.at.7.42.41.PM.mov

🔲 MacOS / Chrome

Screen.Recording.2023-10-09.at.7.38.08.PM.mov

🔲 Android / Chrome

🔲 Android / native

parasharrajat · 2023-10-09T14:33:32Z

@mikesmnx I found an issue. Notice the image does not snap to the edge.

Screen.Recording.2023-10-09.at.8.02.37.PM.mov

mikesmnx · 2023-10-09T14:59:27Z

@parasharrajat Checking

parasharrajat · 2023-10-11T18:42:20Z

@mikesmnx Any update?

mikesmnx · 2023-10-11T18:48:09Z

@parasharrajat I've found another approach to fix the issue and am currently verifying it across all platforms. I believe it will be ready by tomorrow

parasharrajat · 2023-10-11T18:51:17Z

Thanks for the update.

mikesmnx · 2023-10-12T21:08:34Z

@parasharrajat Updated the code and chose to retain pagingEnabled. Without it, we would have to implement paging manually, which would result in varied behaviors across supported platforms. I've tested this on the iPhone 11, 13 Pro Max, 14 Pro Max (emulator), Mac desktop app, iOS native app, and also on an Android 13 device, it's working as expected.

parasharrajat · 2023-10-13T06:33:21Z

Thanks @mikesmnx. Can you please summarize the effect of these changes?

mikesmnx · 2023-10-13T10:43:17Z

@parasharrajat I've added contentInset and contentInsetAdjustmentBehavior to achieve more stable behavior (iOS only). Since we don't have any padding, the top, left, bottom, and right are all set to zero (contentInset). The contentInsetAdjustmentBehavior is set to 'automatic' to ensure that content fits within the scroll area.

I've switched from snapToInterval to snapToOffsets because the latter is more stable with large lists.

I adjusted the windowSize (number of rendered items outside visible area) to 1, which has improved memory usage and the selection of the first item.

I also removed maxToRenderPerBatch, as it tends to be unstable with large lists.

parasharrajat · 2023-10-23T06:06:39Z

@mikesmnx Can you please merge the main? I will test it afterward.

mikesmnx · 2023-10-23T07:54:02Z

@parasharrajat Done

parasharrajat · 2023-11-02T12:03:46Z

@nkuoch Can you please run the workflows here?

nkuoch · 2023-11-02T16:07:04Z

done

parasharrajat · 2023-11-07T19:39:22Z

Screenshots

🔲 iOS / native

🔲 iOS / Safari

🔲 MacOS / Desktop

🔲 MacOS / Chrome

🔲 Android / Chrome

🔲 Android / native

parasharrajat · 2023-11-15T14:37:05Z

I have tried a few times but I couldn't reproduce the issue so I am not able to verify the solution.

I will try to get a heavy account and try on that.

mikesmnx · 2023-11-17T16:30:05Z

Hope this helps. I just followed the first three steps from the issue with the iPhone (latest iOS/Safari).

video5384103322170964912.mp4

parasharrajat · 2023-11-22T18:40:35Z

Sorry for the delay here. I am AFK till weekend. I will get this wrapped up on Monday.

parasharrajat · 2023-12-08T16:12:34Z

I still couldn't. @mikesmnx Can you please merge the main? I am asking someone for help.

mikesmnx · 2023-12-08T16:53:13Z

@parasharrajat done

parasharrajat · 2023-12-08T17:20:38Z

Thanks.

parasharrajat · 2023-12-08T17:29:04Z

src/components/Attachments/AttachmentCarousel/index.js

                            // Enable scrolling by swiping on mobile (touch) devices only
                            // disable scroll for desktop/browsers because they add their scrollbars
                            // Enable scrolling FlatList only when PDF is not in a zoomed state
                            scrollEnabled={canUseTouchScreen}
                            ref={scrollRef}
                            initialScrollIndex={page}
-                            initialNumToRender={3}
-                            windowSize={5}
-                            maxToRenderPerBatch={CONST.MAX_TO_RENDER_PER_BATCH.CAROUSEL}


why did we remove this?

Recently, the 'maxToRenderPerBatch' was set to use a constant, but we have removed it in this PR

parasharrajat · 2023-12-08T17:30:26Z

src/components/Attachments/AttachmentCarousel/index.js

@@ -195,16 +196,17 @@ function AttachmentCarousel({report, reportActions, parentReportActions, source,
                            disableIntervalMomentum
                            pagingEnabled
                            snapToAlignment="start"
-                            snapToInterval={containerWidth}
+                            contentInset={{top: 0, left: 0, bottom: 0, right: 0}}
+                            contentInsetAdjustmentBehavior="automatic"


Why do we need this? Can you please explain the issue it solves?

Please check my comment here

parasharrajat · 2023-12-08T17:31:13Z

src/components/Attachments/AttachmentCarousel/index.js

@@ -195,16 +196,17 @@ function AttachmentCarousel({report, reportActions, parentReportActions, source,
                            disableIntervalMomentum
                            pagingEnabled
                            snapToAlignment="start"
-                            snapToInterval={containerWidth}
+                            contentInset={{top: 0, left: 0, bottom: 0, right: 0}}


This seems to be default value. Any reason for adding this?

As I recall from my tests on platforms, such as macOS desktop and iOS native, I found that without explicitly setting this value (despite it being the default), the view appeared slightly different (with a 1-2px padding)

Let's add that as a comment.

parasharrajat · 2023-12-11T12:22:24Z

Bug: This is what happening on iOS Safari for me.

Screen.Recording.2023-12-11.at.5.49.32.PM.mov

parasharrajat · 2023-12-11T12:29:46Z

There is a warning on Android.

tewst.mov

parasharrajat · 2023-12-14T09:28:24Z

@mikesmnx bump.

mikesmnx · 2023-12-14T10:59:18Z

@parasharrajat I'm not sure I understood correctly. Should I resolve the warning on Android?

parasharrajat · 2023-12-14T17:40:05Z

Yes, I noticed that warning on this branch. If this warning is present on main then you don't have to solve it. Also, there is an issue with Safari.

parasharrajat · 2023-12-22T16:41:46Z

@mikesmnx Did you get the time to check the warning and issue of Safari?

mikesmnx · 2024-01-02T15:55:34Z

@parasharrajat Apologies for the delay—I was on holiday. I will update the pull request by Wednesday or Thursday

parasharrajat · 2024-06-06T15:23:28Z

Let's close this PR @mikesmnx

mikesmnx · 2024-06-06T15:53:47Z

@parasharrajat done

Expensify#23546 - Wrong Image opens on HT Report in Safari

35ae16a

mikesmnx requested a review from a team as a code owner September 29, 2023 07:12

melvin-bot bot requested review from nkuoch and removed request for a team September 29, 2023 07:13

mikesmnx mentioned this pull request Sep 29, 2023

[HOLD for payment 2024-06-06] [$2000] Wrong Image opens on HT Report in Safari #23546

Closed

6 tasks

nkuoch reviewed Sep 29, 2023

View reviewed changes

pagingEnabled removed

3d4faa6

nkuoch requested a review from parasharrajat October 2, 2023 08:02

Updated approach

d1bf919

Merge remote-tracking branch 'upstream/main' into mikesmnx-issue-23546

afcac5d

mikesmnx added 2 commits November 2, 2023 16:12

Fixed lint error

d10f9fd

Prettier fix

6f41ef5

Merge remote-tracking branch 'upstream/main' into mikesmnx-issue-23546

60ac519

parasharrajat reviewed Dec 8, 2023

View reviewed changes

Added comment on contentInset

5a19e1f

mikesmnx closed this Jun 6, 2024

#23546 - Wrong Image opens on HT Report in Safari #28441

#23546 - Wrong Image opens on HT Report in Safari #28441

Conversation

mikesmnx commented Sep 29, 2023 • edited by github-actions bot Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

github-actions bot commented Sep 29, 2023 • edited Loading

melvin-bot bot commented Sep 29, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mikesmnx commented Sep 29, 2023

parasharrajat commented Sep 29, 2023

parasharrajat commented Sep 29, 2023 • edited Loading

mikesmnx commented Sep 29, 2023

nkuoch commented Sep 30, 2023

mikesmnx commented Sep 30, 2023

mikesmnx commented Oct 1, 2023

nkuoch commented Oct 3, 2023

parasharrajat commented Oct 5, 2023

parasharrajat commented Oct 9, 2023 • edited Loading

Screenshots

🔲 iOS / native

🔲 iOS / Safari

🔲 MacOS / Desktop

🔲 MacOS / Chrome

🔲 Android / Chrome

🔲 Android / native

parasharrajat commented Oct 9, 2023

mikesmnx commented Oct 9, 2023

parasharrajat commented Oct 11, 2023

mikesmnx commented Oct 11, 2023

parasharrajat commented Oct 11, 2023

mikesmnx commented Oct 12, 2023

parasharrajat commented Oct 13, 2023 • edited Loading

mikesmnx commented Oct 13, 2023

parasharrajat commented Oct 23, 2023

mikesmnx commented Oct 23, 2023

parasharrajat commented Nov 2, 2023

nkuoch commented Nov 2, 2023

parasharrajat commented Nov 7, 2023

Screenshots

🔲 iOS / native

🔲 iOS / Safari

🔲 MacOS / Desktop

🔲 MacOS / Chrome

🔲 Android / Chrome

🔲 Android / native

parasharrajat commented Nov 15, 2023

mikesmnx commented Nov 17, 2023

parasharrajat commented Nov 22, 2023

parasharrajat commented Dec 8, 2023

mikesmnx commented Dec 8, 2023

parasharrajat commented Dec 8, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

parasharrajat commented Dec 11, 2023

parasharrajat commented Dec 11, 2023

parasharrajat commented Dec 14, 2023

mikesmnx commented Dec 14, 2023

parasharrajat commented Dec 14, 2023 • edited Loading

parasharrajat commented Dec 22, 2023

mikesmnx commented Jan 2, 2024

parasharrajat commented Jun 6, 2024

mikesmnx commented Jun 6, 2024

mikesmnx commented Sep 29, 2023 •

edited by github-actions bot

Loading

github-actions bot commented Sep 29, 2023 •

edited

Loading

parasharrajat commented Sep 29, 2023 •

edited

Loading

parasharrajat commented Oct 9, 2023 •

edited

Loading

parasharrajat commented Oct 13, 2023 •

edited

Loading

parasharrajat commented Dec 14, 2023 •

edited

Loading