Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hold - Split on scanned receipts] Don't show merchant and date greyed out on split confirmation page #28452

Closed
trjExpensify opened this issue Sep 29, 2023 · 11 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Internal Requires API changes or must be handled by Expensify staff Weekly KSv2

Comments

@trjExpensify
Copy link
Contributor

trjExpensify commented Sep 29, 2023

👋 @youssef-lr adding this quick clean up issue for the split confirmation screen I noticed.

  1. Fields that aren't editable shouldn't be greyed out, the rows just don't have a right caret to be able to edit them
  2. That said, we should allow someone to set the merchant and date on the split confirmation page ahead of creating a split
  3. Like we do when they set a description, the merchant and date set should also be carried over onto the child requests that get created from the split
image

CC: @mountiny @JmillsExpensify

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0182c0d2b618fb678a
  • Upwork Job ID: 1707688960169914368
  • Last Price Increase: 2023-09-29
@trjExpensify trjExpensify added Engineering Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Sep 29, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 29, 2023

Current assignee @trjExpensify is eligible for the Bug assigner, not assigning anyone new.

@melvin-bot
Copy link

melvin-bot bot commented Sep 29, 2023

Current assignee @youssef-lr is eligible for the Engineering assigner, not assigning anyone new.

@melvin-bot
Copy link

melvin-bot bot commented Sep 29, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@youssef-lr
Copy link
Contributor

I've had this one in my mind and I've already implemented in my draft code!

Screenshot 2023-09-29 at 17 21 20

@youssef-lr youssef-lr added the Internal Requires API changes or must be handled by Expensify staff label Sep 29, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 29, 2023

Job added to Upwork: https://www.upwork.com/jobs/~0182c0d2b618fb678a

@melvin-bot
Copy link

melvin-bot bot commented Sep 29, 2023

Triggered auto assignment to Contributor Plus for review of internal employee PR - @jjcoffee (Internal)

@trjExpensify
Copy link
Contributor Author

Perfect!

@melvin-bot melvin-bot bot added the Overdue label Oct 2, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 2, 2023

@youssef-lr, @trjExpensify, @jjcoffee Whoops! This issue is 2 days overdue. Let's get this updated quick!

@trjExpensify
Copy link
Contributor Author

I'm going to drop this to weekly and we can retest once split on scanned is out.

@melvin-bot melvin-bot bot removed the Overdue label Oct 2, 2023
@trjExpensify trjExpensify added Weekly KSv2 and removed Daily KSv2 labels Oct 2, 2023
@trjExpensify trjExpensify changed the title Don't show merchant and date greyed out on split confirmation page [Hold - Split on scanned receipts] Don't show merchant and date greyed out on split confirmation page Oct 2, 2023
@melvin-bot melvin-bot bot added the Overdue label Oct 10, 2023
@trjExpensify
Copy link
Contributor Author

Almost there on the PRs to retest this! :)

@melvin-bot melvin-bot bot removed the Overdue label Oct 10, 2023
@melvin-bot melvin-bot bot added the Overdue label Oct 19, 2023
@trjExpensify
Copy link
Contributor Author

This is fixed. Closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Internal Requires API changes or must be handled by Expensify staff Weekly KSv2
Projects
None yet
Development

No branches or pull requests

3 participants