Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web - Wallet Statement Modal - Statement is not displayed and errors appear #28490

Closed
1 of 6 tasks
lanitochka17 opened this issue Sep 29, 2023 · 11 comments
Closed
1 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Internal Requires API changes or must be handled by Expensify staff

Comments

@lanitochka17
Copy link

lanitochka17 commented Sep 29, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Issue found when executing PR #27934

Action Performed:

  1. Login to staging.new.expensify.com
  2. Go to staging.new.expensify.com/statements/202308
  3. Check the modal and console in local environment

Expected Result:

There should be no error in the console in local environment

Actual Result:

"Refused to connect" message is displayed and error in the console in local environment shows up

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • Windows / Chrome
  • MacOS / Desktop

Version Number: 1.3.75-0

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6219063_1695993762752.Recording__1121.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01e92423cfeff9e754
  • Upwork Job ID: 1708417503606587392
  • Last Price Increase: 2023-10-01
@lanitochka17 lanitochka17 added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Sep 29, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 29, 2023

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Sep 29, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot
Copy link

melvin-bot bot commented Sep 29, 2023

Triggered auto assignment to @AndrewGable (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@lanitochka17
Copy link
Author

Issue is still repro it on latest build v1.3.75-3 on Windows 10/Chrome

restest1.mp4

retest

@mountiny mountiny added Daily KSv2 Internal Requires API changes or must be handled by Expensify staff and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Oct 1, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 1, 2023

Job added to Upwork: https://www.upwork.com/jobs/~01e92423cfeff9e754

@melvin-bot
Copy link

melvin-bot bot commented Oct 1, 2023

Triggered auto assignment to Contributor Plus for review of internal employee PR - @eVoloshchak (Internal)

@mountiny
Copy link
Contributor

mountiny commented Oct 1, 2023

Coming from this Slack convo https://expensify.slack.com/archives/C02NK2DQWUX/p1696148431657419 it seems like this is not coming from the App but more so from internal changes but the statement should work fine in production so going to remove the deploy blocker label

@hayata-suenaga
Copy link
Contributor

hayata-suenaga commented Oct 1, 2023

On production, the wallet statement page is displayed without any issue

On the other note, links in the iframe seem not be working:

Screen.Recording.2023-09-29.at.2.32.11.PM.mov

@hayata-suenaga
Copy link
Contributor

hayata-suenaga commented Oct 1, 2023

@AndrewGable @mountiny
This is my suggestion

Root cause

  • NewDot embeds an OldDot page (wallet statement page) inside an iframe of NewDot.
  • Both production and staging NewDots embed production OldDot.
  • This means that when on staging, staging.new.expensify.com embeds www.expensify.com.
  • These websites are considered as separate websites by the browser.
  • Because current production OldDot CSP header doesn't explicitly list staging.new.expensify.com under frame-ancestors, the browser denies to display production OldDot inside the staging NewDot.

Solution

  • Let's embed the staging OldDot when NewDot is the staging one.
  • Let's modify the CSP of staging OldDot so that the staging NewDot can embed it. (this one will be handled here anyway)

@mountiny
Copy link
Contributor

mountiny commented Oct 2, 2023

@hayata-suenaga I have confirmed with the QA they normally dont test this so its not a new issue. I think that this will eventually be handled by the changes required for the hybrid web so I think we dont have to do anything specific here and changes made for the hybrid web will fix this too.

Hence I think we can close this issue, feel free to reopen if you disgree

@mountiny mountiny closed this as completed Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Internal Requires API changes or must be handled by Expensify staff
Projects
None yet
Development

No branches or pull requests

7 participants