[$1000] Desktop-"Hmm.. it's not here" page appears when the app auto closes to update

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. App is backgrounded
2. App auto closes to update

Expected Result:

1. App to reopen to the last chat that was open (which I don't think is what we're doing now)
2. If not the # 1 happening, app opens to a report that is accessible.

Actual Result:

App opens to the "Hmm... it's not here" page. Also there is o reportID for the error screen

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.74-2
Reproducible in staging?: needs reproduction
Reproducible in production?: needs reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:
Issue reported by: @mallenexpensify
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1695712867448569

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0135298da9abe1170c
• Upwork Job ID: 1712596316625391616
• Last Price Increase: 2023-11-28
• Automatic offers:
• tienifr | Contributor | 27866693

[melvin-bot]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[mallenexpensify]

I think this might be part of a multi-part issue/bug?

1. This examples opens to nothing, a non-existent report
2. The app opens to random reports that exist. I had it happen the past week where the app opened to a weird test report with no comments - https://staging.new.expensify.com/r/92476783

[melvin-bot]

@kadiealexander Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[kadiealexander]

I'm ooo, reassigning so this isn't blocked on me!

[melvin-bot]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

@anmurali Eep! 4 days overdue now. Issues have feelings too...

[anmurali]

I can't reproduce. It opens to the home page

[mallenexpensify]

Happened to me again today on desktop, reopening. When I pull up the reportID it shows 'app://-/not-found' .
Would it be helpful to look into my backend(?) logs to see if anything shows up?

The only error I see in the console is

[puneetlath]

It happens to me too. Let's make it External.

[tienifr]

I tried customizing the app://-/ scheme but it caused CORS. Seems like the scheme has been registered in the BE. Also it might be Electron's default scheme, there's no official documentation about this but several users already had it (here, here). And even if we can customize it, it's quite a lot of work. Anw, I think the safe path to go here is just to add the scheme to the prefix whitelist.

[eVoloshchak]

I think we should proceed with @tienifr's proposal
I'm unable to trigger an update for Desktop app, but, #31592 can be reproduced reliably in production

The same thing happens on Android mWeb if we use 127.0.0.1 domain.

Let's fix this on Android mWeb too, this affects every developer that is using 127.0.0.1

🎀👀🎀 C+ reviewed!

[melvin-bot]

Triggered auto assignment to @johnmlee101, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[situchan]

Still curious why this didn't happen before. Even 127.0.0.1 used to work for a while without whitelisting.

[shubham1206agra]

Still curious why this didn't happen before. Even 127.0.0.1 used to work for a while without whitelisting.

Yeah, I have been able to use it before without any problems.

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

📣 @eVoloshchak Please request via NewDot manual requests for the Reviewer role ($1000)

[melvin-bot]

📣 @tienifr 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[tienifr]

PR ready for review #32158.

[mallenexpensify]

@eVoloshchak please review the PR today or post in #contributor-plus to find someone to take over, thx.

[eVoloshchak]

Will review this today, apologies for the delay

[eVoloshchak]

Not sure why the automation failed (don't see any problems with the PR, the issue is linked properly). This was deployed to production on Dec 14, so payment date is Dec 21. Posting the BZ checklist manually

• The PR that introduced the bug has been identified. Link to the PR: there isn't a PR that has caused this, this is the initial implementation
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: I don't think an additional discussion is needed, this is very specific bug, a general solution isn't needed

[eVoloshchak]

Regression Test Proposal

MacOS Desktop only

1. Open the app
2. Reload app (CMD+R or View >> Reload)
3. Verify the app doesn't show Not found page

Do we agree 👍 or 👎

[mallenexpensify]

Contributor: @tienifr paid $1000 via Upwork
Contributor+: @eVoloshchak owed $1000 via NewDot

I don't think we need a regression test for this since the bug at startup would be the error page, which is the first thing after signup (so there's no need for an additional test to find it)

Thanks @tienifr and @eVoloshchak I particularly hated this 🐛

[JmillsExpensify]

$1,000 payment approved for @eVoloshchak based on summary above.