[HOLD for payment 2023-10-12] [$500] Request Money - The gap between error message and 'Next' button is much larger for Request Money's Manual Page

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Login to ND
2. Click on FAB > Request Money > Manual tab
3. Enter '0' if not already there in the amount
4. Click on Next

Expected Result:

The gap between the error messages is consistent, just like on other pages, such as Home Address, Legal Name, Date of Birth, etc

Actual Result:

The gap is much larger than the gap between error message and CTA button on any other page.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.75.2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Recording.4803.mp4

Expensify/Expensify Issue URL:
Issue reported by: @aman-atg
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1695942566946709

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01c93d7659514ccde7
• Upwork Job ID: 1707802938882224128
• Last Price Increase: 2023-09-29
• Automatic offers:
• aman-atg | Contributor | 26975517
• aman-atg | Reporter | 26975520

[melvin-bot]

Triggered auto assignment to @flaviadefaria (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01c93d7659514ccde7

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)

[kbecciv]

Proposal by: @aman-atg
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1695942566946709

Proposal

Please re-state the problem that we are trying to solve in this issue.

The gap between error message and 'Next' button is much larger for Request Money's Manual Page

What is the root cause of that problem?

We are using styles.mt5 here which works for platforms where BigNumberPad component is visible but for other platforms this much gap is unnecessary. And FormHelpMessage itself has marginBottom values which further increases the gap between the error message and the button.

What changes do you think we should make in order to solve the problem?

We can define a variable like canUseTouchScreen and use it to determine which value to use for the top margin.

Example:

 
                {canUseTouchScreen ? (
                    <BigNumberPad
                      // ...other props
                    />
                ) : null}
                <Button
                    // ...other props
                    style={[styles.w100, canUseTouchScreen ? styles.mt5 : styles.mt2]}
                />

Here, I've used styles.mt2 but we can use any other value as well as per design team's suggestion.
With this, the total gap between will be 12px, considering styles.mt2 from the Button and styles.mb1 from the FormHelpMessage

What alternative solutions did you explore? (Optional)

We can use various margin spacing combinations for the FormHelpMessage and Button components, such as using styles.mb0 and styles.mt3 respectively when canUseTouchScreen is false.

However, changing FormHelpMessage's style will also have an effect when canUseTouchScreen is true and BigNumberPad is visible so it needs to be validated by the design team if we choose to do so.

[saranshbalyan-1234]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Error message have different space in some places

What is the root cause of that problem?

Due to extra styles passed as props, we are getting this error.

What changes do you think we should make in order to solve the problem?

App/src/pages/iou/steps/MoneyRequestAmountForm.js

Lines 260 to 274 in 67d4a7a

	{DeviceCapabilities.canUseTouchScreen() ? (
	<BigNumberPad
	nativeID={NUM_PAD_VIEW_ID}
	numberPressed={updateAmountNumberPad}
	longPressHandlerStateChanged={updateLongPressHandlerState}
	/>
	) : null}
	<Button
	success
	medium={isExtraSmallScreenHeight}
	style={[styles.w100, styles.mt5]}
	onPress={submitAndNavigateToNextPage}
	pressOnEnter
	text={buttonText}
	/>

Just need to replace mt5 with mt3 like this

  <Button
                    success
                    medium={isExtraSmallScreenHeight}
                    style={[styles.w100, styles.mt2]}
                    onPress={submitAndNavigateToNextPage}
                    pressOnEnter
                    text={buttonText}
                />

no need to change it with respect to devices as there is already a condition based on DeviceCapabilities.canUseTouchScreen() on top

What alternative solutions did you explore? (Optional)

N/A

[allroundexperts]

@aman-atg's proposal looks good to me. I think we need to reduce the margin only if the number pad is not visible.

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @Gonals, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[Gonals]

Sounds good to me! @aman-atg, can you comment in this GH? It won't let me assign you otherwise 😁

[aman-atg]

Commented! 😄

[melvin-bot]

📣 @allroundexperts Please request via NewDot manual requests for the Reviewer role ($500)

[Gonals]

Assigned!

[melvin-bot]

📣 @aman-atg 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

📣 @aman-atg 🎉 An offer has been automatically sent to your Upwork account for the Reporter role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[aman-atg]

PR is ready for review!

cc: @allroundexperts

[melvin-bot]

🎯 ⚡️ Woah @allroundexperts / @aman-atg, great job pushing this forwards! ⚡️

The pull request got merged within 3 working days of assignment, so this job is eligible for a 50% #urgency bonus 🎉

• when @aman-atg got assigned: 2023-10-02 08:20:39 Z
• when the PR got merged: 2023-10-03 14:18:41 UTC

On to the next one 🚀

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.77-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• define and use canUseTouchScreen to get apply correct value for marginTop in Button #28595

If no regressions arise, payment will be issued on 2023-10-12. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @aman-atg requires payment offer (Contributor)
• @allroundexperts does not require payment (Eligible for Manual Requests)
• @aman-atg requires payment offer (Contributor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@allroundexperts] The PR that introduced the bug has been identified. Link to the PR:
• [@allroundexperts] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@allroundexperts] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@allroundexperts] Determine if we should create a regression test for this bug.
• [@allroundexperts] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@flaviadefaria] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[flaviadefaria]

@allroundexperts can you please respond to the above comment so that I can issue payment? Thanks!

[flaviadefaria]

Bump @allroundexperts I'm no longer in BZ team but should action this as it was due last week. Thanks!

[flaviadefaria]

Payment Summary:

For reference, here are some details about the assignees on this issue:
@aman-atg requires payment offer (Contributor)
@allroundexperts does not require payment (Eligible for Manual Requests)
@aman-atg requires payment offer (Contributor)

@aman-atg - $500 + $250 (50% bonus) + $50 (reporting bonus) = $800
@allroundexperts - $500 + $250 (50% bonus) = $750

[allroundexperts]

Checklist

1. Refactor/23149 money request page #23979
2. https://github.com/Expensify/App/pull/23979/files#diff-220bddc002da5d59f03021bfe9beee13459ae566577867fde837f7f14cf4717eR245
3. I think this was a minor design issue and a Slack discussion is not needed here.
4. A regression test again would be an overkill since this is a small design in-consistency.

[allroundexperts]

@flaviadefaria I think the amount should be $850 for @aman-atg. As per @NicMendonca, we give a bonus of $50 if someone reports and fix his own bug!

[flaviadefaria]

@allroundexperts, @NicMendonca misinterpreted the internal documentation - we just clarified this internally. There's no additional bonus for reporting and fixing their own bug. They simply get paid the reporting bonus on top of what they get for fixing the bug. So $800 is the correct amount.

[allroundexperts]

Oh. Got it @flaviadefaria. Thanks for the clarification!

[flaviadefaria]

@aman-atg you've been paid so closing this GH.

[JmillsExpensify]

$750 payment approved for @allroundexperts based on BZ summary.