Desktop- IOU - Notification is only received for the first edit of IOU request in workspace

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Issue found when executing PR #27299

Action Performed:

1. Launch New Expensify app.
2. Create a workspace with admin and member.
3. [Workspace member] Send a money request to the workspace chat.
4. [Workspace admin] On desktop app, send a reply in thread to the money request.
5. [Workspace admin] Open other chat like Concierge and background the app.
6. [Workspace member] Open the IOU request and edit the amount, and then edit other fields.
   Note that

Expected Result:

The workspace admin on desktop app will receive notification for each edit on the IOU request (amount, description, date etc)

Actual Result:

The workspace admin on desktop app only receives notification for the first IOU request edit

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.75-3

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6219475_1696014966132.20230930_001722.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @chiragsalian (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[chiragsalian]

i wasn't able to tackle this today. I'll continue it on Monday if it hasn't been tackled yet.

[mountiny]

This is a new feature, so I don think its valid blocker, I have also assigned Andrew coming from the original PR

[arosiclair]

Can't reproduce this on staging v1.3.75-8.

@lanitochka17 it looks like step 4 is incorrect. The admin needs to open the expense and reply in the the expense thread for the notifications to display. NOT in the report thread.

Closing this out. Please re-open/comment if anything else comes up

[lanitochka17]

Issue reproducible on the latest build 1.4.9-2

20231207_223316.mp4

[arosiclair]

@lanitochka17 this test isn't correct. It's the same issue as described above.

Employee needs to comment directly on the expense before they can receive notifications for the expense being edited. The comment you added here is on the report:

What regression test are you following? It probably needs to be updated

[melvin-bot]

@sakluger, @arosiclair Whoops! This issue is 2 days overdue. Let's get this updated quick!

[arosiclair]

@lanitochka17 bump ^

[sakluger]

@lanitochka17 assigning you since we're waiting on your response.

[mvtglobally]

This issue found when executing PR
#27299.
We will double check if any TR steps need updating

[melvin-bot]

@sakluger, @arosiclair, @lanitochka17 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@sakluger, @arosiclair, @lanitochka17 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[arosiclair]

@mvtglobally @lanitochka17 this test IOU Actions - Edit Amount is incorrect. Step 2 should be:

Navigate to the money request details, open the expense details and send a message (this will subscribe the user to notifications)

I also see that these tests do not have that step and they should have them

1. IOU Actions - Edit Merchant
2. IOU Actions - Edit Date
3. IOU Actions - Edit Description

[mvtglobally]

@arosiclair
We will update these accordingly

[sakluger]

@arosiclair just to confirm, is this even a bug, or are you saying that it's expected behavior?

[melvin-bot]

@sakluger, @arosiclair, @lanitochka17 Whoops! This issue is 2 days overdue. Let's get this updated quick!

[arosiclair]

@arosiclair just to confirm, is this even a bug, or are you saying that it's expected behavior?

Yeah it's expected behavior. Without commenting on an expense, you don't get notifications for edits on the expense (same way it works for commenting on threads).

[arosiclair]

@mvtglobally it still doesn't look like those tests were updated

[arosiclair]

@mvtglobally bump also in slack

[isagoico]

@arosiclair after a review we modified the test cases to the following:

• Edited step 2 in TC IOU Actions - Edit Amount to be clearer that the message should be sent in the expense/transaction details conversation for the user to be subscribed to notifications.

Before: Navigate to the request details conversation and send a message (this will subscribe the user to notifications)
After: Navigate to the expense/transaction details conversation and send a message (this will subscribe the user to notifications)

For the consequent TCs, to avoid repeating the step of creating a new request and subscribing the user each time, I added a note that it should be executed in the same money request as in the first TC in the IOU Actions series > IOU Actions - Edit Amount. This would save us a bit of time when executing these TCs. Let me know if it's valuable to create a new request and subscribing to each for each edit action TC and we can modify the TCs so those 2 steps are repeated each time.

Additionally, we will remind our testers the difference between the 3 conversation types (1:1 or parent conversation, report conv and request conv) to avoid mixups with the report and expense details conversation.

[arosiclair]

Thank you for the updates they look good to me 👍. In the future please, prioritize any test case updates like this since we'll continue to run tests incorrectly until the updates are done.

[melvin-bot]

@sakluger @arosiclair Be sure to fill out the Contact List!