[$500] Private note - The note item has no hover effect until moving the cursor, while it works fine for back button

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Open the app and login with any account.
2. Open any chat report and click on the header.
3. Go to private note.
4. Click the right arrow to go My notes, keep the cursor in the same place while navigating to the next page.
5. Observe that no hover effect is displayed for the note item until moving the cursor.
6. Repeat the same with back button and observe that the tooltip is appeared without moving the cursor.

Expected Result:

App should display hover effect for the note item without moving the cursor.

Actual Result:

The note item has no hover effect until moving the cursor, while it works fine for back button.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.75.2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-09-22.at.6.10.15.PM.mov

Screen.Recording.2023-09-29.at.1.27.18.PM.mov

Recording.1630.mp4

Expensify/Expensify Issue URL:
Issue reported by:@ahmedGaber93
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1695987108079269

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01edee5e50fa23328a
• Upwork Job ID: 1708213962121248768
• Last Price Increase: 2023-09-30

[melvin-bot]

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01edee5e50fa23328a

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (External)

[saranshbalyan-1234]

Working fine for me

Screen.Recording.2023-09-30.at.1.22.55.PM.mov

[anmoluiux]

@kbecciv Looking into this issue...
Will revert in a while.

[melvin-bot]

📣 @anmoluiux! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[anmoluiux]

Contributor details
Your Expensify account email: [email protected]
Upwork Profile Link: Link Anmol.UIUX

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[tienifr]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Private note - The note item has no hover effect until moving the cursor, while it works fine for back button

What is the root cause of that problem?

We already have the logic to handle onMouseEnter in Hoverable

App/src/components/Hoverable/index.js

Line 127 in c390d5e

const onMouseEnter = useCallback(

but the event will not fired if the transition is processing (like what happens when we try to focus the input while transition is processing)

This event cab be fired again if the page is re-rendered, but PrivateNote page just is rendered only once -> onMouseEnter is not called

What changes do you think we should make in order to solve the problem?

In PrivateNotesViewPage we can get didScreenTransitionEnd from ScreenWrapper and pass it to MenuItemWithTopDescription

In Hoverable, define new props didScreenTransitionEnd with the default value is true, and update this condition

App/src/components/Hoverable/index.js

Line 164 in c390d5e

if (!DeviceCapabilities.hasHoverSupport()) {

to

    if (!DeviceCapabilities.hasHoverSupport() || !didScreenTransitionEnd) {

Result

Screen.Recording.2023-10-02.at.16.02.15.mov

[zanyrenney]

I can't reproduce this myself and form the videos, this seems like a small inconsistency and UI polish as opposed to an actual bug. It does not affect user performance or workflows at all. Closing.