[$500] Android - white border in checkbox while Offline

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Go offline
2. Go to settings > workspace > members > invite
3. Invite member which is not in list
4. Go to members
5. Select that user

Expected Result:

It should not show white border

Actual Result:

white border appears while Offline

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.75.2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

WhatsApp.Video.2023-09-29.at.5.18.15.PM.2.mp4

Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1695988538728789

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~010099c7efd17d5ffa
• Upwork Job ID: 1708217388635340800
• Last Price Increase: 2023-09-30

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~010099c7efd17d5ffa

[melvin-bot]

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

[ZhenjaHorbach]

Proposal

Please re-state the problem that we are trying to solve in this issue

A white border appears on the checkbox

What is the root cause of that problem?

This looks like a native bug

When free space appears between the green border and green background

What changes do you think we should make in order to solve the problem?

App/src/components/SelectionList/UserListItem.js

Lines 68 to 77 in 7c86d09

	<View style={styles.checkboxPressable}>
	<View
	style={[
	StyleUtils.getCheckboxContainerStyle(20, 4),
	item.isSelected && styles.checkedContainer,
	item.isSelected && styles.borderColorFocus,
	item.isDisabled && styles.cursorDisabled,
	item.isDisabled && styles.buttonOpacityDisabled,
	]}
	>

For the checkbox we have a set of styles
In which, by default, we have border in an unselected state

But when we select the checkbox
This border are repainted

Therefore, in the selected state we can remove border

Add styles item.isSelected && { borderWidth: 0 } and deleteitem.isSelected && styles.borderColorFocus

Since instead of painting the border, we will remove it

Which won't affect anything
But this native bug will be fixed

Screen.Recording.2023-09-30.at.23.52.13.mov

And we can create common styles and check other places where we use checkbox in offline mode

Also we can add box-sizing: border-box (But as far as I understand it is already installed by default)
Update: In React Native box-sizing: border-box is default value ))

What alternative solutions did you explore? (Optional)

NA

[joekaufmanexpensify]

Going to triage this tomorrow.

[joekaufmanexpensify]

IMO, it's not worth doing anything to change this. I don't think this is really a bug. It's a minor design inconsistency that isn't really noticeable at all. Closing.