-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$1000] mWeb - App does not open keyboard on reload on share somewhere page #28550
Comments
Triggered auto assignment to @sophiepintoraetz ( |
Job added to Upwork: https://www.upwork.com/jobs/~012fb33f28776cfbe2 |
Bug0 Triage Checklist (Main S/O)
|
Triggered auto assignment to Contributor-plus team member for initial proposal review - @jjcoffee ( |
ProposalPlease re-state the problem that we are trying to solve in this issue.When a text input is focused and the page is reloaded, the app retains the focus on the text input, but the keyboard does not open. What is the root cause of that problem?The app retains the focus on the text input on refresh. What changes do you think we should make in order to solve the problem?In the BaseTextInput.js component, within the useEffect that handles autofocus, add a condition to blur the input if it's already focused, and then refocus it. This trigger the keyboard to show up. if (isFocused) {
input.current.blur();
} What alternative solutions did you explore? (Optional) |
@rayane-djouah Where within the useEffect did you add the blur? I added it but it does not seem to have any effect on the text input. |
@sophiepintoraetz @jjcoffee, I think it's similar to this one #26312 (comment) |
@rayane-djouah Could you confirm if your fix works on mWeb Safari? |
@dhanashree-sawant should have confirmed that this only happens on android, if that's the case, then I think it's not the same issue as #26312 (comment) because that's for iOS. |
Hi @sophiepintoraetz, sorry for the confusion, will ensure to mention that it is working fine on other platforms while raising the issue from now on. |
Triggered auto assignment to @johncschuster ( |
This comment was marked as duplicate.
This comment was marked as duplicate.
Hey @johncschuster! I just need some help babysitting this issue while I'm OOO till 17 Oct - so far, we only have one proposal for @jjcoffee to review. Otherwise, was going to bump in #open source / the agencies! |
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸 |
@johncschuster, @jjcoffee, @sophiepintoraetz Whoops! This issue is 2 days overdue. Let's get this updated quick! |
@rayane-djouah Any response on this comment? |
The same happens on iOS Safari by the way: ios-keyboard-2023-10-11_13.23.52.mp4 |
Posted in #expensify-open-source for proposals |
@johncschuster @jjcoffee @sophiepintoraetz this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks! |
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸 |
@sophiepintoraetz, I posted an announcement to gather more proposals, but it hasn't really gotten anywhere. Do you feel we should increase the bounty, or shall we wait a few more days? |
I think this is mobile web's default behavior. |
The following issue is specifically after reload, safari has that issue even on opening the page normally. |
Thank you for helping me out, @johncschuster - taking this back now. |
Upwork job price has been updated to $1000 |
@jjcoffee @sophiepintoraetz this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ and will need to go internal. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks! |
Bumped on Slack. |
This is a native behavior of the android chrome browser. I don't think we should be worried about this issue. We have close this many times in the past. |
After testing based on our discussion on Slack, I can confirm there isn't really a fix for this as it requires user interaction first before we can programmatically open the keyboard. We're good to close this @sophiepintoraetz! |
I have been working on it for over two days.. I was able to blur and refocus.. however the keyboard didn't show... It seems the browser stopped from opening the keyboard without user's interaction However there is navigator.virtualKeyboard which is only experimental but also only available on desktop |
📣 @abeebridwan! 📣
|
Contributor details |
✅ Contributor details stored successfully. Thank you for contributing to Expensify! |
Got it, thanks for the discussion all! Thank you @abeebridwan - looks like you just missed out - but there are plenty of issues for you to get involved with! |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Action Performed:
Expected Result:
App should open keyboard on focus on search on share somewhere page
Actual Result:
App does not open keyboard on reload on share somewhere page
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Version Number: 1.3.75.2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
android.chrome.reload.on.share.somewhere.page.no.keyboard.mp4
Screen_Recording_20230930_165634_Chrome.mp4
Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1696015367950349
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: