[HOLD for payment 2023-10-16] [$500] Log in - App doesn't switches to first digit on click on didn't recieved a magic code click

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Open the app
2. If login then logout
3. Enter any contact and continue
4. Shift focus to any other digit then 1st digit and wait for some time to enable 'Didn't recieved a magic code' link
5. when enabled, click on it and observe that app doesn't reset to first digit

Expected Result:

App should reset focus to first digit on click on 'Didn't recieved a magic code' link

Actual Result:

App doesn't reset focus to first digit on click on 'Didn't recieved a magic code' link

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.75-0

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

focus.does.not.go.to.first.digit.IOS.safari.1.mov

focus.does.not.get.back.to.first.digit.IOS.1.mov

focus.does.not.go.to.first.digit.mac.desktop.1.mov

focus.does.not.shift.to.first.digit.windows.chrome.1.mp4

android.chrome.focus.does.not.go.back.to.first.digit.1.mp4

0-02-01-5b5124654b336a88428c096bca2af934fe7cd8de0c4396514a036a7976d572e2_c299dac93520f303.1.mp4

Expensify/Expensify Issue URL:

Issue reported by: @dhanashree-sawant

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1695578315038989

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~019251bb2b1418cd16
• Upwork Job ID: 1708239064011689984
• Last Price Increase: 2023-09-30
• Automatic offers:
• aimane-chnaif | Reviewer | 26989941

Issue Owner

Current Issue Owner: @anmurali

[melvin-bot]

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~019251bb2b1418cd16

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (External)

[ZhenjaHorbach]

Proposal

Please re-state the problem that we are trying to solve in this issue

App doesn't reset focus to first field on click on reset link

What is the root cause of that problem?

After resend we don't update focus state

What changes do you think we should make in order to solve the problem?

We can add inputValidateCodeRef.current.focus() inside resendValidateCode

App/src/pages/signin/ValidateCodeForm/BaseValidateCodeForm.js

Lines 178 to 182 in 7c86d09

	const resendValidateCode = () => {
	User.resendValidateCode(props.credentials.login);
	// Give feedback to the user to let them know the email was sent so that they don't spam the button.
	setTimeRemaining(30);
	};

What alternative solutions did you explore? (Optional)

NA

Screen.Recording.2023-10-01.at.00.27.31.mov

[allroundexperts]

Proposal

Please re-state the problem that we are trying to solve in this issue.

App doesn't switch to the first digit when clicked on didn't receive a magic code link.

What is the root cause of that problem?

We're not resetting the state of the magic code input when clicked on the link as seen here.

What changes do you think we should make in order to solve the problem?

We should reset the inputValidateCodeRef state here and add the following:

        setValidateCode('');
        inputValidateCodeRef.current.clear();
        inputValidateCodeRef.current.focus();

This is in sync with how we're handling this here.

We might also encapsulate this functionality which is common across the two components into another common component and DRY the code a bit.

What alternative solutions did you explore? (Optional)

None

[aimane-chnaif]

@allroundexperts's proposal looks good to me.
🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @marcaaron, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[marcaaron]

If there is a place where we are already handling this then I think the solution would be to move that logic to a central location instead of duplicate it.

Why do we have two files called BaseValidateCodeForm? They look very similar to me ☹️

[melvin-bot]

📣 @aimane-chnaif 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @allroundexperts Please request via NewDot manual requests for the Contributor role ($500)

[allroundexperts]

PR created #28757

[allroundexperts]

If there is a place where we are already handling this then I think the solution would be to move that logic to a central location instead of duplicate it.

Why do we have two files called BaseValidateCodeForm? They look very similar to me ☹️

@marcaaron They are a little similar but the two files have some key differences as seen in the images below:

I think we can create a single component out of these two, but that will require a broader discussion involving the design team around the differences between the two components. (Eg on the sign in page, we're showing a timer while on the contacts page we aren't). As far as this bug is concerned, I think combining the two is out of scope.

[marcaaron]

Interesting, but what is similar about them? This code you are proposed to add is similar to some others. Can we encapsulate it somehow? Or is it not worth doing?

[aimane-chnaif]

There are some inconsistencies between 2 pages but I think this was already discussed internally and leave them as is for now - #21619 (comment), #21104 (comment)

[marcaaron]

I don't see how either comment relates to my concern about code reuse. Things can be different and share code.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.79-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: clear the input when resending validate code #28757

If no regressions arise, payment will be issued on 2023-10-16. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @allroundexperts does not require payment (Eligible for Manual Requests)
• @aimane-chnaif requires payment offer (Reviewer)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@allroundexperts / @aimane-chnaif] The PR that introduced the bug has been identified. Link to the PR:
• [@allroundexperts / @aimane-chnaif] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@allroundexperts / @aimane-chnaif] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@allroundexperts / @aimane-chnaif] Determine if we should create a regression test for this bug.
• [@allroundexperts / @aimane-chnaif] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@anmurali] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

@anmurali, @allroundexperts, @marcaaron, @aimane-chnaif Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[aimane-chnaif]

• The PR that introduced the bug has been identified. Link to the PR: Fix: Contact Method - Validation error message doesn't disappear upon requesting new magic code #19950
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/19950/files#r1365477344
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• Determine if we should create a regression test for this bug.
• If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

This is more like UX improvement than bug and doesn't affect resend logic, so I don't propose regression test.

[melvin-bot]

@anmurali, @allroundexperts, @marcaaron, @aimane-chnaif Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[JmillsExpensify]

Can I get a payment summary on this issue?

[melvin-bot]

@anmurali, @allroundexperts, @marcaaron, @aimane-chnaif Huh... This is 4 days overdue. Who can take care of this?

[anmurali]

• @allroundexperts $500 + $250 (Eligible for Manual Requests) (Contributor)
• @aimane-chnaif $500 + $250 offer (Reviewer)
• @dhanashree-sawant $50 offer - pending acceptance (Issue Reporter)

[aimane-chnaif]

This is eligible for bonus. Merged exactly in 72 hrs

[melvin-bot]

@anmurali, @allroundexperts, @marcaaron, @aimane-chnaif Eep! 4 days overdue now. Issues have feelings too...

[anmurali]

Added bonus

[anmurali]

I am closing this as this is just pending @allroundexperts payment on ND.

[JmillsExpensify]

$750 payment approved for @allroundexperts based on BZ summary.