[HOLDING on #26538][$500] Distance - Changing stop and finish causes TDB in distance

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Open the app
2. Click on plus and click request money
3. Click distance
4. Add 3 address in distance (Start, finish and one stop) (eg: Kent, WA USA ; Kirkland, WA, USA ; Seatle, WA, USA )
5. Click next and select any workspace, observe that it properly provides us with miles and amount
6. Go back twice and exchange value of stop and finish and again continue to reach amount page
7. Observe that now it displays TBD in amount and it doesn't display route in map above amount

Expected Result:

App should modify amount and miles and route if we exchange stop and finish values

Actual Result:

App displays TBD in amount and in miles and also does not display route if we exchange stop and finish values

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.75-8

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

ios.native.TBD.for.replacing.stop.and.finish.mov

android.native.TBD.for.replacing.stop.and.finish.mov

ios.safari.TBD.for.replacing.stop.and.finish.mov

android.chrome.TBD.for.replacing.stop.and.finish.mp4

windows.chrome.TBD.for.replacing.stop.and.finish.mp4

mac.chrome.TBD.for.replacing.stop.and.finish.mov

mac.desktop.TBD.for.replacing.stop.and.finish.mov

Recording.120.mp4

Expensify/Expensify Issue URL:

Issue reported by: @dhanashree-sawant

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1696063336006619

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01ce183a2973a17c45
• Upwork Job ID: 1708579977980162048
• Last Price Increase: 2023-10-01

Issue Owner

Current Issue Owner: @mvtglobally

[melvin-bot]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01ce183a2973a17c45

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

App displays TBD in amount and in miles and also does not display route if we exchange stop and finish values

What is the root cause of that problem?

After we select the workspace in the participants page, we set the money request id with the report id of the workspace here.

But later when we navigate back to the Distance selection page, we don't use that reportID in the param. So in here, it will reset all the money request data. Leading to the TBD and no coordinates show.

What changes do you think we should make in order to solve the problem?

We need to add the reportID to the route params when navigating back from the participants page to the distance page. So it will be considered editing a draft money request, not creating (and resetting) a new money request.

What alternative solutions did you explore? (Optional)

NA

[paultsimura]

The RCA is the same as in #28129 - there was a little discussion in the original slack thread.

[DylanDylann]

ref: #26946 (comment)

[mananjadhav]

@johncschuster should we post this on Hold? Based on the previous comments and linked one, we should hold all shouldReset logic.

[johncschuster]

Sounds good, @mananjadhav! I've just put it on hold.

[melvin-bot]

@mananjadhav, @johncschuster Whoops! This issue is 2 days overdue. Let's get this updated quick!

[johncschuster]

Still holding

[johncschuster]

Still holding

[melvin-bot]

@mananjadhav @johncschuster this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[mvtglobally]

Issue not reproducible during KI retests. (First week)

[johncschuster]

That's great! We'll keep this open one more week and see if the behavior is reproducible during the next KI tests.

[melvin-bot]

@mananjadhav @johncschuster this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ and will need to go internal. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

[johncschuster]

@mvtglobally can you check to see if this behavior is still reproducible?

[johncschuster]

@mvtglobally bump!

[mvtglobally]

Updating shortly

[mvtglobally]

Issue not reproducible during KI retests. (Second week)

[melvin-bot]

@mananjadhav @johncschuster @mvtglobally this issue is now 4 weeks old and preventing us from maintaining WAQ, can you:

• Decide whether any proposals currently meet our guidelines and can be approved as-is today
• If no proposals meet that standard, please take this issue internal and treat it as one of your highest priorities
• If you have any questions, don't hesitate to start a discussion in #expensify-open-source

Thanks!

[melvin-bot]

Current assignee @mananjadhav is eligible for the Internal assigner, not assigning anyone new.

[melvin-bot]

@mananjadhav, @johncschuster, @mvtglobally Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

@mananjadhav, @johncschuster, @mvtglobally Huh... This is 4 days overdue. Who can take care of this?

[johncschuster]

@mananjadhav it looks like this behavior might not be reproducible anymore. I'm going to close this issue unless you feel differently.

[melvin-bot]

@johncschuster Be sure to fill out the Contact List!