[HOLD for payment 2023-11-01] [$500] mWeb-Compose-Tapping emoji picker, for a million second, the message section is selected and shown

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Go to https://staging.new.expensify.com/
2. Tap on a report
3. Tap on emoji picker in compose box

Expected Result:

When tapping on emoji picker, for a million second also, the message section must not be selected and shown. only emoji box must be displayed.

Actual Result:

When tapping on emoji picker, for a million second, the message section is selected and shown and then only emoji box is displayed

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3 76-0

Reproducible in staging?: Y

Reproducible in production?: Y

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6222872_1696316543405.selected_box.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause-Internal Team

Slack conversation: @

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01968cbb3d0a1ef947
• Upwork Job ID: 1709683408501026816
• Last Price Increase: 2023-10-11
• Automatic offers:
• ntdiary | Reviewer | 27283894
• tienifr | Contributor | 27283896

[melvin-bot]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01968cbb3d0a1ef947

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ntdiary (External)

[tienifr]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When tapping on emoji picker, for a million second, the message section is selected and shown and then only emoji box is displayed

What is the root cause of that problem?

We're using debounce for the window dimensions in withWindowDimensions here. This leads to the windowHeight of withWindowDimensions being updated 300ms after the window dimensions change (for performance reasons). This windowHeight is being used in EmojiPicker. Meanwhile in PopoverWithMeasuredContent, we're using windowHeight from useWindowDimensions, which is updated immediately without the debounce. This means the popover dimensions and styles in EmojiPicker is updated 300ms late, causing message section to show briefly in the background.

What changes do you think we should make in order to solve the problem?

We need to use windowHeight (and other applicable props) from useWindowDimensions in EmojiPicker as well to be consistent with the PopoverWithMeasuredContent. Also we're planning to move away from HOC withWindowDimensions as per this comment as well so this makes sense.

We can optionally use the useWindowDimensions in the EmojiPickerMenu as well, but that one is currently still a class component. For now we can pass the windowHeight from EmojiPicker to EmojiPickerMenu (until the EmojiPickerMenu becomes a functional component, when we can use the hook).

What alternative solutions did you explore? (Optional)

We can apply a 300ms delay to showing the emoji picker to wait for the keyboard to close and also the window dimensions debounce to take effect.

[johncschuster]

This isn't overdue. It was just triaged to @ntdiary

[melvin-bot]

@johncschuster, @ntdiary Whoops! This issue is 2 days overdue. Let's get this updated quick!

[ntdiary]

@tienifr, so we just need to use the useWindowDimensions hook in EmojiPicker? The modal can already cover the underlying messages, although the animation is still a bit jerky.

demo.mp4

[tienifr]

@tienifr, so we just need to use the useWindowDimensions hook in EmojiPicker? The modal can already cover the underlying messages, although the animation is still a bit jerky.

Yes. If we use the height from useWindowDimensions in EmojiPickerMenu as well then the jerky animation will be gone.

We could pass it from EmojiPicker for now and add a code comment explaining we should move to use useWindowDimensions inside EmojiPickerMenu once that one is converted to functional component.

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[johncschuster]

@ntdiary, can you check out @tienifr's response above? Do you feel the proposal is sufficient, or should we keep looking?

[ntdiary]

@ntdiary, can you check out @tienifr's response above? Do you feel the proposal is sufficient, or should we keep looking?

Hi, @johncschuster, it looks like the modal animation is still a bit lagging, I think we can wait a few more days to see if there are any better solutions.

[melvin-bot]

@johncschuster @ntdiary this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[ntdiary]

Not overdue. We can move forward with @tienifr's proposal.

The animation lag is related to the whole app rendering and cannot be directly fixed here, however, there is a small reference point (not yet fully verified if it will cause some errors):
It looks like there are over a hundred dimension listeners in our app currently, they may be executed in one long task. If we can break them up into multiple smaller tasks, it might be better.

🎀 👀 🎀 C+ reviewed

[melvin-bot]

📣 @ntdiary 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @tienifr 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[johncschuster]

Not overdue.

[melvin-bot]

🎯 ⚡️ Woah @ntdiary / @tienifr, great job pushing this forwards! ⚡️

The pull request got merged within 3 working days of assignment, so this job is eligible for a 50% #urgency bonus 🎉

• when @tienifr got assigned: 2023-10-19 19:41:38 Z
• when the PR got merged: 2023-10-23 19:51:10 UTC

On to the next one 🚀

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.90-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: 28698 Tapping emoji picker the message section is selected and shown #30048

If no regressions arise, payment will be issued on 2023-11-01. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @ntdiary requires payment offer (Reviewer)
• @tienifr requires payment offer (Contributor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@ntdiary] The PR that introduced the bug has been identified. Link to the PR:
• [@ntdiary] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@ntdiary] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@ntdiary] Determine if we should create a regression test for this bug.
• [@ntdiary] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@johncschuster] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[ntdiary]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@ntdiary] The PR that introduced the bug has been identified. Link to the PR: Fix image loads on resize window #26543
• [@ntdiary] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/26543/files#r1381406517
• [@ntdiary] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: No need
• [@ntdiary] Determine if we should create a regression test for this bug. No need
• [@ntdiary] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. No need
• [@johncschuster] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

No need for regression test, I think leaving the comment in the original PR is sufficient. Also, in our review checklist, we have stated that when changing a generic component, we should try to test the impacted components. : )

[melvin-bot]

@johncschuster, @marcochavezf, @ntdiary, @tienifr Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[johncschuster]

Payment has been issued! 🎉