Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-10-25] [Wave 6: Drafts] Add IOUTests.js tests for submitting a report #28764

Closed
mountiny opened this issue Oct 3, 2023 · 7 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2

Comments

@mountiny
Copy link
Contributor

mountiny commented Oct 3, 2023

Part of https://github.com/Expensify/Expensify/issues/308213

Coming from the doc here, we would like to add tests into the IOUTests.js file which will cover the submit report action.

@mountiny mountiny added the Weekly KSv2 label Oct 3, 2023
@puneetlath puneetlath changed the title [HOLD #28763] Wave6 - Drafts - Add IOUTests.js tests for submitting a report [HOLD #28763] [Wave 6: Drafts] Add IOUTests.js tests for submitting a report Oct 4, 2023
@waterim
Copy link
Contributor

waterim commented Oct 9, 2023

Hello, Im Artem from Callstack and would like to help with this one

@mountiny mountiny changed the title [HOLD #28763] [Wave 6: Drafts] Add IOUTests.js tests for submitting a report [Wave 6: Drafts] Add IOUTests.js tests for submitting a report Oct 9, 2023
@mountiny
Copy link
Contributor Author

mountiny commented Oct 9, 2023

Thanks for taking it, let me know in slack if anything is not clear

@waterim
Copy link
Contributor

waterim commented Oct 9, 2023

Sure! Thank you

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Oct 13, 2023
@melvin-bot melvin-bot bot changed the title [Wave 6: Drafts] Add IOUTests.js tests for submitting a report [HOLD for payment 2023-10-25] [Wave 6: Drafts] Add IOUTests.js tests for submitting a report Oct 18, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 18, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Oct 18, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 18, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.86-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-10-25. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

  • @waterim does not require payment (Contractor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels Oct 25, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 30, 2023

@mountiny, @waterim Eep! 4 days overdue now. Issues have feelings too...

@mountiny
Copy link
Contributor Author

No payments required

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2
Projects
No open projects
Development

No branches or pull requests

2 participants