-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2023-10-25] [ECard Transactions] Update MoneyReportView UI #28831
Comments
Job added to Upwork: https://www.upwork.com/jobs/~01d8c70e4db5e9b4e3 |
Triggered auto assignment to Contributor Plus for review of internal employee PR - @s77rt ( |
Triggered auto assignment to @lschurr ( |
I think this is the last one I need to do for the core UI, will try to get a PR up in the morning to wrap the major FE up |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.86-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2023-10-25. 🎊 After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
|
BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
@grgia Do we need a regression test here? I'm not sure what would be the test steps from the user/qa perspective to reproduce this |
Payment summary: Contributor+: @s77rt $500 |
@s77rt remind me - are you paid via Newdot or Upwork? |
@lschurr Upwork |
Great! Are you able to apply here @s77rt? https://www.upwork.com/jobs/~01d8c70e4db5e9b4e3 |
@lschurr Applied! Thanks! |
Offer sent @s77rt! |
Accepted! |
Great! Paid. Closing. |
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results. If a regression has occurred and you are the assigned CM follow the instructions here. If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future. |
Design Doc Section
https://docs.google.com/document/d/1iELOXPOAcnuIPZJ3XbO1S8_3qHaM31Ptf8dR4LRZMyE/edit#bookmark=kix.814c36x8plt
Overview
Goal:
Update our Money Report Headers to separate out Company and Out-Of-Pocket spend.
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: