[HOLD for payment 2023-10-25] [$500] Private Notes - The strikethrough line of the link is displaying in white on the Private Notes page

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Navigate to staging.
2. Open any chat
3. Click on the header and go to Private notes
4. Go to My note > Notes
5. Add "https://xyz.com/" and save
6. Notice that the strikethrough line appears in white

Expected Result:

The strikethrough line should have the same colour as the link.

Actual Result:

The strikethrough line appears in white

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.77.5
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:
Issue reported by: @aman-atg
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1696349734344339

View all open jobs on GitHub

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~014c91f7ea867225a7

[melvin-bot]

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ntdiary (External)

[b4s36t4]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Private Note - The note is not immediately saved, and the previous value persists

What is the root cause of that problem?

We render the links/html with a parent tag comment at all other places which does the work of adding required CSS styles/rendering.

Whereas at the MenuItem we're not doing it.

App/src/pages/home/report/ReportActionItemFragment.js

Line 113 in 4975bca

return <RenderHTML html={props.source === 'email' ? `<email-comment>${htmlWithTag}</email-comment>` : `<comment>${htmlWithTag}</comment>`} />;

App/src/components/MenuItem.js

Line 258 in 4975bca

<MenuItemRenderHTMLTitle title={getProcessedTitle} />

What changes do you think we should make in order to solve the problem?

We need to wrap the title here

App/src/components/MenuItem.js

Line 258 in 4975bca

<MenuItemRenderHTMLTitle title={getProcessedTitle} />

with <comment> tag which does add the required changes.

What alternative solutions did you explore? (Optional)

NA

Kapture.2023-10-05.at.03.34.45.mp4

[ZhenjaHorbach]

same reason as here
#27812
#28862

And we can use the same solution
#27812 (comment)
#28862 (comment)

[maxconnectAbhi]

Proposal

Please re-state the problem that we are trying to solve in this issue

The strikethrough line of the link is displaying in white

What is the root cause of that problem?

We don't use wrapper for links for MenuItem component.

What changes do you think we should make in order to solve the problem?

Need to make a <comment> wrapper around MenuItem title
(<comment> tag add special styles for links )

What alternative solutions did you explore? (Optional)

NA

[maxconnectAbhi]

Proposal

Please re-state the problem that we are trying to solve in this issue

The strikethrough line of the link is displaying in white

What is the root cause of that problem?

Currently we are not using any wrapper for html links in MenuItem component.

What changes do you think we should make in order to solve the problem?

Need to make a <comment> wrapper around MenuItem title like convertToLTR(props.title);
(<comment> tag add special styles for links )

What alternative solutions did you explore? (Optional)

NA

[jjcoffee]

This will be handled in #27812 where we'll be wrapping with <comment> tags.

[greg-schroeder]

@jjcoffee any objection to just closing this in that case?

[jjcoffee]

@greg-schroeder Happy to close!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.86-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• The "Copy URL to clipboard" tooltip does not appear when hovering over a task description link #28951

If no regressions arise, payment will be issued on 2023-10-25. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @ntdiary requires payment
• @aman-atg requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@ntdiary] The PR that introduced the bug has been identified. Link to the PR:
• [@ntdiary] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@ntdiary] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@ntdiary] Determine if we should create a regression test for this bug.
• [@ntdiary] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@greg-schroeder] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: