Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$500] [Wave 6: Workspace Chats] Category IOU- When deleting IOU request in WS chat, error is shown #28966

Closed
6 tasks done
lanitochka17 opened this issue Oct 5, 2023 · 55 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Hot Pick Ready for an engineer to pick up and run with Internal Requires API changes or must be handled by Expensify staff

Comments

@lanitochka17
Copy link

lanitochka17 commented Oct 5, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Action Performed:

  1. Go to https://staging.new.expensify.com/

  2. Tap on Workspace chat

  3. Tap plus icon and select request money

  4. Enter an amount

  5. Tap next

  6. Tap request amount

  7. Tap IOU

  8. Long tap IOU again to select delete request

  9. Tap delete

Expected Result:

When user tap "delete" request, IOU must be deleted

Actual Result:

When user tap "delete" request, IOU is not deleted and error message shown under IOU "unexpected error deleting the money request, please try again later"
"Unexpected error deleting the money request, please try again later"

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.78-0

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6226532_1696542781261.error_delete.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~015cf957f0fdc69b9a
  • Upwork Job ID: 1719032129095122944
  • Last Price Increase: 2023-11-02
Issue OwnerCurrent Issue Owner: @lanitochka17
Issue OwnerCurrent Issue Owner: @lanitochka17
@lanitochka17 lanitochka17 added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Oct 5, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 5, 2023

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Oct 5, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@mallenexpensify
Copy link
Contributor

@lanitochka17 can you elaborate on

Tap on Workspace chat

Is is a room, a 1:1 chat with a member on a workspace? Thx

@lanitochka17
Copy link
Author

@mallenexpensify You are right, this happens in a Workspace with one member

@melvin-bot melvin-bot bot added the Overdue label Oct 9, 2023
@mallenexpensify
Copy link
Contributor

@lanitochka17 I still don't understand how to access the report.
Also.. it's possible to have an IOU request in a workspace chat room with only 1 person? You'd just be requesting money from yourself, right?

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Oct 9, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 13, 2023

@mallenexpensify, @lanitochka17 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@mallenexpensify
Copy link
Contributor

@lanitochka17 when you get a minute can you address the above plz
#28966 (comment)

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Oct 13, 2023
@mallenexpensify
Copy link
Contributor

@lanitochka17 👀 plz
#28966 (comment)

@melvin-bot melvin-bot bot removed the Overdue label Oct 16, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 19, 2023

@mallenexpensify @lanitochka17 this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@melvin-bot melvin-bot bot added the Overdue label Oct 19, 2023
@mallenexpensify
Copy link
Contributor

@lanitochka17 👀 above plz

@melvin-bot melvin-bot bot removed the Overdue label Oct 20, 2023
@lanitochka17
Copy link
Author

@mallenexpensify
First, create a workspace, then make a request for money in this workspace.
Then open the IOU and delete it.

Issue is not reproducible on latest build 1.3.87-8
Samsung Galaxy A50/Android11

0-02-01-1b91d1298ffb9a4a7dc9828b34c28b22dfec29155bfc5a92076cf4263d8fba66_6a8c482ead54dc9e.mp4

@melvin-bot melvin-bot bot added the Overdue label Oct 23, 2023
@mallenexpensify
Copy link
Contributor

Thanks @lanitochka17
Can't test, I broke my expensifail.com account :/

@melvin-bot melvin-bot bot removed the Overdue label Oct 23, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 26, 2023

@mallenexpensify @lanitochka17 this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

@melvin-bot
Copy link

melvin-bot bot commented Oct 27, 2023

@mallenexpensify, @lanitochka17 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@melvin-bot melvin-bot bot added the Overdue label Dec 15, 2023
Copy link

melvin-bot bot commented Dec 18, 2023

@akinwale, @mallenexpensify, @lanitochka17 Huh... This is 4 days overdue. Who can take care of this?

1 similar comment
Copy link

melvin-bot bot commented Dec 18, 2023

@akinwale, @mallenexpensify, @lanitochka17 Huh... This is 4 days overdue. Who can take care of this?

@mallenexpensify
Copy link
Contributor

@melvin-bot melvin-bot bot removed the Overdue label Dec 18, 2023
@greg-schroeder greg-schroeder changed the title [$500] Category IOU- When deleting IOU request in WS chat, error is shown [$500] [Wave 6: Workspace Chats] Category IOU- When deleting IOU request in WS chat, error is shown Dec 18, 2023
@melvin-bot melvin-bot bot added the Overdue label Dec 21, 2023
Copy link

melvin-bot bot commented Dec 22, 2023

@akinwale, @mallenexpensify, @lanitochka17 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@mallenexpensify
Copy link
Contributor

Added to Wave 6 and the project board!

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Dec 23, 2023
@quinthar quinthar added the Hot Pick Ready for an engineer to pick up and run with label Dec 27, 2023
Copy link

melvin-bot bot commented Dec 27, 2023

@akinwale, @mallenexpensify, @lanitochka17 Whoops! This issue is 2 days overdue. Let's get this updated quick!

Copy link

melvin-bot bot commented Dec 29, 2023

@akinwale, @mallenexpensify, @lanitochka17 Huh... This is 4 days overdue. Who can take care of this?

Copy link

melvin-bot bot commented Jan 2, 2024

@akinwale, @mallenexpensify, @lanitochka17 Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

@mallenexpensify
Copy link
Contributor

Posted in #engineering to see about getting help
https://expensify.slack.com/archives/C03SSAQ7P/p1704246905372709

@melvin-bot melvin-bot bot removed the Overdue label Jan 3, 2024
@aldo-expensify aldo-expensify self-assigned this Jan 3, 2024
@aldo-expensify
Copy link
Contributor

I'll give it a try!

@aldo-expensify
Copy link
Contributor

Tried to reproduce by:

  1. Create collect workspace with policy expense chats enabled
  2. Invited employee
  3. Created expense (which automatically created report) in OldDot using employee account
  4. Logged in on NewDot using employee account and deleted the transaction

No error seen. Can we have more clear reproduction steps?

@mallenexpensify
Copy link
Contributor

@lanitochka17 can you please retest and, if you're able to reproduce, can you please share new reproduction steps that you use? Thx

@melvin-bot melvin-bot bot added the Overdue label Jan 8, 2024
Copy link

melvin-bot bot commented Jan 8, 2024

@akinwale, @mallenexpensify, @lanitochka17, @aldo-expensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

@mallenexpensify
Copy link
Contributor

mallenexpensify commented Jan 10, 2024

Unable to reproduce on Android/chrome via Browserstack (Which looked like the vid in the OP) and Aldo wasn't able to either, so closing this 😌

Copy link

melvin-bot bot commented Jan 10, 2024

@mallenexpensify @aldo-expensify Be sure to fill out the Contact List!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Hot Pick Ready for an engineer to pick up and run with Internal Requires API changes or must be handled by Expensify staff
Projects
No open projects
Development

No branches or pull requests

5 participants