-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2023-10-24] Rename Send message
to Start chat
everyone in app
#29040
Comments
Current assignee @JmillsExpensify is eligible for the NewFeature assigner, not assigning anyone new. |
Job added to Upwork: https://www.upwork.com/jobs/~013e28f484f82e9774 |
Triggered auto assignment to Contributor Plus for review of internal employee PR - @aimane-chnaif ( |
Hmm, looks like the automation failed for this one, right? |
Payment summary: $500 to @aimane-chnaif for PR testing and review. |
Edit: I misspoke, this hasn't reached production yet. |
Send message
to Start chat
everyone in appSend message
to Start chat
everyone in app
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.85-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2023-10-24. 🎊 After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
|
Payment summary above still applies, though @aimane-chnaif mind commenting on the regression test? I think we should be fine updating QA that the name has changed, though curious for your thoughts. |
P.S. Offer sent via Upwork. |
Agree. I believe there should be test case somewhere to verify that "Send message" is in FAB menu. |
Awesome, all paid out. I've also updated QA on the name change. |
Per this internal conversation, we're going to add
Send money
back into the product shortly. At that point we'll have the following in the global creation flow.Send message
Request money
Send money
Assign task
Save the world
That's not terrible but it's more repetition than I'd like. Accordingly, let's update
Send message
toStart chat
instead (and not just for global create, but also the first page in theSend chat
route.Keeping this internal and will assign to @techievivek since he's already started on a PR.
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: