-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Hold for payment 2024-03-06] [$500] Workspace-The archived task report is no longer archived after reopening the report. #29049
Comments
Job added to Upwork: https://www.upwork.com/jobs/~019a5d1f4f0cd37991 |
Triggered auto assignment to @muttmuure ( |
Bug0 Triage Checklist (Main S/O)
|
Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr ( |
ProposalPlease re-state the problem that we are trying to solve in this issue.Tasks that belong to an archived task report are still able to be completed/reopened What is the root cause of that problem?This actually seems to be a backend issue. This is evident due to the data coming from the API from the openReport call containing the property: What changes do you think we should make in order to solve the problem?Backend code needs to be checked for bugs regarding the calculation of the isDeletedParentAction prop in the context of an archived workspace. If a patch for the frontend is needed in the meantime, a line could be added to |
ProposalPlease re-state the problem that we are trying to solve in this issue.The task report action in archived announce room is interactable and the task report is no longer archived after reopen the report What is the root cause of that problem?When we delete a workspace, we set the archived state of related reports here App/src/libs/actions/Policy.js Lines 93 to 102 in 389d7b0
Task report is marked as archived as well. But when we reopen the task report, the backend returns state: 0, status: 0 again and so the task report returns to the normal state. This is one reason
After the workspace is deleted, we should disable the interaction of tasks. We disable the task using the below function Lines 889 to 903 in 389d7b0
As you can see, we don't check if the parent report is an archived room. This is another reason What changes do you think we should make in order to solve the problem?This issue requires both the backend and frontend fixes
This works as expected What alternative solutions did you explore? (Optional) |
Asking the internal team for the expected behavior of the task report when the parent report is archived. |
Did you find anything out @mollfpr ? |
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸 |
Not overdue, still no update on the thread, I'll bump it once again. |
Bumping the Slack again to get some help. @s-alves10 For the |
I think we need to confirm the expected behavior.
Yes, you're right. But the status is changed after opening the report because backend returns |
I've got feedback, and the task report should behave as the nested thread works. So, even if the parent report is archived, the task report is still
The thread report status should not be changed on deleting the workspace.
@muttmuure Could you confirm if the above expectation is still needed? For me, it does not make sense, because the task report is still
We can remove this expected result. The only thing we can do in this issue is, fix the LHN showing that the task report is archived after deleting the workspace. @muttmuure Let me know what you think from the above. Thank you! |
@mollfpr @muttmuure this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks! |
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸 |
@mollfpr, @muttmuure Huh... This is 4 days overdue. Who can take care of this? |
@mollfpr, @muttmuure Still overdue 6 days?! Let's take care of this! |
The PR went through the first round of reviews. I'm going to do a bit more manually testing and make sure the proper updates are pushed to users, then put it up for review again soon. |
This issue has not been updated in over 15 days. @pecanoro, @mollfpr, @neil-marcellini, @muttmuure, @s-alves10 eroding to Monthly issue. P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do! |
This should be fixed now. @muttmuure would you please verify if it's fixed and let us know if anything else is needed? |
@mollfpr @muttmuure |
Automation looks not working. Pay day would be 6th, Mar here |
Seems like this is fixed, issuing payment now |
Sent new offer to @mollfpr since the original offer expired |
@s-alves10 has been paid |
No offending PR was found. This is an improvement and need a backend change to fix the issue both ways.
The regression step should be good.
@muttmuure I'll request in NewDot. Could you create the payment summary? Thank you! |
$500 - @mollfpr C+ |
$500 approved for @mollfpr based on summary. |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Action Performed:
Expected Result:
In archived WS-announce room, user must not be able to tick the task and interact.
The archived task report must remain archived after reopening the report also.
Actual Result:
In archived WS-announce room, user able to tick the task and interact.
The archived task report is no longer archived after reopening the report.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Version Number: 1.3.79-3
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Bug6228480_1696662427683.ree.mp4
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation: @
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @muttmuureThe text was updated successfully, but these errors were encountered: