[PAID] [$500] Back from request money details page does not open request money page

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Open the app
2. Open any report with request money IOU message
3. Click on request money IOU message
4. Click in header, it will open details page
5. Copy the URL and logout
6. Paste URL and login
7. On details page, click back and observe that now app does not display report for which we had opened details page

Expected Result:

App should display report for which details page is opened in background if we login with details page URL

Actual Result:

App does not display report for which details page is opened in background if we login with details page URL

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native -not testable
• Android / Chrome
• iOS / native -not testable
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop -not testable

Version Number: 1.3.78.3
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

ios.safari.does.not.open.same.chat.in.background.mp4

mac.chrome.does.not.open.same.chat.in.background.mov

windows.chrome.same.chat.not.open.in.background.mp4

android.chrome.same.report.not.displayed.in.background.mp4

Recording.4892.mp4

Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1696668016454099

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0119568c805cf99a1b
• Upwork Job ID: 1710737969784868864
• Last Price Increase: 2023-10-07
• Automatic offers:
• tienifr | Contributor | 27131905
• Dhanashree-Sawant | Reporter | 27131908

Issue Owner

Current Issue Owner: @burczu

[melvin-bot]

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0119568c805cf99a1b

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @burczu (External)

[abzokhattab]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Request money page is not opened on Back from request money details page

What is the root cause of that problem?

In the HeaderWithBackButton of the ReportDetailsPage we dont specify a route for the back action leaving the default bahavior of the HeaderWithBackButton .. which goes back to the home page onBackButtonPress = () => Navigation.goBack(ROUTES.HOME)

App/src/pages/ReportDetailsPage.js

Line 162 in 168e7f7

<HeaderWithBackButton title={props.translate('common.details')} />

What changes do you think we should make in order to solve the problem?

We should add onBackButtonPress prop to the HeaderWithBackButton component with the report route as the default back page:

<HeaderWithBackButton
  title={props.translate("common.details")}
  onBackButtonPress={() =>
    Navigation.goBack(ROUTES.REPORT_WITH_ID.getRoute(props.report.reportID))
  }
/>

POC:

Screen.Recording.2023-10-07.at.12.15.21.PM.mov

[tienifr]

Proposal

Please re-state the problem that we are trying to solve in this issue.

1. App does not display report for which details page is opened in background if we login with details page URL.

2. When going back it doesn't go back to the correct report in the details.

What is the root cause of that problem?

1. In large screen size, we always add the CentralPaneNavigator here to show the report screen in the background, however, we don't pass the reportID as the param, so in this case it will fallback to the last opened report (which might not be the report in the details)
2. When going back here, we're not specifying the fallback navigation to the report, so it will just dismiss the modal.

What changes do you think we should make in order to solve the problem?

1. We need to pass the report ID when adding the CentralPaneNavigator here

• Extract the reportID from the current state/url
• Pass as a params here in the CentralPaneNavigator route state that we add

const centralPaneNavigatorRoute = {
    name: NAVIGATORS.CENTRAL_PANE_NAVIGATOR,
    state: {
        routes: [
            {
                name: SCREENS.REPORT,
                params: {
                    reportID
                }
            }
        ]
    }
}

state.routes.splice(1, 0, centralPaneNavigatorRoute);

2. Add the report screen of the relevant report as the fallback route in onBackButtonPress when go back here

onBackButtonPress={() =>
    Navigation.goBack(ROUTES.REPORT_WITH_ID.getRoute(props.report.reportID))
  }

Other similar screens might have this same go back issue, we should fix similarly as well.

What alternative solutions did you explore? (Optional)

NA

[strepanier03]

Was able to repro easily. Letting this move forward naturally.

[burczu]

I've just reviewed both proposals and I like the one from @tienifr because it covers not only redirection to the appropriate report after clicking back button on the details sidebar, but also makes sure that the correct report is opened right after logging in. I think we should proceed with it.

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @francoisl, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[francoisl]

Agreed. Let's proceed with your proposal @tienifr.

[francoisl]

The Upwork automation didn't work because it looks like the Upwork Automation - Do Not Edit section had been accidentally removed. Re-added it, trying again now.

[melvin-bot]

📣 @tienifr 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.87-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: 29056 Back from request money details page does not open request money page #29268

If no regressions arise, payment will be issued on 2023-10-27. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter - @dhanashree-sawant - $50 via Upwork
• Contributor that fixed the issue - @tienifr - $500 via Upwork
• Contributor+ that helped on the issue and/or PR - @burczu - No payment, contractor

For reference, here are some details about the assignees on this issue:

• @burczu does not require payment (Contractor)
• @tienifr requires payment offer (Contributor)
• @dhanashree-sawant requires payment offer (Reporter)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@burczu] The PR that introduced the bug has been identified. Link to the PR:
• [@burczu] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@burczu] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@burczu] Determine if we should create a regression test for this bug.
• [@burczu] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@strepanier03] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[strepanier03]

@burczu - I'll close this out when we have the checklist done.

Everyone else has been paid, thank you @dhanashree-sawant and @tienifr!

[melvin-bot]

@francoisl @burczu @strepanier03 @tienifr this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ and will need to go internal. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

[strepanier03]

Just waiting on checklist stuff from @burczu then this one will be closed. All good melvin.

[strepanier03]

@burczu - bump on the checklist so we can get this closed out.

[melvin-bot]

@francoisl, @burczu, @strepanier03, @tienifr Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@francoisl @burczu @strepanier03 @tienifr this issue is now 4 weeks old and preventing us from maintaining WAQ, can you:

• Decide whether any proposals currently meet our guidelines and can be approved as-is today
• If no proposals meet that standard, please take this issue internal and treat it as one of your highest priorities
• If you have any questions, don't hesitate to start a discussion in #expensify-open-source

Thanks!

[melvin-bot]

Current assignee @burczu is eligible for the Internal assigner, not assigning anyone new.

[strepanier03]

@burczu - Please take care of the checklist so we can close this out.

[melvin-bot]

@francoisl, @burczu, @strepanier03, @tienifr Still overdue 6 days?! Let's take care of this!

[francoisl]

Doesn't seem like this came from a regression, also probably no need for a new regression test, going to close.