[$500] Dev: LHN - Border color around profile pic is different in LHN

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Create a group
2. Click on the group and verify border color around profile pic in LHN

Expected Result:

Border color is different

Actual Result:

Border color should not be different

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: Dev 1.3.79.3
Reproducible in staging?: n
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

RPReplay_Final1696655902.MP4

Screen_Recording_20231007_104615_New.Expensify.Dev.mp4

Screen_Recording_20231007_104703_Chrome.mp4

Screen.Recording.2023-10-07.at.10.34.04.AM.mov

Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1696655745191809

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01092e70102b992daf
• Upwork Job ID: 1711339977280749568
• Last Price Increase: 2023-10-09

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01092e70102b992daf

[saranshbalyan-1234]

Proposal

Please re-state the problem that we are trying to solve in this issue.

border color around focused profile pic is different in LHN

What is the root cause of that problem?

The problem is in the secondaryAvatarStyle being passed to the MultipleAvatars component.

App/src/components/LHNOptionsList/OptionRowLHN.js

Lines 209 to 219 in 389d7b0

	<MultipleAvatars
	icons={optionItem.icons}
	isFocusMode={props.viewMode === CONST.OPTION_MODE.COMPACT}
	size={props.viewMode === CONST.OPTION_MODE.COMPACT ? CONST.AVATAR_SIZE.SMALL : CONST.AVATAR_SIZE.DEFAULT}
	secondAvatarStyle={[
	StyleUtils.getBackgroundAndBorderStyle(themeColors.sidebar),
	props.isFocused ? StyleUtils.getBackgroundAndBorderStyle(focusedBackgroundColor) : undefined,
	hovered && !props.isFocused ? StyleUtils.getBackgroundAndBorderStyle(hoveredBackgroundColor) : undefined,
	]}
	shouldShowTooltip={OptionsListUtils.shouldOptionShowTooltip(optionItem)}
	/>

When focused we are passing focusedBackgroundColor which is different from the activeComponentBG color

What changes do you think we should make in order to solve the problem?

instead of focusedBackgroundColor we should pass activeComponentBG
Result

What alternative solutions did you explore? (Optional)

We can also change the value of styles.sidebarLinkActiveLHN.backgroundColor to themeColors.activeComponentBG's values

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (External)

[PiyushChandra17]

Proposal

Please re-state the problem that we are trying to solve in this issue.

LHN - Border color around profile pic is different in LHN

What is the root cause of that problem?

We are using themeColors.sidebar here,

App/src/components/LHNOptionsList/OptionRowLHN.js

Line 214 in 619aee6

StyleUtils.getBackgroundAndBorderStyle(themeColors.sidebar),

What changes do you think we should make in order to solve the problem?

We need to replace themeColors.sidebar with themeColors.appBG,

StyleUtils.getBackgroundAndBorderStyle(themeColors.appBG),

What alternative solutions did you explore? (Optional)

NA

Result:

[ishpaul777]

this can be fixed with #29058

[Santhosh-Sellavel]

@saranshbalyan-1234's proposals LGTM!
C+ Reviewed
🎀 👀 🎀

[melvin-bot]

Triggered auto assignment to @grgia, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[saranshbalyan-1234]

Hi @grgia friendly bump for review

[grgia]

@Santhosh-Sellavel this seems like a recent regression, have we determined if a recent PR caused this and the author should fix it?

[ishpaul777]

Not sure but looks like a regression from #28277, styling issues from #28277 are consolidated in #29057 and being taken care of in #29428 cc @hayata-suenaga

[saranshbalyan-1234]

Nope,I checked and this won't take care of this scenario at all

[hayata-suenaga]

I feel like I remember we talked about this as a regression. Checking in the consolidated issue

[hayata-suenaga]

@Santhosh-Sellavel please check the linked consolidated issue and let the Bug Zero team know if we should close this issue

[melvin-bot]

@grgia, @Santhosh-Sellavel Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[Santhosh-Sellavel]

I guess we can close this one, as it is being handled as part of #29057

[hayata-suenaga]

sorry I thought I was assigned to this issue 😓 @grgia please open the issue if you feel like it needs some more work