-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD] [$500] Chat - 'task for' task copy words not translated on copy #29082
Comments
ProposalPlease re-state the problem we are trying to solve:'task for' task copy words not translated on copy What is the root cause of this problem?The root cause is that the task message is hard coded here: Line 924 in e0ab038
Moreover, currently how we handle the copying of the right text for task report action is completely different from the way we handle the copying of actions like an
But for things like IOU and reportPreview we are using the if-else ladder with their util functions.
This is actually related to #29035 and a proposal for that issue will interfere with this one. According to the expected changes in that issue, mentioned in this proposal, a What changes should be made to fix this?We should first put this issue on hold for #29035 and then if the expected changes are to be made in the that issue, the following changes can be made here: First Lines 1562 to 1564 in e0ab038
under task.messages we can create a new created field:
created: ({taskTitle}: TaskCreatedActionParams) => `task for ${taskTitle}`, same can be done for spanish Second } else if (ReportActionsUtils.isCreatedTaskReportAction(reportAction)) {
const taskTitle = TaskUtils.getTaskTitle(reportAction.childReportID, reportAction.childReportName);
const translatedMessage = Localize.translateLocal('task.messages.created', {taskTitle});
Clipboard.setString(translatedMessage);
} Third Line 73 in e0ab038
|
ProposalPlease re-state the problem that we are trying to solve in this issue.The phrase What is the root cause of that problem?We hardcoded the English phrase here Line 924 in 389d7b0
so changing language still returns the same English phrase What changes do you think we should make in order to solve the problem?We should add a key like What alternative solutions did you explore? (Optional)Result |
Job added to Upwork: https://www.upwork.com/jobs/~01d104553451987e6f |
Triggered auto assignment to @isabelastisser ( |
Bug0 Triage Checklist (Main S/O)
|
ProposalPlease re-state the problem that we are trying to solve in this issue.'task for' task copy words not translated on copy What is the root cause of that problem?We have hardcoded 'task for' here Line 924 in 389d7b0
What changes do you think we should make in order to solve the problem?In order to avoid this, move this to es.ts and en.ts here Lines 1556 to 1557 in 389d7b0
and use the translation like this return `${Localize.translateLocal('task.messages.taskFor')} ${report.reportName}`; What alternative solutions did you explore? (Optional)N/A |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @burczu ( |
same RC as this post which was decided not to be fixed, if it will be fixed I think it's fair to re-open that post. |
We have hardcoded text in this case, not sure if it was same in that issue too. |
All text in the app except for errors and user input is hardcoded, It's the same thing in both posts, at the moment we are not supporting back-end localization for these and in the post I linked it was decided to put all related issues on hold until a back-end localization is introduced because they didn't want a front-end workaround. |
I don't agree with @AmjedNazzal that this is related to the lack of localization on the backend side. The text we use here is indeed hardcoded and it shouldn't be. But I agree with the statement from the @aswin-s's proposal:
That's why I agree we should put this on hold until the mentioned issue is resolved and then check if the issue still occurs. |
@burczu I get it that on the surfice this issue looks unrelated to the one I referenced because this is about a text being hardcoded directly inline but when you look at the bigger picture this is also about language changes and task messages, if you were to solve this without using Localize then you would still get only English text out of task.messages.taskFor, so for it to become Spanish you need Localize.translateLocal for task messages which in the post I've referenced they closed the post because they prefer waiting for back-end localization. Do you see what I'm saying? |
@burczu, @isabelastisser Eep! 4 days overdue now. Issues have feelings too... |
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸 |
Bump @burczu , can you please follow up? Thanks! |
@isabelastisser I think we should put this one on hold, because this issue could fix it (it waits for some BE changes now). |
Waiting for this issue to be fixed. If this persists after, please reopen. Thanks! |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Action Performed:
Expected Result:
App should translate client side set text on change in language
Actual Result:
App does not translate 'task for' text set client side for task message on copy to clipboard of task message
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Version Number: 1.3.79.3
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
android.native.task.for.text.not.translated.mov
Recording.4893.mp4
mac.chrome.desktop.task.copy.not.translated.mov
android.chrome.task.copy.not.translated.mp4
ios.safari.native.task.copy.not.translated.mp4
windows.chrome.task.message.not.translated.on.copy.mp4
Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1696669199917159
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: