Fix: Keyboard shouldn't be active/enabled automatically for request details #29086

Pujan92 · 2023-10-09T12:38:29Z

Details

#26702
Fix again due to false revert here.

Fixed Issues

$ #26702
PROPOSAL: #26702 (comment)

Tests

Create a money request if does not exist any
Navigate to that money request details report(which is an empty chat)
On a native, Verify that the composer input does not get focused for

Verify that no errors appear in the JS console

Offline tests

Create a money request if does not exist any
Navigate to that money request details report(which is an empty chat)
On a native, Verify that the composer input does not get focused

QA Steps

Create a money request if does not exist any
Navigate to that money request details report(which is an empty chat)
On a native, Verify that the composer input does not get focused

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-09-07.at.18.07.30.mov

Mobile Web - Chrome

p2.mp4

Mobile Web - Safari

Simulator.Screen.Recording.-.iPhone.11.-.2023-09-07.at.18.19.17.mp4

Desktop

iOS

Simulator.Screen.Recording.-.iPhone.11.-.2023-09-07.at.18.02.35.mp4

Android

p1.mp4

melvin-bot · 2023-10-09T12:38:35Z

@allroundexperts Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

allroundexperts · 2023-10-09T17:02:12Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-09-08.at.4.26.27.AM.mov

Mobile Web - Chrome

Screen.Recording.2023-09-08.at.4.29.10.AM.mov

Mobile Web - Safari

Screen.Recording.2023-09-08.at.4.27.27.AM.mov

Desktop

Screen.Recording.2023-09-08.at.4.34.34.AM.mov

iOS

Screen.Recording.2023-09-08.at.4.27.56.AM.mov

Android

Screen.Recording.2023-09-08.at.4.34.34.AM.mov

srikarparsi · 2023-10-09T22:55:25Z

Hi! Is this no longer able to be reproduced?

allroundexperts · 2023-10-09T22:56:24Z

Hi! Is this no longer able to be reproduced?

@srikarparsi This bug was supposed to be fixed on native platforms only.

srikarparsi · 2023-10-09T23:00:44Z

Could you point me to where it says that? The original video has a recording of mobile web safari.

Pujan92 · 2023-10-10T13:45:45Z

I see in the video from the testing team that it is not focusing on the mount of the component but input gets focused when we refocus to the screen based on this logic. Only for natives, we are not refocusing but for rest we are refocusing bcoz of the willBlurTextInputOnTapOutside value. As that is the generic logic, I am not sure whether we should handle that scenario for mWeb separately or not.

App/src/pages/home/report/ReportActionCompose/ComposerWithSuggestions.js

Lines 474 to 482 in 477c630

    
               // We want to focus or refocus the input when a modal has been closed or the underlying screen is refocused. 
        
               // We avoid doing this on native platforms since the software keyboard popping 
        
               // open creates a jarring and broken UX. 
        
               if (!(willBlurTextInputOnTapOutside && !isNextModalWillOpenRef.current && !modal.isVisible && isFocused && (prevIsModalVisible || !prevIsFocused))) { 
        
                   return; 
        
               } 
        
               focus(); 
        
           }, [focus, prevIsFocused, prevIsModalVisible, isFocused, modal.isVisible, isNextModalWillOpenRef]);

b1.mp4

srikarparsi · 2023-10-16T08:45:36Z

hey, will take a look into this tomorrow

srikarparsi · 2023-10-16T18:14:48Z

Hm, so I believe for all platforms, we should only "refocus" the keyboard once the modal is closed if the keyboard was originally focussed. @allroundexperts what do you think?

srikarparsi · 2023-10-18T02:01:19Z

bump @allroundexperts

allroundexperts · 2023-10-18T11:36:14Z

@srikarparsi Ideally, it should work on all platforms. However, mweb seems to be very tricky. There's a lot of discussion about autofocus logic for mweb available in Slack as well.

srikarparsi · 2023-10-19T23:33:19Z

Got it @allroundexperts do you think you could point me to the discussions in slack when you have a chance? Also @JmillsExpensify what do you think about this functionality not working perfectly as a part of this fix because of this bug

allroundexperts · 2023-10-23T15:34:27Z

@srikarparsi
https://expensify.slack.com/archives/C01GTK53T8Q/p1690541593950499?thread_ts=1690436091.795379&cid=C01GTK53T8Q
https://expensify.slack.com/archives/C01GTK53T8Q/p1686719220937549?thread_ts=1686684947.789839&cid=C01GTK53T8Q
https://expensify.slack.com/archives/C01GTK53T8Q/p1696938590012619

srikarparsi · 2023-10-24T18:03:26Z

Got it, thanks @allroundexperts! This looks good to me then

OSBotify · 2023-10-24T18:11:28Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-10-25T17:00:20Z

🚀 Deployed to staging by https://github.com/srikarparsi in version: 1.3.91-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-10-26T22:42:21Z

🚀 Deployed to production by https://github.com/marcaaron in version: 1.3.91-8 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

rojiphil · 2024-11-11T14:19:41Z

src/pages/home/report/ReportActionCompose/ComposerWithSuggestions.js

@@ -110,7 +110,8 @@ function ComposerWithSuggestions({
    const maxComposerLines = isSmallScreenWidth ? CONST.COMPOSER.MAX_LINES_SMALL_SCREEN : CONST.COMPOSER.MAX_LINES;

    const isEmptyChat = useMemo(() => _.size(reportActions) === 1, [reportActions]);
-    const shouldAutoFocus = !modal.isVisible && (shouldFocusInputOnScreenFocus || isEmptyChat) && shouldShowComposeInput;
+    const parentAction = ReportActionsUtils.getParentReportAction(report);
+    const shouldAutoFocus = !modal.isVisible && (shouldFocusInputOnScreenFocus || (isEmptyChat && !ReportActionsUtils.isTransactionThread(parentAction))) && shouldShowComposeInput;


Probably a design issue as we did not notice that the keyboard display on mobile platforms would cover the task description and cause UX issue #50346

prevent auto focus for transaction thread empty chat

a9f71a4

Pujan92 requested a review from a team as a code owner October 9, 2023 12:38

melvin-bot bot requested review from allroundexperts and removed request for a team October 9, 2023 12:38

Pujan92 mentioned this pull request Oct 9, 2023

[SMARTSCAN] [HOLD for payment 2023-11-02] [$500] LOW: Keyboard shouldn't be active/enabled automatically for request details #26702

Closed

allroundexperts approved these changes Oct 9, 2023

View reviewed changes

melvin-bot bot requested a review from srikarparsi October 9, 2023 17:02

srikarparsi approved these changes Oct 24, 2023

View reviewed changes

srikarparsi merged commit 3380266 into Expensify:main Oct 24, 2023
13 checks passed

OSBotify mentioned this pull request Oct 25, 2023

Deploy Checklist: New Expensify 2023-10-25 #30365

Closed

99 tasks

DylanDylann mentioned this pull request Sep 12, 2024

fix: 10731 Focus composer without showing keyboard when users go to chats #32711

Merged

56 tasks

rojiphil reviewed Nov 11, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix: Keyboard shouldn't be active/enabled automatically for request details #29086

Fix: Keyboard shouldn't be active/enabled automatically for request details #29086

Pujan92 commented Oct 9, 2023

melvin-bot bot commented Oct 9, 2023

allroundexperts commented Oct 9, 2023

srikarparsi commented Oct 9, 2023

allroundexperts commented Oct 9, 2023

srikarparsi commented Oct 9, 2023

Pujan92 commented Oct 10, 2023 •

edited

Loading

srikarparsi commented Oct 16, 2023

srikarparsi commented Oct 16, 2023

srikarparsi commented Oct 18, 2023

allroundexperts commented Oct 18, 2023

srikarparsi commented Oct 19, 2023

allroundexperts commented Oct 23, 2023

srikarparsi commented Oct 24, 2023

OSBotify commented Oct 24, 2023

OSBotify commented Oct 25, 2023

OSBotify commented Oct 26, 2023

rojiphil Nov 11, 2024

Fix: Keyboard shouldn't be active/enabled automatically for request details #29086

Fix: Keyboard shouldn't be active/enabled automatically for request details #29086

Conversation

Pujan92 commented Oct 9, 2023

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Oct 9, 2023

allroundexperts commented Oct 9, 2023

Reviewer Checklist

Screenshots/Videos

srikarparsi commented Oct 9, 2023

allroundexperts commented Oct 9, 2023

srikarparsi commented Oct 9, 2023

Pujan92 commented Oct 10, 2023 • edited Loading

srikarparsi commented Oct 16, 2023

srikarparsi commented Oct 16, 2023

srikarparsi commented Oct 18, 2023

allroundexperts commented Oct 18, 2023

srikarparsi commented Oct 19, 2023

allroundexperts commented Oct 23, 2023

srikarparsi commented Oct 24, 2023

OSBotify commented Oct 24, 2023

OSBotify commented Oct 25, 2023

OSBotify commented Oct 26, 2023

rojiphil Nov 11, 2024

Choose a reason for hiding this comment

Pujan92 commented Oct 10, 2023 •

edited

Loading