fix: money request report scroll fix #29102

allroundexperts · 2023-10-09T16:32:27Z

Details

This PR fixes the scroll which was broken on the money request report page.

Fixed Issues

$ #29038
PROPOSAL: #29038 (comment)

Tests

Click on the "+" button in LHN and Go to Request money > Distance.
Select Start and Finish points and proceed with the request.
Navigate to the distance detail page.

Verify that the page scrolls correctly

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Click on the "+" button in LHN and Go to Request money > Distance.
Select Start and Finish points and proceed with the request.
Navigate to the distance detail page.

Verify that the page scrolls correctly

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2023-10-09.at.9.20.29.PM.mov

Android: mWeb Chrome

Screen.Recording.2023-10-09.at.9.19.19.PM.mov

iOS: Native

Screen.Recording.2023-10-09.at.9.15.53.PM.mov

iOS: mWeb Safari

Screen.Recording.2023-10-09.at.9.16.47.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2023-10-09.at.9.13.52.PM.mov

MacOS: Desktop

Screen.Recording.2023-10-09.at.9.21.13.PM.mov

melvin-bot · 2023-10-09T16:32:33Z

@Ollyws Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Ollyws · 2023-10-10T10:26:41Z

@allroundexperts The changes seem to be adding some extra space above MoneyReportView:

SpaceExample.mp4

Video

allroundexperts · 2023-10-15T16:49:23Z

@Ollyws The MoneyReportView turned out to be a little tricky because the header itself is considered a report action item. I had to enable the pointer events for this case but the overall structure of code still remains consistent with other places.

Ollyws · 2023-10-17T12:45:07Z

src/pages/home/report/AnimatedEmptyStateBackground.js

@@ -41,7 +41,6 @@ function AnimatedEmptyStateBackground() {

    return (
        <Animated.Image
-            pointerEvents="none"


Why was enabling pointerEvents necessary?

@Ollyws With pointer events disabled, the scrolling would work when the height of the header is less than the height of the background image.

Ollyws · 2023-10-19T12:23:47Z

@allroundexperts Could you sort out those merge conflicts? Thanks!

allroundexperts · 2023-10-19T13:08:33Z

@Ollyws Resolved.

Ollyws · 2023-10-19T14:25:43Z

@allroundexperts Thanks.
There seems to be a small difference in height between the moneyreportview on this PR and prod.

Video

heightexample.mp4

allroundexperts · 2023-10-19T14:49:11Z

@Ollyws I think this is correct. We were inconsistent previously on the money request screens. On all other screens, the items are show after applying 275px margin from the top. For money report screens, we were applying 280px.

allroundexperts · 2023-10-19T14:49:39Z

If you feel too strongly about this though, do let me know and I can apply 5px more.

Ollyws · 2023-10-19T16:08:29Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

01_MacOS_Chrome.mp4

Mobile Web - Chrome

02_Android_Chrome.mp4

Mobile Web - Safari

03_iOS_Safari.mp4

Desktop

04_MacOS_Desktop.mp4

iOS

05_iOS_Native.mp4

Android

06_Android_Native.mp4

Ollyws

LGTM

mountiny · 2023-10-19T20:54:51Z

Whats the block on the right side here?

Same here, why is there the gray block?

allroundexperts · 2023-10-19T20:57:02Z

Whats the block on the right side here?

Same here, why is there the gray block?

@mountiny I can see a scroll bar and then console window opened on the right.

mountiny

One comment but curious about the gray block on right side for the scroll bar is that on main too?

mountiny · 2023-10-19T20:56:06Z

src/components/ReportActionItem/MoneyRequestView.js

+                {isExpensifyCardTransaction ? (
+                    <OfflineWithFeedback pendingAction={getPendingFieldAction('pendingFields.cardID')}>
+                        <MenuItemWithTopDescription
+                            description={translate('iou.card')}
+                            title={cardProgramName}
+                            titleStyle={styles.flex1}
+                            interactive={canEdit}
+                        />
+                    </OfflineWithFeedback>
+                ) : null}


Suggested change

{isExpensifyCardTransaction ? (

<OfflineWithFeedback pendingAction={getPendingFieldAction('pendingFields.cardID')}>

<MenuItemWithTopDescription

description={translate('iou.card')}

title={cardProgramName}

titleStyle={styles.flex1}

interactive={canEdit}

/>

</OfflineWithFeedback>

) : null}

{isExpensifyCardTransaction && (

<OfflineWithFeedback pendingAction={getPendingFieldAction('pendingFields.cardID')}>

<MenuItemWithTopDescription

description={translate('iou.card')}

title={cardProgramName}

titleStyle={styles.flex1}

interactive={canEdit}

/>

</OfflineWithFeedback>

)}

This pattern is prohibited as far as I can recall. This will try to render false for falsy isExpensifyCardTransaction. This in turn would cause console error on android native.

Actually I'm wrong here. This happens only when the left hand side is a string.

Will push in a sec.

allroundexperts · 2023-10-19T21:00:48Z

@mountiny On main:

Screen.Recording.2023-10-20.at.2.00.11.AM.mov

You're talking about the scroll bar block, right?

mountiny · 2023-10-19T21:12:29Z

Ah nice! I never move my mouse over that area haha

mountiny · 2023-10-19T21:13:01Z

@allroundexperts can you just address that one comment? I know its not from your changes but feels like a thing we should clean up

allroundexperts · 2023-10-19T21:13:55Z

@allroundexperts can you just address that one comment? I know its not from your changes but feels like a thing we should clean up

Replied @mountiny

allroundexperts · 2023-10-19T21:19:03Z

@mountiny Fixed.

mountiny

Thanks!

OSBotify · 2023-10-19T23:30:14Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-10-20T21:37:54Z

🚀 Deployed to staging by https://github.com/mountiny in version: 1.3.88-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-10-23T04:50:06Z

🚀 Deployed to production by https://github.com/chiragsalian in version: 1.3.88-11 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

fix: money request report scroll fix

d1add2b

allroundexperts requested a review from a team as a code owner October 9, 2023 16:32

melvin-bot bot requested review from Ollyws and removed request for a team October 9, 2023 16:32

allroundexperts mentioned this pull request Oct 9, 2023

[HOLD for payment 2023-10-31] [HOLD for payment 2023-10-30] [$500] Scroll is not working properly on the distance detail page, it sometimes gets stuck when scrolling up and down #29038

Closed

6 tasks

allroundexperts added 2 commits October 14, 2023 04:55

fix: merge with main

e04827b

fix: difference in money report screen

7459557

allroundexperts added 2 commits October 15, 2023 21:50

Merge branch 'main' into fix-29038

8c77a9f

fix: lint issues

8f79ffa

Ollyws reviewed Oct 17, 2023

View reviewed changes

allroundexperts added 2 commits October 19, 2023 17:49

feat: resolve conflicts

0e91db8

fix: resolve conflicts

17cae03

Ollyws approved these changes Oct 19, 2023

View reviewed changes

melvin-bot bot requested a review from mountiny October 19, 2023 16:09

mountiny assigned allroundexperts Oct 19, 2023

mountiny reviewed Oct 19, 2023

View reviewed changes

fix: use && instead of ternary

87055a8

mountiny approved these changes Oct 19, 2023

View reviewed changes

mountiny merged commit cb60a8b into Expensify:main Oct 19, 2023
11 checks passed

OSBotify mentioned this pull request Oct 20, 2023

Deploy Checklist: New Expensify 2023-10-20 #30108

Closed

ishpaul777 mentioned this pull request Oct 21, 2023

IOU - Total with amount line is misaligned in IOU report page #30129

Closed

6 tasks

Ollyws mentioned this pull request Oct 31, 2023

Gyroscope-driven animations of empty chats #23737

Merged

58 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: money request report scroll fix #29102

fix: money request report scroll fix #29102

allroundexperts commented Oct 9, 2023

melvin-bot bot commented Oct 9, 2023

Ollyws commented Oct 10, 2023

allroundexperts commented Oct 15, 2023

Ollyws Oct 17, 2023 •

edited

Loading

allroundexperts Oct 19, 2023

Ollyws commented Oct 19, 2023

allroundexperts commented Oct 19, 2023

Ollyws commented Oct 19, 2023 •

edited

Loading

allroundexperts commented Oct 19, 2023

allroundexperts commented Oct 19, 2023

Ollyws commented Oct 19, 2023

Ollyws left a comment

mountiny commented Oct 19, 2023

allroundexperts commented Oct 19, 2023

mountiny left a comment

mountiny Oct 19, 2023

allroundexperts Oct 19, 2023

allroundexperts Oct 19, 2023

allroundexperts Oct 19, 2023

allroundexperts commented Oct 19, 2023

mountiny commented Oct 19, 2023

mountiny commented Oct 19, 2023

allroundexperts commented Oct 19, 2023

allroundexperts commented Oct 19, 2023

mountiny left a comment

OSBotify commented Oct 19, 2023

OSBotify commented Oct 20, 2023

OSBotify commented Oct 23, 2023

fix: money request report scroll fix #29102

fix: money request report scroll fix #29102

Conversation

allroundexperts commented Oct 9, 2023

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Oct 9, 2023

Ollyws commented Oct 10, 2023

allroundexperts commented Oct 15, 2023

Ollyws Oct 17, 2023 • edited Loading

Choose a reason for hiding this comment

allroundexperts Oct 19, 2023

Choose a reason for hiding this comment

Ollyws commented Oct 19, 2023

allroundexperts commented Oct 19, 2023

Ollyws commented Oct 19, 2023 • edited Loading

allroundexperts commented Oct 19, 2023

allroundexperts commented Oct 19, 2023

Ollyws commented Oct 19, 2023

Reviewer Checklist

Screenshots/Videos

Ollyws left a comment

Choose a reason for hiding this comment

mountiny commented Oct 19, 2023

allroundexperts commented Oct 19, 2023

mountiny left a comment

Choose a reason for hiding this comment

mountiny Oct 19, 2023

Choose a reason for hiding this comment

allroundexperts Oct 19, 2023

Choose a reason for hiding this comment

allroundexperts Oct 19, 2023

Choose a reason for hiding this comment

allroundexperts Oct 19, 2023

Choose a reason for hiding this comment

allroundexperts commented Oct 19, 2023

mountiny commented Oct 19, 2023

mountiny commented Oct 19, 2023

allroundexperts commented Oct 19, 2023

allroundexperts commented Oct 19, 2023

mountiny left a comment

Choose a reason for hiding this comment

OSBotify commented Oct 19, 2023

OSBotify commented Oct 20, 2023

OSBotify commented Oct 23, 2023

Ollyws Oct 17, 2023 •

edited

Loading

Ollyws commented Oct 19, 2023 •

edited

Loading