-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Collect Approvers] Add Approve and Pay buttons by using report NextSteps #29145
Comments
Fixed more edge cases that I've found but in the frontend. Tomorrow I will run another set of local tests to prepare the PR for review. |
PR in review |
PR updated to fix https://github.com/Expensify/Expensify/issues/325515 |
I'm working on the backend PRs, more details here. |
This issue has not been updated in over 15 days. @marcochavezf eroding to Monthly issue. P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do! |
Updated the PR to follow the approach of checking the status and state of the report preview to show the Pay and Approver buttons in the workspace chats. |
PR is still in review. We're going to only test scenario 2 (non-admin approver), since we'd need to check if the admins have access to the VBBA. |
@marcochavezf Whoops! This issue is 2 days overdue. Let's get this updated quick! |
@marcochavezf 6 days overdue. This is scarier than being forced to listen to Vogon poetry! |
Fixed reported bugs, PR ready for hopefully a final review 🤞🏽 |
@marcochavezf Whoops! This issue is 2 days overdue. Let's get this updated quick! |
Please assign me here as C+ |
@marcochavezf Eep! 4 days overdue now. Issues have feelings too... |
@marcochavezf Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it! |
Triggered auto assignment to @dylanexpensify ( |
Hi @dylanexpensify, could you handle the payment for @shubham1206agra for #28976? 🙇🏽 |
Yes, will do! |
@shubham1206agra please apply here! |
Applied |
Ok, I think we can close it out. Thanks! Also, the PR hit production last week |
On hold for https://github.com/Expensify/Expensify/issues/323548On hold now for https://github.com/Expensify/Web-Expensify/pull/39328Coming from this internal discussion, we're going to use the report NextSteps data from OldDot to render the Approve or Pay button for collect policies according to the user.
Additionally, we want to render the "approved" message in the corresponding places listed in the HL, like in the report header, report preview and the expense report.
The text was updated successfully, but these errors were encountered: