Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Collect Approvers] Add Approve and Pay buttons by using report NextSteps #29145

Closed
marcochavezf opened this issue Oct 10, 2023 · 20 comments
Closed
Assignees
Labels
Engineering NewFeature Something to build that is a new item. Reviewing Has a PR in review Weekly KSv2

Comments

@marcochavezf
Copy link
Contributor

marcochavezf commented Oct 10, 2023

On hold for https://github.com/Expensify/Expensify/issues/323548
On hold now for https://github.com/Expensify/Web-Expensify/pull/39328

Coming from this internal discussion, we're going to use the report NextSteps data from OldDot to render the Approve or Pay button for collect policies according to the user.

Additionally, we want to render the "approved" message in the corresponding places listed in the HL, like in the report header, report preview and the expense report.

@marcochavezf
Copy link
Contributor Author

Fixed more edge cases that I've found but in the frontend. Tomorrow I will run another set of local tests to prepare the PR for review.

@marcochavezf marcochavezf changed the title [HOLD][Collect Approvers] Add Approve and Pay buttons by using report NextSteps [Collect Approvers] Add Approve and Pay buttons by using report NextSteps Oct 11, 2023
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Oct 12, 2023
@marcochavezf
Copy link
Contributor Author

PR in review

@marcochavezf
Copy link
Contributor Author

@marcochavezf
Copy link
Contributor Author

I'm working on the backend PRs, more details here.

@marcochavezf marcochavezf changed the title [Collect Approvers] Add Approve and Pay buttons by using report NextSteps [HOLD Web-E #39328][Collect Approvers] Add Approve and Pay buttons by using report NextSteps Oct 24, 2023
@marcochavezf marcochavezf changed the title [HOLD Web-E #39328][Collect Approvers] Add Approve and Pay buttons by using report NextSteps [Collect Approvers] Add Approve and Pay buttons by using report NextSteps Nov 13, 2023
@melvin-bot melvin-bot bot added Monthly KSv2 and removed Weekly KSv2 labels Nov 20, 2023
Copy link

melvin-bot bot commented Nov 20, 2023

This issue has not been updated in over 15 days. @marcochavezf eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@marcochavezf
Copy link
Contributor Author

Updated the PR to follow the approach of checking the status and state of the report preview to show the Pay and Approver buttons in the workspace chats.

@marcochavezf
Copy link
Contributor Author

PR is still in review. We're going to only test scenario 2 (non-admin approver), since we'd need to check if the admins have access to the VBBA.

@marcochavezf marcochavezf added Daily KSv2 and removed Monthly KSv2 labels Nov 23, 2023
Copy link

melvin-bot bot commented Nov 30, 2023

@marcochavezf Whoops! This issue is 2 days overdue. Let's get this updated quick!

Copy link

melvin-bot bot commented Dec 4, 2023

@marcochavezf 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

@marcochavezf
Copy link
Contributor Author

Fixed reported bugs, PR ready for hopefully a final review 🤞🏽

Copy link

melvin-bot bot commented Dec 12, 2023

@marcochavezf Whoops! This issue is 2 days overdue. Let's get this updated quick!

@shubham1206agra
Copy link
Contributor

Please assign me here as C+

Copy link

melvin-bot bot commented Dec 14, 2023

@marcochavezf Eep! 4 days overdue now. Issues have feelings too...

Copy link

melvin-bot bot commented Dec 18, 2023

@marcochavezf Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

@marcochavezf marcochavezf added the NewFeature Something to build that is a new item. label Dec 20, 2023
Copy link

melvin-bot bot commented Dec 20, 2023

@marcochavezf
Copy link
Contributor Author

Hi @dylanexpensify, could you handle the payment for @shubham1206agra for #28976? 🙇🏽

@dylanexpensify
Copy link
Contributor

Yes, will do!

@dylanexpensify
Copy link
Contributor

@shubham1206agra please apply here!

@shubham1206agra
Copy link
Contributor

Applied

@marcochavezf
Copy link
Contributor Author

marcochavezf commented Dec 21, 2023

Ok, I think we can close it out. Thanks! Also, the PR hit production last week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engineering NewFeature Something to build that is a new item. Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Development

No branches or pull requests

3 participants