[HOLD for payment 2023-10-31] [$500] Chat - The New Line Marker does not appear for unread first message

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.3.79.3
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @daveSeife
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1696727757953619

Action Performed:

1. Send a message to User A, with no previous chat history with the sender.
2. Go to User A and notice the LHN is highlighted
3. Open the chat. Notice there is no New Line marker

Expected Result:

The New Line Marker appears for unread message

Actual Result:

The New Line Marker does not appear for unread first message

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Android: Native

XRecorder_08102023_040857.mp4

Android: mWeb Chrome

XRecorder_08102023_040652.mp4

iOS: Native

RPReplay_Final1696884715.MP4

iOS: mWeb Safari

RPReplay_Final1696885099.MP4

crashed

MacOS: Chrome / Safari

T156macchrome.Newline-1.mp4

MacOS: Desktop

T156macdes.Newline-1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01cc658e3dfbf9bd3b
• Upwork Job ID: 1711711928838750208
• Last Price Increase: 2023-10-10
• Automatic offers:
• chamysoftware | Contributor | 27163409
• daveSeife | Reporter | 27163410

[melvin-bot]

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01cc658e3dfbf9bd3b

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @narefyev91 (External)

[chamysoftware]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When userA receives a message from userB for the first time, the new message marker is missing.

What is the root cause of that problem?

We're checking if the report action is unread based on the report's last read time here

App/src/pages/home/report/ReportActionsList.js

Lines 99 to 101 in 424786b

	function isMessageUnread(message, lastReadTime) {
	return Boolean(message && lastReadTime && message.created && lastReadTime < message.created);
	}

But the last read time is undefined for a new report (new message coming from a new sender).

What changes do you think we should make in order to solve the problem?

We need to handle this case in the above function. We need to consider it as a new message in case if the report's lastReadTime is undefined

  100 function isMessageUnread(message, lastReadTime) {
+ 101    if (!lastReadTime) {
+ 102       return Boolean(!isCreatedAction(message));
+ 103    }
+ 104 
  105    return Boolean(message && lastReadTime && message.created && lastReadTime < message.created);
  106 }

What alternative solutions did you explore? (Optional)

NA

[narefyev91]

Proposal from @chamysoftware looks good to me #29173 (comment)
Just let's to be sure that fix will work with all other flows - like unread message, new messages in task and etc
🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @srikarparsi, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[srikarparsi]

Cool, looks good to me as well

[melvin-bot]

📣 @chamysoftware 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

📣 @daveSeife 🎉 An offer has been automatically sent to your Upwork account for the Reporter role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

@JmillsExpensify, @narefyev91, @srikarparsi, @chamysoftware Whoops! This issue is 2 days overdue. Let's get this updated quick!

[JmillsExpensify]

Still working through the PR

[melvin-bot]

Based on my calculations, the pull request did not get merged within 3 working days of assignment. Please, check out my computations here:

• when @chamysoftware got assigned: 2023-10-12 16:30:59 Z
• when the PR got merged: 2023-10-21 23:32:32 UTC
• days elapsed: 6

On to the next one 🚀

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.89-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix#29173:Chat - The New Line Marker does not appear for unread first message #29697

If no regressions arise, payment will be issued on 2023-10-31. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @narefyev91 does not require payment (Contractor)
• @chamysoftware requires payment offer (Contributor)
• @daveSeife requires payment offer (Reporter)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@narefyev91] The PR that introduced the bug has been identified. Link to the PR:
• [@narefyev91] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@narefyev91] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@narefyev91] Determine if we should create a regression test for this bug.
• [@narefyev91] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@JmillsExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[JmillsExpensify]

@narefyev91 mind kicking off the BZ checklist? In the meantime, payment summary as follows:

• Issue reporter: @daveSeife $50
• Contributor: @chamysoftware $500

[narefyev91]

• The PR that introduced the bug has been identified. Link to the PR - it was not a regression - just missing functionality
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment - N/A
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion - N/A
• Determine if we should create a regression test for this bug - N/A

[JmillsExpensify]

Thanks for that! I'll get started on the payments now.

[JmillsExpensify]

Everyone should be paid out now! Closing since no regression test is required.