[HOLD for payment 2023-11-22] [$500] Chat - App does not replace # on selection of mention

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.3.79.3
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1696496817615989

Action Performed:

Precondition: User should know a user with # in display name

1. Open the app
2. Open any report
3. Write '@#' and select the user in result
4. Observe that app does not replace # with result

Expected Result:

On selecting user from mention result, app should replace search term with result

Actual Result:

On selecting user from mention result, app does not replace search term with result if term is '#'

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Android: Native

android.native.mention.displaces.on.selection.mov

Android: mWeb Chrome

android.chrome.app.displaces.in.mention.mp4

iOS: Native

ios.safari.native.app.displaces.in.mention.mov

iOS: mWeb Safari

ios.safari.native.app.displaces.in.mention.mov

MacOS: Chrome / Safari

mac.chrome.desktop.app.displaces.in.mention.mov

MacOS: Desktop

mac.chrome.desktop.app.displaces.in.mention.mov

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0159ee5a631ff4f0b0
• Upwork Job ID: 1711736982382366720
• Last Price Increase: 2023-11-01
• Automatic offers:
• fedirjh | Reviewer | 27547155
• abzokhattab | Contributor | 27547156
• dhanashree-sawant | Reporter | 27547157

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0159ee5a631ff4f0b0

[abzokhattab]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The # is not replaced on the selection of the mention

What is the root cause of that problem?

we use the MENTION_REPLACER to get the comment after the mention, apparently, this regex terminates the matching upon encountering special characters, including "#," ,, this is declared in the SPECIAL_CHAR variable and used in MENTION_REPLACER, resulting in incomplete matches.

App/src/CONST.ts

Line 1297 in 830feaf

SPECIAL_CHAR: /[,/?"{}[\]()&^%;`$=#<>!*]/g,

App/src/CONST.ts

Lines 1314 to 1316 in 830feaf

	get MENTION_REPLACER() {
	return new RegExp(`^@[^\\n\\r]*?(?=$|\\s|${this.SPECIAL_CHAR.source}|${this.EMOJI.source})`, 'u');
	},

What changes do you think we should make in order to solve the problem?

there is no need to use the MENTION_REPLACER in deciding the comment after the mention .. instead we can use the index of the last char of suggestionValues.mentionPrefix and fetch the string after it

i think it is easier to illustrate it by providing the code changes, so we should change this:

App/src/pages/home/report/ReportActionCompose/SuggestionMention.js

Line 84 in 49bc03b

const commentAfterAtSignWithMentionRemoved = value.slice(suggestionValues.atSignIndex).replace(CONST.REGEX.MENTION_REPLACER, '');

To:

const commentAfterAtSignWithMentionRemoved = value.slice(suggestionValues.atSignIndex + suggestionValues.mentionPrefix.length + 1);

and of course, remove the MENTION_REPLACER from the const.ts file

POC:

Screen.Recording.2023-10-28.at.12.30.15.AM.mov

[melvin-bot]

Triggered auto assignment to @conorpendergrast (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)

[fedirjh]

Let's retest after #29239 is merged, as the regex structure will be changed in that PR.

[melvin-bot]

@conorpendergrast, @fedirjh Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[conorpendergrast]

Still waiting for #29239

[conorpendergrast]

PR is merged, waiting for it to be on Staging

[conorpendergrast]

That PR is on Staging now (v1.3.86-0), so I retested.

This bug still exists, so I'll take it off hold!

[fedirjh]

@abzokhattab Can you please update your proposal ?

[abzokhattab]

Proposal is updated please review and let me know

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[fedirjh]

@abzokhattab The bug can be reproduced with other special characters too. For example, the bug can be replicated with one of these characters `!@#$%^&*()_+{}[]|:\"<>.?/~$€£¥₹₽₣₪₩₴₱₨₦₭₮₵, and there may be other characters that cause the same issue.

[abzokhattab]

okay I thought we wanted to cover only the hashtag, but in this case, we need to remove the SPECIAL_CHAR matching completely.. in this case, the space or the new line would be the only characters that stop the matching

POC:

[fedirjh]

we need to remove the SPECIAL_CHAR matching completely

Hmmm, there must have been a specific reason for that implementation in the past. Was it done to resolve another bug?

[melvin-bot]

@conorpendergrast @fedirjh this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[abzokhattab]

A kindly reminder on this

[fedirjh]

We are currently awaiting final approval from cc @marcochavezf.

[marcochavezf]

Thanks for the review @fedirjh, the proposed solution looks good. Assigning @abzokhattab 🚀

[melvin-bot]

📣 @fedirjh 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @abzokhattab 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

📣 @dhanashree-sawant 🎉 An offer has been automatically sent to your Upwork account for the Reporter role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[abzokhattab]

Kindly reminder, @fedirjh @conorpendergrast ... PR is ready

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.99-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Refactoring mention replacer logic #30930

If no regressions arise, payment will be issued on 2023-11-22. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @fedirjh requires payment offer (Reviewer)
• @abzokhattab requires payment offer (Contributor)
• @dhanashree-sawant requires payment offer (Reporter)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@fedirjh] The PR that introduced the bug has been identified. Link to the PR:
• [@fedirjh] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@fedirjh] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@fedirjh] Determine if we should create a regression test for this bug.
• [@fedirjh] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@conorpendergrast] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[fedirjh]

BugZero Checklist:

• Link to the PR: feat: update mention replacer regex #19004
• Link to comment: feat: update mention replacer regex #19004 (comment)
• Link to discussion: N/A Noting to add to the checklist.
• Determine if we should create a regression test for this bug: I don't think we should require a regression test for this case, we have the required regression tests for this flow, and this bug seems an extremely edge case.

[conorpendergrast]

Payouts due:

• Issue Reporter: $50 @dhanashree-sawant - offer
• Contributor+: $500 @fedirjh - offer
• Contributor: $500 @abzokhattab - offer

Upwork job is here.

[conorpendergrast]

All paid now, and I agree with you @fedirjh for the C+ checklist. Closing out!