[$500] Split Bill - 1:1 DM with attendees you split a bill with are not bolded in LHN

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.3.80-0

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

Action Performed:

1. Navigate to staging.new.expensify.com and login with any account
2. Click the FAB button and select Request Money>Manual
3. Enter an amount in BNP & tap on the next button
4. Tap on "Split" button next to few users & tap "Add to split" button

Expected Result:

There should be an unread 1:1 DM between you, and each attendee you just split a bill with

Actual Result:

1:1 DM with attendees you split a bill with are not bolded in LHN

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Android: Native

Android: mWeb Chrome

Bug6231842_1696941687635.az_recorder_20231010_115039.mp4

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Recording.192.mp4

MacOS: Desktop

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01a2019f2ea37cb259
• Upwork Job ID: 1712815168206192640
• Last Price Increase: 2023-10-13

[melvin-bot]

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[CortneyOfstad]

@lanitochka17 Is there a video or screenshots of this? Also do you have the slack link and the reporter information?

[lanitochka17]

@CortneyOfstad Did you check video linked in MacOS: Chrome / Safari above?

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01a2019f2ea37cb259

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @burczu (External)

[CortneyOfstad]

Was able to recreate so got eyes on this 👍

[tienifr]

Proposal

Please re-state the problem that we are trying to solve in this issue.

IOU report with attendees you split a bill with are bolded in LHN

What is the root cause of that problem?

We have 2 problems:

1. When users split the bill, we call API SplitBillAndOpenReport, and we have the logic to update oneOnOneIOUReport here, and we did not update the lastReadTime and lastVisibleActionCreated to currentTime, so if this report is unread before, then users make the split bill, it's still unread

App/src/libs/actions/IOU.js

Line 1086 in a2cf591

oneOnOneIOUReport = IOUUtils.updateIOUOwnerAndTotal(oneOnOneIOUReport, currentUserAccountID, splitAmount, currency);

2. BE returns incorrect lastReadTime and lastVisibleActionCreated

Screen.Recording.2023-12-07.at.16.34.36.mov

What changes do you think we should make in order to solve the problem?

1. Update lastReadTime and lastVisibleActionCreated to DateUtils.getDBTime()

        oneOnOneIOUReport.lastReadTime = currentTime;
        oneOnOneIOUReport.lastVisibleActionCreated = currentTime;

2. We need BE fix

What alternative solutions did you explore? (Optional)

This happens for other types of request as well like money request so we should fix it as well.

Result

Screen.Recording.2023-12-07.at.16.36.42.mp4

[CortneyOfstad]

@burczu any thoughts on the proposal above?

[burczu]

@CortneyOfstad I'm sorry, I was busy reviewing PR's - I'll be reviewing proposals soon.

[burczu]

I've checked the proposal from @tienifr and I think it does make sense, so I think we could proceed with it.

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @nkuoch, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[nkuoch]

@tienifr can you add some links on your proposal so we we know better on which parts of the code you intend to do your changes? Also, let's make sure we don't introduce any regression for normal DMs where they should be unread when creating them as we indeed saw them at the same time as creating them. So I guess this is specific to splits. Which makes me think in this case, do we actually want to set lastReadTime? Can't it just be empty as we didn't ever actually read those.

[nkuoch]

Also cc @trjExpensify to double check we do want to show each new split as bold when creating them.

[trjExpensify]

Hm, I don't understand this issue actually. The request is added to the chat by the creator of the request, why would the chat then be unread for them for their own action?

The chat would be unread for the recipient of the request, but I don't think it would be unread for the creator of the request.

[nkuoch]

yes I kind of agree with you too @trjExpensify .

From the video in the PR description under MacOS: Chrome / Safari, I do see 1 of the splits shows as unread though? So maybe the fix would be just to have them all consistent, all showing as read?

[trjExpensify]

Oh yeah, nice eye. Yup, I agree. Unread for the recipient, read for the creator. 👍

[CortneyOfstad]

I am heading OoO until Oct. 25, so reassigning BZ to have someone keep an eye on things while I am gone 👍

[burczu]

@CortneyOfstad I'm not sure what is the final conclusion here - are we leaving this as is as @puneetlath suggested, are we leave it to be done while working on wave6 along with expenses, or do we want to fix splits and expenses here in this issue?

[melvin-bot]

@nkuoch, @burczu, @CortneyOfstad Still overdue 6 days?! Let's take care of this!

[CortneyOfstad]

@burczu my thought is that if wave 6 is not going to fix this, we should fix it now in this issue. @nkuoch does that work for you as well?

[melvin-bot]

@nkuoch, @burczu, @CortneyOfstad Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[CortneyOfstad]

@burczu any updates on this? Thanks!

[burczu]

@CortneyOfstad As requirements has changed slightly I think we should ask @tienifr to update their proposal to address the updated issue, or maybe we should wait for more proposals here?

[CortneyOfstad]

@tienifr are you able to update your proposal to reflect the requirement changes? TIA!

[tienifr]

@CortneyOfstad @burczu Thanks for pointing that out, I'm updating my proposal

[tienifr]

@burczu I updated my proposal based on the new requirement. Because the 1:1 DM reports are already unbolded, so we just care about the IOU reports. Beside I just recorded the video result in offline mode because BE return the wrong data

[melvin-bot]

@nkuoch, @burczu, @CortneyOfstad Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[CortneyOfstad]

@burczu update on the proposal above ^^^

[CortneyOfstad]

@burczu bump ^^^ TIA!

[burczu]

@CortneyOfstad I'm sorry for the delay - I've missed this one... I've checked the updated proposal from @tienifr and I think we should give it a try. As their solution requires BE changes, I believe we need to switch to Internal for now to address this part of the fix first, and then get back to the FE part.

[CortneyOfstad]

Sorry for the trouble here! Per this post, we can close any bugs that are not related to Waves, so closing this out 👍 We can re-address once those waves are completed.