Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$750] Android - Split bill - _fake_ notification is received from the same user who creates the split bill #29217

Closed
1 of 6 tasks
lanitochka17 opened this issue Oct 10, 2023 · 38 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Internal Requires API changes or must be handled by Expensify staff

Comments

@lanitochka17
Copy link

lanitochka17 commented Oct 10, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 1.3.80-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Issue found when executing PR #27936

Action Performed:

  1. As admin, create a workspace and invite a member
  2. Log in as the same member on both Android app and another device
  3. On another device (not Android), go to FAB > Request money
  4. Click Split on the Workspace Chat in Step 1 and complete the split bill request

Expected Result:

User will not receive notification for split bill request when logged in on Android app as the same user

Actual Result:

User receives fake notification for split bill request when logged in on Android app as the same user

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Android: Native
Bug6232089_1696955937184.Screen_Recording_20231010_095954_Chrome.mp4
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01340929a43c2c3aa6
  • Upwork Job ID: 1712908072063881216
  • Last Price Increase: 2023-11-02
@lanitochka17 lanitochka17 added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Oct 10, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 10, 2023

Triggered auto assignment to @NicMendonca (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Oct 10, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@melvin-bot melvin-bot bot added the Overdue label Oct 13, 2023
@NicMendonca NicMendonca added the External Added to denote the issue can be worked on by a contributor label Oct 13, 2023
@melvin-bot melvin-bot bot changed the title Android - Split bill - _fake_ notification is received from the same user who creates the split bill [$500] Android - Split bill - _fake_ notification is received from the same user who creates the split bill Oct 13, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 13, 2023

Job added to Upwork: https://www.upwork.com/jobs/~01340929a43c2c3aa6

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Oct 13, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 13, 2023

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hoangzinh (External)

@NicMendonca
Copy link
Contributor

Sorry, missed this!

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Oct 13, 2023
@NicMendonca
Copy link
Contributor

waiting for proposals

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Oct 16, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 20, 2023

@hoangzinh, @NicMendonca Whoops! This issue is 2 days overdue. Let's get this updated quick!

@hoangzinh
Copy link
Contributor

waiting for proposals

@melvin-bot melvin-bot bot removed the Overdue label Oct 20, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 20, 2023

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@melvin-bot melvin-bot bot added the Overdue label Oct 23, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 24, 2023

@hoangzinh @NicMendonca this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@NicMendonca
Copy link
Contributor

@lanitochka17 - is this still reproducible?

@melvin-bot melvin-bot bot removed the Overdue label Oct 24, 2023
@lanitochka17
Copy link
Author

Issue reproducible on build 1.3.91-6

Screen_Recording_20231026_234602_Chrome.mp4

@melvin-bot melvin-bot bot added the Overdue label Oct 26, 2023
@NicMendonca NicMendonca changed the title [$500] Android - Split bill - _fake_ notification is received from the same user who creates the split bill [$750] Android - Split bill - _fake_ notification is received from the same user who creates the split bill Oct 26, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 26, 2023

Upwork job price has been updated to $750

Copy link

melvin-bot bot commented Oct 31, 2023

Triggered auto assignment to @johnmlee101 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

Copy link

melvin-bot bot commented Nov 2, 2023

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@NicMendonca
Copy link
Contributor

^ made this internal on purpose (cc @johnmlee101)

@melvin-bot melvin-bot bot added the Overdue label Nov 6, 2023
Copy link

melvin-bot bot commented Nov 6, 2023

@johnmlee101, @hoangzinh, @NicMendonca Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

Copy link

melvin-bot bot commented Nov 7, 2023

@johnmlee101 @hoangzinh @NicMendonca this issue is now 4 weeks old and preventing us from maintaining WAQ, can you:

  • Decide whether any proposals currently meet our guidelines and can be approved as-is today
  • If no proposals meet that standard, please take this issue internal and treat it as one of your highest priorities
  • If you have any questions, don't hesitate to start a discussion in #expensify-open-source

Thanks!

@melvin-bot melvin-bot bot removed External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors labels Nov 7, 2023
Copy link

melvin-bot bot commented Nov 8, 2023

@johnmlee101, @hoangzinh, @NicMendonca Huh... This is 4 days overdue. Who can take care of this?

@mvtglobally
Copy link

Issue not reproducible during KI retests. (First week)

Copy link

melvin-bot bot commented Nov 10, 2023

@johnmlee101, @hoangzinh, @NicMendonca Still overdue 6 days?! Let's take care of this!

1 similar comment
Copy link

melvin-bot bot commented Nov 10, 2023

@johnmlee101, @hoangzinh, @NicMendonca Still overdue 6 days?! Let's take care of this!

@NicMendonca
Copy link
Contributor

Waiting for this weeks KI retest

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Nov 13, 2023
Copy link

melvin-bot bot commented Nov 21, 2023

@johnmlee101, @hoangzinh, @NicMendonca Still overdue 6 days?! Let's take care of this!

Copy link

melvin-bot bot commented Nov 23, 2023

@johnmlee101, @hoangzinh, @NicMendonca 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

@NicMendonca
Copy link
Contributor

@mvtglobally - bump on latest test?

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Nov 24, 2023
@NicMendonca
Copy link
Contributor

@melvin-bot melvin-bot bot removed the Overdue label Nov 27, 2023
Copy link

melvin-bot bot commented Nov 30, 2023

@johnmlee101, @hoangzinh, @NicMendonca Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot melvin-bot bot added the Overdue label Nov 30, 2023
@mvtglobally
Copy link

We are not able to reproduce https://github.com/Expensify/App/assets/43995119/e5b82b08-8b75-48ab-a61f-07f4d75cee8b

@NicMendonca
Copy link
Contributor

closing!

@melvin-bot melvin-bot bot removed the Overdue label Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Internal Requires API changes or must be handled by Expensify staff
Projects
None yet
Development

No branches or pull requests

7 participants