-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2023-12-12] [P2P Activation] [External] [HIGH] Update the report when a payment is refunded #29319
Comments
@getusha here is the issue you'll be working on! |
Commenting... |
This issue has not been updated in over 15 days. @getusha eroding to Monthly issue. P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do! |
We're making progress on the App PR: #29344 We just need to iron out a few things and test it. @getusha let me know what you think of my latest comment: #29344 (comment) |
@getusha any update here? |
Triggered auto assignment to @rlinoz, see https://stackoverflow.com/c/expensify/questions/7972 for more details. |
I am not sure why I was assigned, is there anything left to do here? |
Oh, it is because of this #29344 (comment) |
Nope, all good, @rlinoz |
App PR was merged: #29344 Backend PRs:
|
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.7-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2023-12-12. 🎊 After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
|
@getusha lmk when you accept this job |
@kevinksullivan accepted |
All set |
Update the report when a payment is refunded
In ReportActionItem.js, add a handler for the REIMBURSEMENTDEQUEUED report action which will show:
We’ll update the report preview to say “Canceled” instead of “Pending” if the cancellation reason is
CANCEL_REASON_PAYMENT_EXPIRED
UI Details:
Enable Wallet
in this case, since we’ve already refunded the payer.The text was updated successfully, but these errors were encountered: