Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-12-12] [P2P Activation] [External] [HIGH] Update the report when a payment is refunded #29319

Closed
kevinksullivan opened this issue Oct 11, 2023 · 16 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2

Comments

@kevinksullivan
Copy link
Contributor

kevinksullivan commented Oct 11, 2023

Update the report when a payment is refunded

In ReportActionItem.js, add a handler for the REIMBURSEMENTDEQUEUED report action which will show:

Canceled the $%amount% payment, because %original recipient name% did not enable their Expensify Wallet within 30 days

We’ll update the report preview to say “Canceled” instead of “Pending” if the cancellation reason is CANCEL_REASON_PAYMENT_EXPIRED

image

UI Details:

  • System message: canceled the $30 payment, because %original recipient name% did not enable their Expensify Wallet within 30 days
  • We’ll update the report preview to say “Canceled” instead of “Pending”
  • We’ll hide the button to Enable Wallet in this case, since we’ve already refunded the payer.
@kevinksullivan kevinksullivan added the Daily KSv2 label Oct 11, 2023
@kevinksullivan
Copy link
Contributor Author

@getusha here is the issue you'll be working on!

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Oct 11, 2023
@getusha
Copy link
Contributor

getusha commented Oct 17, 2023

Commenting...

@melvin-bot melvin-bot bot added Monthly KSv2 and removed Weekly KSv2 labels Nov 13, 2023
Copy link

melvin-bot bot commented Nov 13, 2023

This issue has not been updated in over 15 days. @getusha eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@kevinksullivan
Copy link
Contributor Author

@MariaHCD @getusha updating this to weekly as we get closer. What's the latest here?

@kevinksullivan kevinksullivan added Weekly KSv2 and removed Monthly KSv2 labels Nov 14, 2023
@MariaHCD
Copy link
Contributor

We're making progress on the App PR: #29344 We just need to iron out a few things and test it.

@getusha let me know what you think of my latest comment: #29344 (comment)

@kevinksullivan
Copy link
Contributor Author

@getusha any update here?

Copy link

melvin-bot bot commented Nov 30, 2023

Triggered auto assignment to @rlinoz, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@rlinoz
Copy link
Contributor

rlinoz commented Nov 30, 2023

I am not sure why I was assigned, is there anything left to do here?

@rlinoz
Copy link
Contributor

rlinoz commented Nov 30, 2023

Oh, it is because of this #29344 (comment)

@MariaHCD
Copy link
Contributor

MariaHCD commented Dec 1, 2023

Nope, all good, @rlinoz

@MariaHCD MariaHCD assigned MariaHCD and unassigned rlinoz Dec 1, 2023
@MariaHCD
Copy link
Contributor

MariaHCD commented Dec 1, 2023

App PR was merged: #29344

Backend PRs:

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Dec 5, 2023
@melvin-bot melvin-bot bot changed the title [P2P Activation] [External] [HIGH] Update the report when a payment is refunded [HOLD for payment 2023-12-12] [P2P Activation] [External] [HIGH] Update the report when a payment is refunded Dec 5, 2023
Copy link

melvin-bot bot commented Dec 5, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Dec 5, 2023
Copy link

melvin-bot bot commented Dec 5, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.7-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-12-12. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Dec 11, 2023
@kevinksullivan
Copy link
Contributor Author

@getusha lmk when you accept this job

https://www.upwork.com/jobs/~016bf7581475c5f395

@getusha
Copy link
Contributor

getusha commented Dec 12, 2023

@kevinksullivan accepted

@melvin-bot melvin-bot bot added the Overdue label Dec 14, 2023
@kevinksullivan
Copy link
Contributor Author

All set

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2
Projects
None yet
Development

No branches or pull requests

4 participants