[HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-20] [HOLD for payment 2023-10-20] Send money - Split bill can be created on Send money page #29363

lanitochka17 · 2023-10-11T19:04:23Z

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

Version Number: 1.3.81-6

Reproducible in staging?: Yes

Reproducible in production?: No, feature is not available on production

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

Action Performed:

Go to staging.new.expensify.com
Go to FAB > Send money
Enter amount and click Next
Click split and proceed with split bill creation

Expected Result:

User should not be able to create split bill from Send money menu because split bill is accessible from Request money page

Actual Result:

User is able to create split bill from Send money menu

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Bug6233278_1697041837593.20231011_230836.mp4

MacOS: Desktop

View all open jobs on GitHub

melvin-bot · 2023-10-11T19:04:29Z

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot · 2023-10-11T19:04:31Z

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

OSBotify · 2023-10-11T19:12:54Z

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

melvin-bot · 2023-10-11T19:12:58Z

Triggered auto assignment to @stitesExpensify (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

alitoshmatov · 2023-10-11T19:19:16Z

I am available right now and can raise a PR quickly if needed

Proposal

Please re-state the problem that we are trying to solve in this issue.

Split bill can be created on Send money page

What is the root cause of that problem?

We are disabling split money option if it is a distance request(probably because send money feature was disabled for a while).

App/src/pages/iou/steps/MoneyRequstParticipantsPage/MoneyRequestParticipantsSelector.js

Line 243 in 81565ec

const isAllowedToSplit = !isDistanceRequest;

What changes do you think we should make in order to solve the problem?

We should modify it to check if iou type is sending money

    const isAllowedToSplit = !isDistanceRequest && iouType !== CONST.IOU.MONEY_REQUEST_TYPE.SEND;

What alternative solutions did you explore? (Optional)

adelekennedy · 2023-10-11T19:50:27Z

I think this is a bug (Send money shouldn't lead to split) but isn't a deploy blocker imo @stitesExpensify I'll let you make that call though if I'm missing something!

b4s36t4 · 2023-10-11T19:52:25Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

Send money - Split bill can be created on Send money page

What is the root cause of that problem?

We never did checked for the IOU type weather the request type is split or not although we did wrote things related to it.

What changes do you think we should make in order to solve the problem?

we can use the following variable

App/src/pages/iou/steps/MoneyRequstParticipantsPage/MoneyRequestParticipantsPage.js

Line 54 in fa34d33

const isSplitRequest = iou.id === CONST.IOU.MONEY_REQUEST_TYPE.SPLIT;

and pass it to the component here

App/src/pages/iou/steps/MoneyRequstParticipantsPage/MoneyRequestParticipantsPage.js

Line 113 in fa34d33

<MoneyRequestParticipantsSelector

which we can use to update this variable

App/src/pages/iou/steps/MoneyRequstParticipantsPage/MoneyRequestParticipantsSelector.js

Line 244 in fa34d33

const isAllowedToSplit = isSplitRequest || !isDistanceRequest;

What alternative solutions did you explore? (Optional)

NA

stitesExpensify · 2023-10-11T21:53:06Z

Agreed @adelekennedy not a deploy blocker. This is a little weird, but not enough that it really matters

mountiny · 2023-10-11T22:32:40Z

I got this one covered in this PR #29358

adelekennedy · 2023-10-11T23:51:17Z

amazing - seems like we can close then!

melvin-bot · 2023-10-13T22:08:09Z

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.83-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

[CP Staging] Fix couple of bugs in the Send money flow #29358

If no regressions arise, payment will be issued on 2023-10-20. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

melvin-bot · 2023-10-13T22:08:12Z

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@mountiny / @stitesExpensify] The PR that introduced the bug has been identified. Link to the PR:
[@mountiny / @stitesExpensify] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@mountiny / @stitesExpensify] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@mountiny / @stitesExpensify] Determine if we should create a regression test for this bug.
[@mountiny / @stitesExpensify] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@adelekennedy] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

melvin-bot · 2023-10-13T22:59:14Z

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.83-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

[CP Staging] Fix couple of bugs in the Send money flow #29358

If no regressions arise, payment will be issued on 2023-10-20. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

melvin-bot · 2023-10-13T22:59:16Z

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@mountiny / @stitesExpensify] The PR that introduced the bug has been identified. Link to the PR:
[@mountiny / @stitesExpensify] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@mountiny / @stitesExpensify] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@mountiny / @stitesExpensify] Determine if we should create a regression test for this bug.
[@mountiny / @stitesExpensify] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@adelekennedy] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

melvin-bot · 2023-10-16T21:21:52Z

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.84-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

[CP Staging] Fix couple of bugs in the Send money flow #29358

If no regressions arise, payment will be issued on 2023-10-23. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

melvin-bot · 2023-10-16T21:21:54Z

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@mountiny / @stitesExpensify] The PR that introduced the bug has been identified. Link to the PR:
[@mountiny / @stitesExpensify] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@mountiny / @stitesExpensify] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@mountiny / @stitesExpensify] Determine if we should create a regression test for this bug.
[@mountiny / @stitesExpensify] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@adelekennedy] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

melvin-bot · 2023-10-16T21:47:38Z

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.84-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

[CP Staging] Fix couple of bugs in the Send money flow #29358

If no regressions arise, payment will be issued on 2023-10-23. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

melvin-bot · 2023-10-16T21:47:40Z

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@mountiny / @stitesExpensify] The PR that introduced the bug has been identified. Link to the PR:
[@mountiny / @stitesExpensify] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@mountiny / @stitesExpensify] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@mountiny / @stitesExpensify] Determine if we should create a regression test for this bug.
[@mountiny / @stitesExpensify] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@adelekennedy] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

lanitochka17 added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Oct 11, 2023

melvin-bot bot assigned adelekennedy Oct 11, 2023

github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Oct 11, 2023

OSBotify mentioned this issue Oct 11, 2023

Deploy Checklist: New Expensify 2023-10-11 #29252

Closed

melvin-bot bot assigned stitesExpensify Oct 11, 2023

stitesExpensify removed the DeployBlockerCash This issue or pull request should block deployment label Oct 11, 2023

jasperhuangg added Daily KSv2 and removed Hourly KSv2 labels Oct 11, 2023

mountiny mentioned this issue Oct 11, 2023

[CP Staging] Fix couple of bugs in the Send money flow #29358

Merged

59 tasks

mountiny self-assigned this Oct 11, 2023

adelekennedy closed this as completed Oct 11, 2023

melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Daily KSv2 labels Oct 13, 2023

melvin-bot bot changed the title ~~Send money - Split bill can be created on Send money page~~ [HOLD for payment 2023-10-20] Send money - Split bill can be created on Send money page Oct 13, 2023

melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Oct 13, 2023

melvin-bot bot changed the title ~~[HOLD for payment 2023-10-20] Send money - Split bill can be created on Send money page~~ [HOLD for payment 2023-10-20] [HOLD for payment 2023-10-20] Send money - Split bill can be created on Send money page Oct 13, 2023

melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Oct 16, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-20] [HOLD for payment 2023-10-20] Send money - Split bill can be created on Send money page #29363

[HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-20] [HOLD for payment 2023-10-20] Send money - Split bill can be created on Send money page #29363

lanitochka17 commented Oct 11, 2023 •

edited

Loading

melvin-bot bot commented Oct 11, 2023

melvin-bot bot commented Oct 11, 2023 •

edited by adelekennedy

Loading

OSBotify commented Oct 11, 2023

melvin-bot bot commented Oct 11, 2023

alitoshmatov commented Oct 11, 2023 •

edited

Loading

adelekennedy commented Oct 11, 2023

b4s36t4 commented Oct 11, 2023

stitesExpensify commented Oct 11, 2023

mountiny commented Oct 11, 2023

adelekennedy commented Oct 11, 2023

melvin-bot bot commented Oct 13, 2023

melvin-bot bot commented Oct 13, 2023

melvin-bot bot commented Oct 13, 2023

melvin-bot bot commented Oct 13, 2023

melvin-bot bot commented Oct 16, 2023

melvin-bot bot commented Oct 16, 2023

melvin-bot bot commented Oct 16, 2023

melvin-bot bot commented Oct 16, 2023

[HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-20] [HOLD for payment 2023-10-20] Send money - Split bill can be created on Send money page #29363

[HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-20] [HOLD for payment 2023-10-20] Send money - Split bill can be created on Send money page #29363

Comments

lanitochka17 commented Oct 11, 2023 • edited Loading

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

melvin-bot bot commented Oct 11, 2023

melvin-bot bot commented Oct 11, 2023 • edited by adelekennedy Loading

Bug0 Triage Checklist (Main S/O)

OSBotify commented Oct 11, 2023

melvin-bot bot commented Oct 11, 2023

alitoshmatov commented Oct 11, 2023 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

adelekennedy commented Oct 11, 2023

b4s36t4 commented Oct 11, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

stitesExpensify commented Oct 11, 2023

mountiny commented Oct 11, 2023

adelekennedy commented Oct 11, 2023

melvin-bot bot commented Oct 13, 2023

melvin-bot bot commented Oct 13, 2023

melvin-bot bot commented Oct 13, 2023

melvin-bot bot commented Oct 13, 2023

melvin-bot bot commented Oct 16, 2023

melvin-bot bot commented Oct 16, 2023

melvin-bot bot commented Oct 16, 2023

melvin-bot bot commented Oct 16, 2023

lanitochka17 commented Oct 11, 2023 •

edited

Loading

melvin-bot bot commented Oct 11, 2023 •

edited by adelekennedy

Loading

alitoshmatov commented Oct 11, 2023 •

edited

Loading