[$500] Deeplinking to distantce request money allows requesting 0 amount

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.3.81-6
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @lidiyakelay
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1696946373513129

Action Performed:

1. go to + FAB
2. Click on request money
3. click on distance tab
4. go to the url 'https://staging.new.expensify.com/request/new/distance' change distance to 'participants'

Expected Result:

the url redirects back

Actual Result:

url goes to participants allowing user to request 0 amount

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Android: Native

Android: mWeb Chrome

4_5852834878667624402.mp4

iOS: Native

iOS: mWeb Safari

4_5852491904054202624.MP4

MacOS: Chrome / Safari

participants.mp4

MacOS: Desktop

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01b1f3e4d9495c91ca
• Upwork Job ID: 1712257041055375360
• Last Price Increase: 2023-10-12

[melvin-bot]

Triggered auto assignment to @maddylewis (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01b1f3e4d9495c91ca

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)

[graylewis]

This seems related to this ongoing refactor: #26538.

There's a pretty clear fix here: check if there are defined waypoints in the request and trigger goBack if there isn't. This was already attempted here: #27826
It failed because the waypoints weren't defined in the first frame. This could probably be fixed with a well-defined dependency array in useEffect.

If it's still deemed worthwhile to attempt another patch while the refactor is ongoing, I'd be happy to write a proper proposal @maddylewis

[DylanDylann]

This issue will be resolved after my PR is merged. We should hold this issue

[maddylewis]

PR is open / still holding

[maddylewis]

looks like this has since merged - #28308

@mollfpr - when you have a chance, could you confirm if this bug is still reproducible? ty!

[DylanDylann]

This issue is resolved. Let's close

[melvin-bot]

@mollfpr @maddylewis this issue is now 4 weeks old and preventing us from maintaining WAQ, can you:

• Decide whether any proposals currently meet our guidelines and can be approved as-is today
• If no proposals meet that standard, please take this issue internal and treat it as one of your highest priorities
• If you have any questions, don't hesitate to start a discussion in #expensify-open-source

Thanks!

[melvin-bot]

Current assignee @mollfpr is eligible for the Internal assigner, not assigning anyone new.

[mollfpr]

I confirmed this issue is solved.

Screen.Recording.2023-11-09.at.21.36.44.mp4

We can close the issue now.