[HOLD for payment 2023-10-23][$125] Send money - Avatars and names overlap in Send money report details page

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.3.83-1

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team/ @aman-atg

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1697098677979179

Action Performed:

1. Go to staging.new.expensify.com
2. Go to + > Send money
3. Send money to any user
4. Click on the IOU preview to open report page
5. Click on the avatar on the header
   Note that the avatars and names overlap in Send money details page

Expected Result:

The avatars and names do not overlap in Send money details page

Actual Result:

The avatars and names overlap in Send money details page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Bug6234355_1697113243739.20231012_194223.mp4

MacOS: Desktop

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01bf850787ca824440
• Upwork Job ID: 1712525329990500352
• Last Price Increase: 2023-10-12
• Automatic offers:
• akinwale | Reviewer | 27165440
• hungvu193 | Contributor | 27165444

[melvin-bot]

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[hungvu193]

Another regression from #28323

cc @Pujan92

[Pujan92]

@hungvu193 It is not from my PR as it is also reproduced in the staging. My PR is not deployed to the staging yet.

[aman-atg]

I reported this here. Please update the reporter if my report was posted before the QA

cc: @kavimuru

[hungvu193]

@hungvu193 It is not from my PR as it is also reproduced in the staging. My PR is not deployed to the staging yet.

My bad. I fixed the issue by reverting your changes 😂 . Agreed this is not regression from your PR.

[hungvu193]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Avatars and names overlap in Send money report details page.

What is the root cause of that problem?

We're using size={CONST.AVATAR_SIZE.LARGE} for our multiple avatar of Request Money here.

App/src/pages/ReportDetailsPage.js

Lines 168 to 170 in 2c9c303

	<MultipleAvatars
	icons={icons}
	size={CONST.AVATAR_SIZE.LARGE}

However we didn't have it here:

App/src/styles/StyleUtils.ts

Lines 1271 to 1286 in 2c9c303

	function getContainerStyles(size: string, isInReportAction = false): Array<ViewStyle | CSSProperties> {
	let containerStyles: Array<ViewStyle | CSSProperties>;
	switch (size) {
	case CONST.AVATAR_SIZE.SMALL:
	containerStyles = [styles.emptyAvatarSmall, styles.emptyAvatarMarginSmall];
	break;
	case CONST.AVATAR_SIZE.SMALLER:
	containerStyles = [styles.emptyAvatarSmaller, styles.emptyAvatarMarginSmaller];
	break;
	case CONST.AVATAR_SIZE.MEDIUM:
	containerStyles = [styles.emptyAvatarMedium, styles.emptyAvatarMargin];
	break;
	default:
	containerStyles = [styles.emptyAvatar, isInReportAction ? styles.emptyAvatarMarginChat : styles.emptyAvatarMargin];
	}

It will lead to default case which didn't have the margin bottom which caused this issue.

What changes do you think we should make in order to solve the problem?

We should add the case for CONST.AVATAR_SIZE.LARGE in getContainerStyles as well, it should be:

function getContainerStyles(size: string, isInReportAction = false): Array<ViewStyle | CSSProperties> {
    let containerStyles: Array<ViewStyle | CSSProperties>;

    switch (size) {
        case CONST.AVATAR_SIZE.SMALL:
            containerStyles = [styles.emptyAvatarSmall, styles.emptyAvatarMarginSmall];
            break;
        case CONST.AVATAR_SIZE.SMALLER:
            containerStyles = [styles.emptyAvatarSmaller, styles.emptyAvatarMarginSmaller];
            break;
        case CONST.AVATAR_SIZE.MEDIUM:
            containerStyles = [styles.emptyAvatarMedium, styles.emptyAvatarMargin];
            break;
        case CONST.AVATAR_SIZE.LARGE:
            containerStyles = [styles.emptyAvatarLarge, styles.mb2, styles.mr2];
            break;
        default:
            containerStyles = [styles.emptyAvatar, isInReportAction ? styles.emptyAvatarMarginChat : styles.emptyAvatarMargin];
    }

    return containerStyles;
}

What alternative solutions did you explore? (Optional)

N/A

[Pujan92]

I see it is added here cc: @fedirjh

Seems like a bad merge but not able to find out where it is missed 😅, would be great if someone helps what happened exactly in this history https://github.com/Expensify/App/commits/main/src/components/MultipleAvatars.js

A simple way to fix this is by adding those lines back here in this PR.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01bf850787ca824440

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @akinwale (External)

[melvin-bot]

Upwork job price has been updated to $125

[akinwale]

@hungvu193's proposal correctly identifies the source of the problem, and the recommended fix is straightforward.

🎀 👀 🎀 C+ reviewed.

[melvin-bot]

Triggered auto assignment to @joelbettner, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mountiny] The PR that introduced the bug has been identified. Link to the PR:
• [@mountiny] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@mountiny] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@mountiny] Determine if we should create a regression test for this bug.
• [@mountiny] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@dylanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.84-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Fix: Send money - Avatars and names overlap in Send money report details page #29483

If no regressions arise, payment will be issued on 2023-10-23. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mountiny] The PR that introduced the bug has been identified. Link to the PR:
• [@mountiny] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@mountiny] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@mountiny] Determine if we should create a regression test for this bug.
• [@mountiny] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@dylanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[mountiny]

Deploy blocker, regression was clear and we have raised it above, no need for the checklist or special regression test, only payment to the bug reporter

[mountiny]

@dylanexpensify ready for payment

[melvin-bot]

@mountiny, @dylanexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[mountiny]

Waiting for payment

[dylanexpensify]

on it now!

[dylanexpensify]

done

[aman-atg]

@dylanexpensify Sorry but I'm not able to find the upwork job for this. Can you share the link with me? Found the link in OP and applied on Upwork for the reporting bonus.

[aman-atg]

bump @dylanexpensify

@mountiny Will it be better to just add this reporting bonus into some other job like this one.

[dylanexpensify]

ah paying now!

[dylanexpensify]

offer sent @aman-atg!

[aman-atg]

Accepted the offer!

[dylanexpensify]

done!