Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$500] Desktop - Avatar isn't showing in the chat row until clicking into that row #29460

Closed
1 of 6 tasks
kbecciv opened this issue Oct 12, 2023 · 35 comments
Closed
1 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Internal Requires API changes or must be handled by Expensify staff Weekly KSv2

Comments

@kbecciv
Copy link

kbecciv commented Oct 12, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 1.3.80.1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @kevinksullivan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1697055821976289

Action Performed:

  1. Sent a DM message to ~20 customers via our internal compose tool
  2. Logged in
  3. Saw the DMs

Expected Result:

All DMs would have the avatar of the person I am speaking with in the row

Actual Result:

Some of the DMs didn't show an avatar until clicking into that DM

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop

image

http://g.recordit.co/96JvXGqDgK.gif

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~016c1d1ffb1e39b663
  • Upwork Job ID: 1712488974749863936
  • Last Price Increase: 2023-11-02
@kbecciv kbecciv added External Added to denote the issue can be worked on by a contributor Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Oct 12, 2023
@melvin-bot melvin-bot bot changed the title Desktop - Avatar isn't showing in the chat row until clicking into that row [$500] Desktop - Avatar isn't showing in the chat row until clicking into that row Oct 12, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 12, 2023

Job added to Upwork: https://www.upwork.com/jobs/~016c1d1ffb1e39b663

@melvin-bot
Copy link

melvin-bot bot commented Oct 12, 2023

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Oct 12, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Oct 12, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 12, 2023

Triggered auto assignment to Contributor-plus team member for initial proposal review - @situchan (External)

@melvin-bot melvin-bot bot added the Overdue label Oct 16, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 16, 2023

@stephanieelliott, @situchan Whoops! This issue is 2 days overdue. Let's get this updated quick!

@stephanieelliott
Copy link
Contributor

Seeing as this applies to the Compose tool this will need to be internal.

@melvin-bot melvin-bot bot removed the Overdue label Oct 17, 2023
@stephanieelliott stephanieelliott added Internal Requires API changes or must be handled by Expensify staff and removed Help Wanted Apply this label when an issue is open to proposals by contributors labels Oct 17, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 17, 2023

Current assignee @situchan is eligible for the Internal assigner, not assigning anyone new.

@stephanieelliott stephanieelliott removed the External Added to denote the issue can be worked on by a contributor label Oct 17, 2023
@melvin-bot melvin-bot bot added the Overdue label Oct 19, 2023
@stephanieelliott
Copy link
Contributor

Not overdue, forgot I to also add Engineering label.

Just want to check first though -- @situchan do you agree that this needs an internal engineer to make BE changes?

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Oct 20, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 23, 2023

@stephanieelliott, @situchan Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@situchan
Copy link
Contributor

@stephanieelliott I think we should fix this in frontend.

@melvin-bot melvin-bot bot removed the Overdue label Oct 24, 2023
@stephanieelliott
Copy link
Contributor

Ah ok, thanks @situchan, adjusting labels.

@stephanieelliott stephanieelliott added External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors and removed Internal Requires API changes or must be handled by Expensify staff labels Oct 25, 2023
@barttom
Copy link
Contributor

barttom commented Nov 6, 2023

Could You just explain what is 'internal compose tool'?
Just wonder if I'm able to reproduce that by sending messages from the app
@situchan @stephanieelliott

@situchan
Copy link
Contributor

situchan commented Nov 6, 2023

I am not sure. @kevinksullivan or @stephanieelliott may have answer.

@melvin-bot melvin-bot bot removed the Overdue label Nov 6, 2023
@stephanieelliott
Copy link
Contributor

Hey @kevinksullivan are you referring to the Compose tool in Concierge? Or are you referring to sending a group DM in newdot?

@barttom
Copy link
Contributor

barttom commented Nov 7, 2023

@kevinksullivan please send more information on how You send these 20s messages. That helps me to reproduce the issue ;)

@stephanieelliott
Copy link
Contributor

stephanieelliott commented Nov 7, 2023

Looking at the thread in Slack, this seems to be our internal composer tool. As discussed there we should move this back to internal:

https://expensify.slack.com/archives/C049HHMV9SM/p1697055821976289

@stephanieelliott stephanieelliott added Internal Requires API changes or must be handled by Expensify staff and removed External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors labels Nov 7, 2023
Copy link

melvin-bot bot commented Nov 7, 2023

Current assignee @situchan is eligible for the Internal assigner, not assigning anyone new.

Copy link

melvin-bot bot commented Nov 7, 2023

Triggered auto assignment to @puneetlath (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@puneetlath
Copy link
Contributor

Does this affect the users receiving the messages? Or just our internal employees?

@stephanieelliott
Copy link
Contributor

@puneetlath it affects the message sender only - so only our internal employees in this case!

@puneetlath
Copy link
Contributor

Ok got it. Seems not super urgent then.

And when you sign out and sign back in, are the avatars in the LHN? My guess is that we don't send a pusher update which is why this is the case.

@puneetlath puneetlath added Weekly KSv2 and removed Daily KSv2 labels Nov 7, 2023
Copy link

melvin-bot bot commented Nov 9, 2023

@puneetlath @stephanieelliott @situchan this issue is now 4 weeks old and preventing us from maintaining WAQ. This should now be your highest priority. Please post below what your plan is to get a PR in review ASAP. Thanks!

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Nov 9, 2023
@puneetlath
Copy link
Contributor

@stephanieelliott just a friendly bump on the question above when you have a chance.

@puneetlath puneetlath added Weekly KSv2 and removed Daily KSv2 labels Nov 10, 2023
@stephanieelliott
Copy link
Contributor

Just tested @puneetlath -- yep, the avatars populate in the LHN on signout/signin!

@stephanieelliott
Copy link
Contributor

Hey @puneetlath what do you think about this one -- worth fixing? If yes, does it need to be fixed internally or is there a portion we can make external?

@puneetlath
Copy link
Contributor

I'm thinking that it's not worth fixing right now since it only affects internal employees. What do you think?

@stephanieelliott
Copy link
Contributor

I agree, esp considering it doesn't affect functionality. Let's close it for now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Internal Requires API changes or must be handled by Expensify staff Weekly KSv2
Projects
None yet
Development

No branches or pull requests

5 participants