-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$500] Desktop - Avatar isn't showing in the chat row until clicking into that row #29460
Comments
Job added to Upwork: https://www.upwork.com/jobs/~016c1d1ffb1e39b663 |
Triggered auto assignment to @stephanieelliott ( |
Bug0 Triage Checklist (Main S/O)
|
Triggered auto assignment to Contributor-plus team member for initial proposal review - @situchan ( |
@stephanieelliott, @situchan Whoops! This issue is 2 days overdue. Let's get this updated quick! |
Seeing as this applies to the Compose tool this will need to be internal. |
Current assignee @situchan is eligible for the Internal assigner, not assigning anyone new. |
Not overdue, forgot I to also add Engineering label. Just want to check first though -- @situchan do you agree that this needs an internal engineer to make BE changes? |
@stephanieelliott, @situchan Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
@stephanieelliott I think we should fix this in frontend. |
Ah ok, thanks @situchan, adjusting labels. |
Could You just explain what is 'internal compose tool'? |
I am not sure. @kevinksullivan or @stephanieelliott may have answer. |
Hey @kevinksullivan are you referring to the Compose tool in Concierge? Or are you referring to sending a group DM in newdot? |
@kevinksullivan please send more information on how You send these 20s messages. That helps me to reproduce the issue ;) |
Looking at the thread in Slack, this seems to be our internal composer tool. As discussed there we should move this back to internal: https://expensify.slack.com/archives/C049HHMV9SM/p1697055821976289 |
Current assignee @situchan is eligible for the Internal assigner, not assigning anyone new. |
Triggered auto assignment to @puneetlath ( |
Does this affect the users receiving the messages? Or just our internal employees? |
@puneetlath it affects the message sender only - so only our internal employees in this case! |
Ok got it. Seems not super urgent then. And when you sign out and sign back in, are the avatars in the LHN? My guess is that we don't send a pusher update which is why this is the case. |
@puneetlath @stephanieelliott @situchan this issue is now 4 weeks old and preventing us from maintaining WAQ. This should now be your highest priority. Please post below what your plan is to get a PR in review ASAP. Thanks! |
@stephanieelliott just a friendly bump on the question above when you have a chance. |
Just tested @puneetlath -- yep, the avatars populate in the LHN on signout/signin! |
Hey @puneetlath what do you think about this one -- worth fixing? If yes, does it need to be fixed internally or is there a portion we can make external? |
I'm thinking that it's not worth fixing right now since it only affects internal employees. What do you think? |
I agree, esp considering it doesn't affect functionality. Let's close it for now! |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: 1.3.80.1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @kevinksullivan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1697055821976289
Action Performed:
Expected Result:
All DMs would have the avatar of the person I am speaking with in the row
Actual Result:
Some of the DMs didn't show an avatar until clicking into that DM
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop
http://g.recordit.co/96JvXGqDgK.gif
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: