[HOLD for payment 2023-10-24] [$500] DEV: console error on click of send money

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: Dev
Reproducible in staging?: Reproduced in Dev only
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1697088716700199

Action Performed:

1. click FAB icon
2. select send money option

Expected Result:

should not show console error

Actual Result:

console error appears(forwardRef render functions do not support propTypes or defaultProps. Did you accidentally pass a React component?)

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Android: Native

Screen_Recording_20231012_110955_New.Expensify.Dev.mp4

Android: mWeb Chrome

Screen_Recording_20231012_110826_Chrome.mp4

iOS: Native

Simulator.Screen.Recording.-.iPhone.13.-.2023-10-12.at.11.11.14.mp4

iOS: mWeb Safari

RPReplay_Final1697088838.MP4

MacOS: Chrome / Safari

Screen.Recording.2023-10-12.at.10.59.50.AM.mov

MacOS: Desktop

Screen.Recording.2023-10-12.at.11.06.21.AM.mov

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01260d59659dd2e2bf
• Upwork Job ID: 1712499464820834304
• Last Price Increase: 2023-10-12
• Automatic offers:
• akinwale | Reviewer | 27184034
• pradeepmdk | Contributor | 27184036
• gadhiyamanan | Reporter | 27184038

[melvin-bot]

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01260d59659dd2e2bf

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @akinwale (External)

[melvin-bot]

📣 @ilmzone! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[zzarcon]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When clicking on send money, an error appears due to the usage of propTypes and defaultProps and wrapping the NavigationAwareCamera component with a forwardRef.

src/pages/iou/ReceiptSelector/NavigationAwareCamera.js

What is the root cause of that problem?

propTypes and defaultProps can't be used together with forwardRef

What changes do you think we should make in order to solve the problem?

we need to replace how we use forwardRef

NavigationAwareCamera.propTypes = propTypes;
NavigationAwareCamera.displayName = 'NavigationAwareCamera';
NavigationAwareCamera.defaultProps = defaultProps;

export default React.forwardRef(NavigationAwareCamera);

by:

export default React.forwardRef((props, ref) => (
    <NavigationAwareCamera
        // eslint-disable-next-line react/jsx-props-no-spreading
        {...props}
        innerRef={ref}
    />
));

that way we can keep both the propTypes and the defaultProps along with using forwardRef

[pradeepmdk]

Proposal

Please re-state the problem that we are trying to solve in this issue.

console error on click of send money

What is the root cause of that problem?

https://expensify.slack.com/archives/C01GTK53T8Q/p1695110739750909
we already discussed in Slack
and updated doc here https://github.com/Expensify/App/blob/main/contributingGuides/TS_CHEATSHEET.md#forwardRef
from this PR
#28411

What changes do you think we should make in order to solve the problem?

https://github.com/Expensify/App/blob/main/src/pages/iou/ReceiptSelector/NavigationAwareCamera.js and
https://github.com/Expensify/App/blob/main/src/pages/iou/ReceiptSelector/NavigationAwareCamera.native.js
here we need changes like

const NavigationAwareCamera = React.forwardRef(({torchOn, onTorchAvailability, ...props}, ref) => {
++
export default NavigationAwareCamera

or

const ForwaredNavigationAwareCamera =  React.forwardRef(NavigationAwareCamera);
ForwaredNavigationAwareCamera.propTypes = propTypes;
ForwaredNavigationAwareCamera.displayName = 'NavigationAwareCamera';
ForwaredNavigationAwareCamera.defaultProps = defaultProps;

export default ForwaredNavigationAwareCamera

[akinwale]

While both proposals so far would solve the issue, I would recommend going with @pradeepmdk's solution as this follows the documented coding standards. The MenuItem component would be a good reference point to follow for implementation.

🎀 👀 🎀 C+ reviewed.

[melvin-bot]

Triggered auto assignment to @cristipaval, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

📣 @akinwale 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @pradeepmdk 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

📣 @gadhiyamanan 🎉 An offer has been automatically sent to your Upwork account for the Reporter role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[pradeepmdk]

@akinwale Pr is ready for review

[melvin-bot]

🎯 ⚡️ Woah @akinwale / @pradeepmdk, great job pushing this forwards! ⚡️

The pull request got merged within 3 working days of assignment, so this job is eligible for a 50% #urgency bonus 🎉

• when @pradeepmdk got assigned: 2023-10-13 17:35:35 Z
• when the PR got merged: 2023-10-16 09:33:32 UTC

On to the next one 🚀

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.85-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• remove console error #29603

If no regressions arise, payment will be issued on 2023-10-24. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @akinwale requires payment offer (Reviewer)
• @pradeepmdk requires payment offer (Contributor)
• @gadhiyamanan requires payment offer (Reporter)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@akinwale] The PR that introduced the bug has been identified. Link to the PR:
• [@akinwale] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@akinwale] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@akinwale] Determine if we should create a regression test for this bug.
• [@akinwale] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@lschurr] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[lschurr]

@akinwale could you work on the checklist for this one?

[akinwale]

• [@akinwale] The PR that introduced the bug has been identified. Link to the PR:
• [@akinwale] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

No offending PR, but there is now a standard for using React.forwardRef as pointed out in the selected proposal. New implementations can refer to this going forward. https://github.com/Expensify/App/blob/main/contributingGuides/TS_CHEATSHEET.md#forwardRef

• [@akinwale] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

Not a regression, it was an erroneous implementation approach with React.forwardRef.

• [@akinwale] Determine if we should create a regression test for this bug.
• [@akinwale] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression test

1. Launch Expensify in a browser.
2. Open the browser developer tools and select the Console tab to monitor for errors.
3. Open the global create menu and select Send money.
4. Verify that there is no console error after the Send money flow starts.

Do we agree 👍 or 👎

[akinwale]

@lschurr Done!

[lschurr]

Payment summary:

• Bug reporter: @gadhiyamanan $50
• Contributor: @pradeepmdk $750
• Contributor+: @akinwale $750

[lschurr]

All paid! Closing.