Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-10-25] Updates to the help site's visual design #29481

Closed
maddylewis opened this issue Oct 12, 2023 · 17 comments
Closed
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Design

Comments

@maddylewis
Copy link
Contributor

maddylewis commented Oct 12, 2023

Main cleanup tracking issue - #28497

Problem

The existing help site pages are challenging to read -- the text is close together, the headings aren't sized correctly, the background vs text color is creating readability issues.
image

Solution(s)

  1. Create more space between text
  2. Create more space between paragraphs
  3. Update how the # and ### headers are styled on the site
  4. Alternate the backgrounds between headers to help visually separate the sections of the resource more
@maddylewis maddylewis added Daily KSv2 Design Bug Something is broken. Auto assigns a BugZero manager. labels Oct 12, 2023
@melvin-bot

This comment was marked as off-topic.

@melvin-bot

This comment was marked as off-topic.

@melvin-bot

This comment was marked as off-topic.

@dubielzyk-expensify
Copy link
Contributor

Added some progress here

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Oct 13, 2023
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Oct 13, 2023
@melvin-bot melvin-bot bot changed the title Updates to the help site's visual design [HOLD for payment 2023-10-25] Updates to the help site's visual design Oct 18, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Oct 18, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 18, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot
Copy link

melvin-bot bot commented Oct 18, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.86-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-10-25. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

  • @rushatgabhane does not require payment (Eligible for Manual Requests)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@melvin-bot

This comment was marked as off-topic.

@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels Oct 25, 2023
@maddylewis
Copy link
Contributor Author

maddylewis commented Oct 27, 2023

Payment

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Oct 27, 2023
@maddylewis
Copy link
Contributor Author

@rushatgabhane - was there a separate payment issue created for this one? lmk if i should be the one processing payment ty

@melvin-bot melvin-bot bot removed the Overdue label Oct 30, 2023
@rushatgabhane
Copy link
Member

rushatgabhane commented Nov 2, 2023

@maddylewis thank you, I'll request it on new dot. So no action needed by you here

https://staging.new.expensify.com/r/1758041640613790

@melvin-bot melvin-bot bot added the Overdue label Nov 6, 2023
Copy link

melvin-bot bot commented Nov 7, 2023

@rushatgabhane, @maddylewis, @dubielzyk-expensify Huh... This is 4 days overdue. Who can take care of this?

@maddylewis
Copy link
Contributor Author

@rushatgabhane / @dubielzyk-expensify - are we all set on this one? lmk if we're good to close 👍

@melvin-bot melvin-bot bot removed the Overdue label Nov 8, 2023
@dubielzyk-expensify
Copy link
Contributor

If the code changes have been pushed, then yep, we're good to go.

@maddylewis
Copy link
Contributor Author

looks like this was merged so yes, i shall close! #29539

@maddylewis
Copy link
Contributor Author

actually it's maybe not updated on prod yet, so I'll keep open.

@melvin-bot melvin-bot bot added the Overdue label Nov 13, 2023
@rushatgabhane
Copy link
Member

for helpdot, merge = deploy!! we can close this @maddylewis

@melvin-bot melvin-bot bot removed the Overdue label Nov 13, 2023
@JmillsExpensify
Copy link

$500 payment approved for @rushatgabhane based on this comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Design
Projects
None yet
Development

No branches or pull requests

5 participants