[HOLD for payment 2023-10-24] [$500] Inconsistency when clicking on the room avatar

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.3.83-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @namhihi237
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1697102736759189

Action Performed:

1. Create a public room and copy URL
2. Send a message
3. Hover on message and click reply in thread
4. Send a message in thread
5. Logout and open the room
6. Click open thread of message in the room
7. Click on avatar on header, see open room detail
8. Click on avatar on footer, see open the profile page

Expected Result:

Open room detail when click room avatar footer

Actual Result:

Open profile detail when click room avatar footer

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Android: Native

Screen.Recording.2023-10-12.at.16.49.16.mov

Android: mWeb Chrome

Screen.Recording.2023-10-12.at.17.25.11.mov

iOS: Native

Screen.Recording.2023-10-12.at.16.50.18.mov

iOS: mWeb Safari

Screen.Recording.2023-10-12.at.17.24.36.mov

MacOS: Chrome / Safari

Screen.Recording.2023-10-12.at.16.26.22.mov

room.avatar.mp4

MacOS: Desktop

Screen.Recording.2023-10-12.at.17.32.26.mov

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01d73ef1f708111770
• Upwork Job ID: 1712560508209545216
• Last Price Increase: 2023-10-12
• Automatic offers:
• namhihi237 | Contributor | 27188871
• namhihi237 | Reporter | 27188873

[melvin-bot]

Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01d73ef1f708111770

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

[m-natarajan]

Proposal by @namhihi237

Please re-state the problem that we are trying to solve in this issue.

Open room detail when clicking the room avatar on the footer

What is the root cause of that problem?

In AnonymousReportFooter we use AvatarWithDisplayName to show the room avatar here

App/src/components/AnonymousReportFooter.js

Lines 35 to 39 in 6c7ee53

	<AvatarWithDisplayName
	report={props.report}
	personalDetails={props.personalDetails}
	isAnonymous
	/>

In the AvatarWithDisplayName component we miss passing shouldEnableDetailPageNavigation prop to show the detail room.

What changes do you think we should make in order to solve the problem?

We should pass shouldEnableDetailPageNavigation prop into AvatarWithDisplayName

What alternative solutions did you explore? (Optional)

N/A

[thesahindia]

@namhihi237's proposal looks good to me!

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @francoisl, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[namhihi237]

Thanks for review

[francoisl]

Seems pretty straightforward, let's go with that 👍

[melvin-bot]

📣 @thesahindia Please request via NewDot manual requests for the Reviewer role ($500)

[melvin-bot]

📣 @namhihi237 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

📣 @namhihi237 🎉 An offer has been automatically sent to your Upwork account for the Reporter role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

🎯 ⚡️ Woah @thesahindia / @namhihi237, great job pushing this forwards! ⚡️

The pull request got merged within 3 working days of assignment, so this job is eligible for a 50% #urgency bonus 🎉

• when @namhihi237 got assigned: 2023-10-14 00:49:39 Z
• when the PR got merged: 2023-10-16 18:50:55 UTC

On to the next one 🚀

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.85-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix click room avatar footer #29599

If no regressions arise, payment will be issued on 2023-10-24. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @namhihi237 requires payment offer (Contributor)
• @thesahindia does not require payment (Eligible for Manual Requests)
• @namhihi237 requires payment offer (Contributor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@thesahindia] The PR that introduced the bug has been identified. Link to the PR:
• [@thesahindia] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@thesahindia] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@thesahindia] Determine if we should create a regression test for this bug.
• [@thesahindia] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@laurenreidexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[laurenreidexpensify]

Payment Summary:

• External issue reporter - @namhihi237 $50 payment issued in Upwork
• Contributor that fixed the issue - @namhihi237 $500 +$250 payment issued in Upwork
• Contributor+ that helped on the issue and/or PR - @thesahindia $500 + $250, please request in newdot

[namhihi237]

Hi @laurenreidexpensify I think I and @thesahindia are eligible for an urgent bonus, please help to check.

[laurenreidexpensify]

@thesahindia bump on checklist thanks

[laurenreidexpensify]

@thesahindia can we get this one wrapped up today? Thanks!

[thesahindia]

This case was missed during the implementation in #19694. I think we should just add a test case.

1. Create a public room and copy the URL
2. Send a message in the room
3. Hover on the message and click reply in thread
4. Send a message in a thread
5. Logout and open the room by deep link
6. Click open thread of message in the room
7. Click on avatar on the footer
8. Verify that you get navigated to the room details page

[JmillsExpensify]

$750 payment approved based on this summary.