[HOLD for payment 2023-11-13] [HOLD E/E #326097] [Wave 6: Workspace Chats] Update how GBR is determined for IOU/expense reports

[puneetlath]

In https://github.com/Expensify/Expensify/issues/326097 we are adding a new hasOutstandingChildIOU field. We need to update the way ReportUtils.isWaitingForIOUActionFromCurrentUser determines which reports to show the GBR on. It should be based on the hasOutstandingChildIOU field.

This is described in the workspace chats design doc here.

[melvin-bot]

Current assignee @puneetlath is eligible for the NewFeature assigner, not assigning anyone new.

[waterim]

Hello, Im Artem from Callstack and would like to help with this one!

[greg-schroeder]

FYI @waterim, from Slack: https://expensify.slack.com/archives/C02MW39LT9N/p1697583395704569?thread_ts=1697503628.240919&cid=C02MW39LT9N

It would be nice if we could clean up/centralize the GBR (green dot) logic while we’re doing this. To ensure that:

1. the green dot always makes the chat go to the top of the list under pinned chats (no matter how the green dot is being set, via mention, outstanding IOU or something else)
2. the green dot always makes a chat visible in focus mode

[puneetlath]

Reminder: we also need to add this new field to the typescript types for reports.

[puneetlath]

@waterim FYI we've started sending the hasOutstandingChildRequest field on staging. Right now it only is being sent in Most Recent mode, not in #focus mode. So you should be able to test your PR with the back-end in most recent mode to make sure things are working as expected.

[waterim]

@puneetlath nice to hear!
testing

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.95-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Feat: Update how GBR is determined for IOU/expense reports #30655

If no regressions arise, payment will be issued on 2023-11-13. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @waterim does not require payment (Contractor)

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@waterim] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@puneetlath] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[puneetlath]

We should add regression tests for this. I'll propose them.

[puneetlath]

Also, @akinwale was the C+

[waterim]

Where to add these steps?

[puneetlath]

I'll take care of it don't worry. The automation wrongly tagged you for that.

[puneetlath]

Actually, we already have a separate issue for handling that here: https://github.com/Expensify/Expensify/issues/319016

So all that is left to happen on this issue is paying @akinwale out next week.

[puneetlath]

@akinwale offer here: https://www.upwork.com/nx/wm/offer/27646277

Ping me on this issue when you've accepted please.

[akinwale]

@akinwale offer here: https://www.upwork.com/nx/wm/offer/27646277

Ping me on this issue when you've accepted please.

@puneetlath Accepted. Thanks!

[puneetlath]

All paid. Thanks everyone!